2023-03-13 00:44:15

by Peng Fan (OSS)

Subject: [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields

From: Peng Fan <[email protected]>

The clang-analyzer reports:
"Excessive padding in 'struct imx8m_blk_ctrl_domain_data'
(12 padding bytes, where 4 is optimal). Optimal fields order: name,
clk_names, path_names, gpc_name, num_clks, num_paths, rst_mask, clk_mask,
mipi_phy_rst_mask, consider reordering the fields or adding explicit
padding members [clang-analyzer-optin.performance.Padding]
struct imx8m_blk_ctrl_domain_data {"

So reordering the fields.

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
drivers/soc/imx/imx8m-blk-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index 9b0f81dc292b..716e6eb4838f 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -37,10 +37,10 @@ struct imx8m_blk_ctrl {
struct imx8m_blk_ctrl_domain_data {
const char *name;
const char * const *clk_names;
- int num_clks;
const char * const *path_names;
- int num_paths;
const char *gpc_name;
+ int num_clks;
+ int num_paths;
u32 rst_mask;
u32 clk_mask;

--
2.37.1

2023-03-27 01:56:59

by Shawn Guo

Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: reordering the fields

On Mon, Mar 13, 2023 at 08:49:03AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The clang-analyzer reports:
> "Excessive padding in 'struct imx8m_blk_ctrl_domain_data'
> (12 padding bytes, where 4 is optimal). Optimal fields order: name,
> clk_names, path_names, gpc_name, num_clks, num_paths, rst_mask, clk_mask,
> mipi_phy_rst_mask, consider reordering the fields or adding explicit
> padding members [clang-analyzer-optin.performance.Padding]
> struct imx8m_blk_ctrl_domain_data {"
>
> So reordering the fields.
>
> Reported-by: kernel test robot <[email protected]>
> Signed-off-by: Peng Fan <[email protected]>

Applied, thanks!