2023-03-27 04:10:28

by Zhen Lei

Subject: [PATCH] kmsan: fix a stale comment in kmsan_save_stack_with_flags()

After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and
commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and
__alloc_pages_nodemask"), the comment is no longer accurate.
Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the
comment rather than update it.

Signed-off-by: Zhen Lei <[email protected]>
---
mm/kmsan/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/kmsan/core.c b/mm/kmsan/core.c
index f710257d68670ee..7d1e4aa30bae622 100644
--- a/mm/kmsan/core.c
+++ b/mm/kmsan/core.c
@@ -73,7 +73,7 @@ depot_stack_handle_t kmsan_save_stack_with_flags(gfp_t flags,

nr_entries = stack_trace_save(entries, KMSAN_STACK_DEPTH, 0);

- /* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */
+ /* Don't sleep. */
flags &= ~__GFP_DIRECT_RECLAIM;

handle = __stack_depot_save(entries, nr_entries, flags, true);
--
2.25.1

2023-03-27 11:07:29

by Alexander Potapenko

Subject: Re: [PATCH] kmsan: fix a stale comment in kmsan_save_stack_with_flags()

On Mon, Mar 27, 2023 at 5:45 AM Zhen Lei <[email protected]> wrote:
>
> After commit 446ec83805dd ("mm/page_alloc: use might_alloc()") and
> commit 84172f4bb752 ("mm/page_alloc: combine __alloc_pages and
> __alloc_pages_nodemask"), the comment is no longer accurate.
> Flag '__GFP_DIRECT_RECLAIM' is clear enough on its own, so remove the
> comment rather than update it.
>
> Signed-off-by: Zhen Lei <[email protected]>
Reviewed-by: Alexander Potapenko <[email protected]>

>
> nr_entries = stack_trace_save(entries, KMSAN_STACK_DEPTH, 0);
>
> - /* Don't sleep (see might_sleep_if() in __alloc_pages_nodemask()). */
> + /* Don't sleep. */

Thanks for spotting this!