2022-08-30 14:32:08

by CGEL

Subject: [PATCH linux-next] ARM: omap1: remove redundant variables err

From: Jinpeng Cui <[email protected]>

Rturn value directly from platform_device_register()
instead of getting value from redundant variable err.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Jinpeng Cui <[email protected]>
---
arch/arm/mach-omap1/board-ams-delta.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
index 651c28d81132..e5531ef0fbde 100644
--- a/arch/arm/mach-omap1/board-ams-delta.c
+++ b/arch/arm/mach-omap1/board-ams-delta.c
@@ -822,8 +822,6 @@ static int __init modem_nreset_init(void)
*/
static int __init ams_delta_modem_init(void)
{
- int err;
-
if (!machine_is_ams_delta())
return -ENODEV;

@@ -832,9 +830,7 @@ static int __init ams_delta_modem_init(void)
/* Initialize the modem_nreset regulator consumer before use */
modem_priv.regulator = ERR_PTR(-ENODEV);

- err = platform_device_register(&ams_delta_modem_device);
-
- return err;
+ return platform_device_register(&ams_delta_modem_device);
}
arch_initcall_sync(ams_delta_modem_init);

--
2.25.1

2022-09-05 21:12:00

by Janusz Krzysztofik

Subject: Re: [PATCH linux-next] ARM: omap1: remove redundant variables err

On Tuesday, 30 August 2022 16:21:36 CEST [email protected] wrote:
> From: Jinpeng Cui <[email protected]>
>
> Rturn value directly from platform_device_register()
> instead of getting value from redundant variable err.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Jinpeng Cui <[email protected]>

Acked-by: Janusz Krzysztofik <[email protected]>

Note: The same change, form a different author @zte.com.cn, with a different
wording in commit message and description, was submitted a few hours before
this one. However, I decided to respond with my Ack to this one because
the other one was not sent to [email protected], then it didn't
reach OMAP patchwork. If my decision is not in line with some
recommendations and I should rather prefer the submission sent earlier then
please let me know and I'll respond with my Ack to it as well.

Thanks,
Janusz


> ---
> arch/arm/mach-omap1/board-ams-delta.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/board-ams-delta.c b/arch/arm/mach-omap1/board-ams-delta.c
> index 651c28d81132..e5531ef0fbde 100644
> --- a/arch/arm/mach-omap1/board-ams-delta.c
> +++ b/arch/arm/mach-omap1/board-ams-delta.c
> @@ -822,8 +822,6 @@ static int __init modem_nreset_init(void)
> */
> static int __init ams_delta_modem_init(void)
> {
> - int err;
> -
> if (!machine_is_ams_delta())
> return -ENODEV;
>
> @@ -832,9 +830,7 @@ static int __init ams_delta_modem_init(void)
> /* Initialize the modem_nreset regulator consumer before use */
> modem_priv.regulator = ERR_PTR(-ENODEV);
>
> - err = platform_device_register(&ams_delta_modem_device);
> -
> - return err;
> + return platform_device_register(&ams_delta_modem_device);
> }
> arch_initcall_sync(ams_delta_modem_init);
>
>

2023-03-27 07:12:43

by Tony Lindgren

Subject: Re: [PATCH linux-next] ARM: omap1: remove redundant variables err

* [email protected] <[email protected]> [220830 17:14]:
> From: Jinpeng Cui <[email protected]>
>
> Rturn value directly from platform_device_register()
> instead of getting value from redundant variable err.

Sorry looks like this is still pending, applying into
omap-for-v6.4/omap1 thanks.

Tony