2023-03-10 14:56:41

by Rob Herring (Arm)

Subject: [PATCH] bus: ti-sysc: Use of_property_present() for testing DT property presence

It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <[email protected]>
---
drivers/bus/ti-sysc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index 6afae9897843..34d755797db4 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -964,7 +964,7 @@ static int sysc_map_and_check_registers(struct sysc *ddata)

sysc_check_children(ddata);

- if (!of_get_property(np, "reg", NULL))
+ if (!of_property_present(np, "reg"))
return 0;

error = sysc_parse_registers(ddata);
--
2.39.2

2023-03-27 07:34:14

by Tony Lindgren

Subject: Re: [PATCH] bus: ti-sysc: Use of_property_present() for testing DT property presence

* Rob Herring <[email protected]> [230310 16:48]:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties. As
> part of this, convert of_get_property/of_find_property calls to the
> recently added of_property_present() helper when we just want to test
> for presence of a property and nothing more.

Thanks applying into omap-for-v6.4/ti-sysc.

Tony