2022-08-27 09:51:52

by Yang Yingliang

Subject: [PATCH -next] bus: ti-sysc: Use list_for_each_entry() helper

Convert list_for_each() to list_for_each_entry() where applicable.

Signed-off-by: Yang Yingliang <[email protected]>
---
drivers/bus/ti-sysc.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index 51d772bb8046..8afa0245b31b 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -2526,11 +2526,9 @@ static struct dev_pm_domain sysc_child_pm_domain = {
static void sysc_reinit_modules(struct sysc_soc_info *soc)
{
struct sysc_module *module;
- struct list_head *pos;
struct sysc *ddata;

- list_for_each(pos, &sysc_soc->restored_modules) {
- module = list_entry(pos, struct sysc_module, node);
+ list_for_each_entry(module, &sysc_soc->restored_modules, node) {
ddata = module->ddata;
sysc_reinit_module(ddata, ddata->enabled);
}
@@ -3211,12 +3209,10 @@ static void sysc_cleanup_static_data(void)
static int sysc_check_disabled_devices(struct sysc *ddata)
{
struct sysc_address *disabled_module;
- struct list_head *pos;
int error = 0;

mutex_lock(&sysc_soc->list_lock);
- list_for_each(pos, &sysc_soc->disabled_modules) {
- disabled_module = list_entry(pos, struct sysc_address, node);
+ list_for_each_entry(disabled_module, &sysc_soc->disabled_modules, node) {
if (ddata->module_pa == disabled_module->base) {
dev_dbg(ddata->dev, "module disabled for this SoC\n");
error = -ENODEV;
--
2.25.1

2023-03-27 07:59:52

by Tony Lindgren

Subject: Re: [PATCH -next] bus: ti-sysc: Use list_for_each_entry() helper

* Yang Yingliang <[email protected]> [220827 12:31]:
> Convert list_for_each() to list_for_each_entry() where applicable.

Thanks applying into omap-for-v6.4/ti-sysc.

Tony