2023-03-27 09:59:40

by Peng Fan (OSS)

Subject: [PATCH] arm64: dts: imx8mm-evk: correct pmic clock source

From: Peng Fan <[email protected]>

The osc_32k supports #clock-cells as 0, using an id is wrong, drop it.

Fixes: a6a355ede574 ("arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC")
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
index d1a6390976a9..3f9dfd4d3884 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
@@ -194,7 +194,7 @@ pmic@4b {
rohm,reset-snvs-powered;

#clock-cells = <0>;
- clocks = <&osc_32k 0>;
+ clocks = <&osc_32k>;
clock-output-names = "clk-32k-out";

regulators {
--
2.37.1

2023-03-27 10:22:42

by Marco Felsch

Subject: Re: [PATCH] arm64: dts: imx8mm-evk: correct pmic clock source

On 23-03-27, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The osc_32k supports #clock-cells as 0, using an id is wrong, drop it.
>
> Fixes: a6a355ede574 ("arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC")
> Signed-off-by: Peng Fan <[email protected]>

Reviewed-by: Marco Felsch <[email protected]>

> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index d1a6390976a9..3f9dfd4d3884 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -194,7 +194,7 @@ pmic@4b {
> rohm,reset-snvs-powered;
>
> #clock-cells = <0>;
> - clocks = <&osc_32k 0>;
> + clocks = <&osc_32k>;
> clock-output-names = "clk-32k-out";
>
> regulators {
> --
> 2.37.1
>
>
>

2023-04-05 13:30:28

by Shawn Guo

Subject: Re: [PATCH] arm64: dts: imx8mm-evk: correct pmic clock source

On Mon, Mar 27, 2023 at 06:03:21PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> The osc_32k supports #clock-cells as 0, using an id is wrong, drop it.
>
> Fixes: a6a355ede574 ("arm64: dts: imx8mm-evk: Add 32.768 kHz clock to PMIC")
> Signed-off-by: Peng Fan <[email protected]>

Applied, thanks!