2023-03-29 22:38:37

by y86-dev

[permalink] [raw]
Subject: [PATCH v3 10/13] rust: prelude: add `pin-init` API items to prelude

From: Benno Lossin <[email protected]>

Add `pin-init` API macros and traits to the prelude.

Signed-off-by: Benno Lossin <[email protected]>
---
rust/kernel/prelude.rs | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
index 0bc1c97e5604..fcdc511d2ce8 100644
--- a/rust/kernel/prelude.rs
+++ b/rust/kernel/prelude.rs
@@ -18,7 +18,7 @@ pub use core::pin::Pin;
pub use alloc::{boxed::Box, vec::Vec};

#[doc(no_inline)]
-pub use macros::{module, vtable};
+pub use macros::{module, pin_data, pinned_drop, vtable};

pub use super::build_assert;

@@ -27,8 +27,12 @@ pub use super::build_assert;
pub use super::dbg;
pub use super::{pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};

+pub use super::{init, pin_init, try_init, try_pin_init};
+
pub use super::static_assert;

pub use super::error::{code::*, Error, Result};

pub use super::{str::CStr, ThisModule};
+
+pub use super::init::{InPlaceInit, Init, PinInit};
--
2.39.2



2023-03-30 11:13:21

by Gary Guo

[permalink] [raw]
Subject: Re: [PATCH v3 10/13] rust: prelude: add `pin-init` API items to prelude

On Wed, 29 Mar 2023 22:33:40 +0000
[email protected] wrote:

> From: Benno Lossin <[email protected]>
>
> Add `pin-init` API macros and traits to the prelude.
>
> Signed-off-by: Benno Lossin <[email protected]>

Reviewed-by: Gary Guo <[email protected]>

> ---
> rust/kernel/prelude.rs | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
> index 0bc1c97e5604..fcdc511d2ce8 100644
> --- a/rust/kernel/prelude.rs
> +++ b/rust/kernel/prelude.rs
> @@ -18,7 +18,7 @@ pub use core::pin::Pin;
> pub use alloc::{boxed::Box, vec::Vec};
>
> #[doc(no_inline)]
> -pub use macros::{module, vtable};
> +pub use macros::{module, pin_data, pinned_drop, vtable};
>
> pub use super::build_assert;
>
> @@ -27,8 +27,12 @@ pub use super::build_assert;
> pub use super::dbg;
> pub use super::{pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
>
> +pub use super::{init, pin_init, try_init, try_pin_init};
> +
> pub use super::static_assert;
>
> pub use super::error::{code::*, Error, Result};
>
> pub use super::{str::CStr, ThisModule};
> +
> +pub use super::init::{InPlaceInit, Init, PinInit};
> --
> 2.39.2
>
>

2023-03-31 07:04:41

by Alice Ryhl

[permalink] [raw]
Subject: Re: [PATCH v3 10/13] rust: prelude: add `pin-init` API items to prelude

On 3/30/23 00:33, [email protected] wrote:
> From: Benno Lossin <[email protected]>
>
> Add `pin-init` API macros and traits to the prelude.
>
> Signed-off-by: Benno Lossin <[email protected]>

Reviewed-by: Alice Ryhl <[email protected]>

2023-03-31 12:57:44

by Andreas Hindborg

[permalink] [raw]
Subject: Re: [PATCH v3 10/13] rust: prelude: add `pin-init` API items to prelude


[email protected] writes:

> From: Benno Lossin <[email protected]>
>
> Add `pin-init` API macros and traits to the prelude.
>
> Signed-off-by: Benno Lossin <[email protected]>
> ---

Reviewed-by: Andreas Hindborg <[email protected]>

> rust/kernel/prelude.rs | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
> index 0bc1c97e5604..fcdc511d2ce8 100644
> --- a/rust/kernel/prelude.rs
> +++ b/rust/kernel/prelude.rs
> @@ -18,7 +18,7 @@ pub use core::pin::Pin;
> pub use alloc::{boxed::Box, vec::Vec};
>
> #[doc(no_inline)]
> -pub use macros::{module, vtable};
> +pub use macros::{module, pin_data, pinned_drop, vtable};
>
> pub use super::build_assert;
>
> @@ -27,8 +27,12 @@ pub use super::build_assert;
> pub use super::dbg;
> pub use super::{pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, pr_notice, pr_warn};
>
> +pub use super::{init, pin_init, try_init, try_pin_init};
> +
> pub use super::static_assert;
>
> pub use super::error::{code::*, Error, Result};
>
> pub use super::{str::CStr, ThisModule};
> +
> +pub use super::init::{InPlaceInit, Init, PinInit};