On Thu, Mar 30, 2023 at 12:20:13AM -0700, Alexander Komrakov wrote:
> Some applications like Android needs elapsed realtime timestamping
> to PPS pulse for its clock management. Add sysfs node for this.
Where is the Android code that needs this? Have a pointer to it
anywhere?
>
> Signed-off-by: Alexander Komrakov <[email protected]>
> ---
> Documentation/ABI/testing/sysfs-pps | 27 +++++++++++++++++++++++
> Documentation/driver-api/pps.rst | 19 ++++++++++++++++
> drivers/pps/kapi.c | 24 +++++++++++++++++---
> drivers/pps/sysfs.c | 34 +++++++++++++++++++++++++++++
> include/linux/pps_kernel.h | 2 ++
> 5 files changed, 103 insertions(+), 3 deletions(-)
My bot will remind you that you dropped the version information off :(
> diff --git a/Documentation/ABI/testing/sysfs-pps b/Documentation/ABI/testing/sysfs-pps
> index 25028c7bc37d..031ec89e1ed6 100644
> --- a/Documentation/ABI/testing/sysfs-pps
> +++ b/Documentation/ABI/testing/sysfs-pps
> @@ -1,3 +1,30 @@
> +What: /sys/class/pps/pps0/assert_elapsed
That should be "ppsX" right?
> +Date: October 2021
> +Contact: Alexander Komrakov <[email protected]>
> +Description:
> + The /sys/class/pps/ppsX/assert_elapsed file reports the
> + elapsed real-time assert events and the elapsed
> + real-time assert sequence number of the X-th source
> + in the form:
> +
> + <secs>.<nsec>#<sequence>
> +
> + If the source has no elapsed real-time assert events
> + the content of this file is empty.
> +
> +What: /sys/class/pps/ppsX/clear_elapsed
> +Date: October 2021
> +Contact: Alexander Komrakov <[email protected]>
> +Description:
> + The /sys/class/pps/ppsX/clear_elapsed file reports the elapsed
> + real-time clear events and the elapsed real-time clear
> + sequence number of the X-th source in the form:
> +
> + <secs>.<nsec>#<sequence>
> +
> + If the source has no elapsed real-time clear events the
> + content of this file is empty.
> +
> What: /sys/class/pps/
Why are your new entries above the main pps entry? Shouldn't they be
below it?
thanks,
greg k-h
On Thu, Mar 30, 2023 at 12:20:13AM -0700, Alexander Komrakov wrote:
> Some applications like Android needs elapsed realtime timestamping
> to PPS pulse for its clock management. Add sysfs node for this.
>
> Signed-off-by: Alexander Komrakov <[email protected]>
> ---
> Documentation/ABI/testing/sysfs-pps | 27 +++++++++++++++++++++++
> Documentation/driver-api/pps.rst | 19 ++++++++++++++++
> drivers/pps/kapi.c | 24 +++++++++++++++++---
> drivers/pps/sysfs.c | 34 +++++++++++++++++++++++++++++
> include/linux/pps_kernel.h | 2 ++
> 5 files changed, 103 insertions(+), 3 deletions(-)
>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- This looks like a new version of a previously submitted patch, but you
did not list below the --- line any changes from the previous version.
Please read the section entitled "The canonical patch format" in the
kernel file, Documentation/process/submitting-patches.rst for what
needs to be done here to properly describe this.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
greg k-h> Where is the Android code that needs this? Have a pointer
to it anywhere?
[AK] https://cs.android.com/android/platform/superproject/+/master:cts/tests/location/location_gnss/src/android/location/cts/gnss/GnssLocationUpdateIntervalTest.java;drc=4788a776bc579841b0093c8f29215a1ce0686403;l=218]
that requires 100ms accuracy. But you may challenge that 100ms
accuracy wouldn't require PPS.
greg k-h> My bot will remind you that you dropped the version information off :(
[AK] Done in [PATCH v6]:
greg k-h> That should be "ppsX" right?
[AK]Done in [PATCH v6]:
greg k-h> Why are your new entries above the main pps entry?
Shouldn't they be below it?
[AK] Done in [PATCH v6]:
>>
>> >
>> > Signed-off-by: Alexander Komrakov <[email protected]>
>> > ---
>> > Documentation/ABI/testing/sysfs-pps | 27 +++++++++++++++++++++++
>> > Documentation/driver-api/pps.rst | 19 ++++++++++++++++
>> > drivers/pps/kapi.c | 24 +++++++++++++++++---
>> > drivers/pps/sysfs.c | 34 +++++++++++++++++++++++++++++
>> > include/linux/pps_kernel.h | 2 ++
>> > 5 files changed, 103 insertions(+), 3 deletions(-)
>>
>> My bot will remind you that you dropped the version information off :(
>>
>> > diff --git a/Documentation/ABI/testing/sysfs-pps b/Documentation/ABI/testing/sysfs-pps
>> > index 25028c7bc37d..031ec89e1ed6 100644
>> > --- a/Documentation/ABI/testing/sysfs-pps
>> > +++ b/Documentation/ABI/testing/sysfs-pps
>> > @@ -1,3 +1,30 @@
>> > +What: /sys/class/pps/pps0/assert_elapsed
>>
>> That should be "ppsX" right?
>>
>> > +Date: October 2021
>> > +Contact: Alexander Komrakov <[email protected]>
>> > +Description:
>> > + The /sys/class/pps/ppsX/assert_elapsed file reports the
>> > + elapsed real-time assert events and the elapsed
>> > + real-time assert sequence number of the X-th source
>> > + in the form:
>> > +
>> > + <secs>.<nsec>#<sequence>
>> > +
>> > + If the source has no elapsed real-time assert events
>> > + the content of this file is empty.
>> > +
>> > +What: /sys/class/pps/ppsX/clear_elapsed
>> > +Date: October 2021
>> > +Contact: Alexander Komrakov <[email protected]>
>> > +Description:
>> > + The /sys/class/pps/ppsX/clear_elapsed file reports the elapsed
>> > + real-time clear events and the elapsed real-time clear
>> > + sequence number of the X-th source in the form:
>> > +
>> > + <secs>.<nsec>#<sequence>
>> > +
>> > + If the source has no elapsed real-time clear events the
>> > + content of this file is empty.
>> > +
>> > What: /sys/class/pps/
>>
>> Why are your new entries above the main pps entry? Shouldn't they be
>> below it?
>>
>> thanks,
>>
>> greg k-h