2023-03-30 10:35:40

by Zhang, Rui

Subject: [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message

After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic
tjmax"), tjmax value is retrieved from MSR every time the temperature is
read.
This means that, with debug message enabled, the tjmax debug message is
printed out for every single temperature read for any CPU. This spams
the syslog.

Ideally, as tjmax is package scope unique, the debug message should show
once when tjmax is changed for one package. But this requires inventing
some new per-package data in the coretemp driver, and this is overkill.

To keep the code simple, delete the tjmax debug message.

Signed-off-by: Zhang Rui <[email protected]>
---
drivers/hwmon/coretemp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 30d77f451937..fe3d4d0dcbed 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
* If the TjMax is not plausible, an assumption
* will be used
*/
- if (val) {
- dev_dbg(dev, "TjMax is %d degrees C\n", val);
+ if (val)
return val * 1000;
- }
}

if (force_tjmax) {
--
2.25.1

2023-03-30 10:35:56

by Zhang, Rui

Subject: [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment

The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET
has been changed for several times.

Now, the raw value from MSR is used without refinement. Thus remove the
obsolete comment.

Signed-off-by: Zhang Rui <[email protected]>
---
drivers/hwmon/coretemp.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index fe3d4d0dcbed..eba94f68585a 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
dev_warn(dev, "Unable to read TjMax from CPU %u\n", tdata->cpu);
} else {
val = (eax >> 16) & 0xff;
- /*
- * If the TjMax is not plausible, an assumption
- * will be used
- */
if (val)
return val * 1000;
}
--
2.25.1

2023-04-07 16:01:24

by Guenter Roeck

Subject: Re: [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message

On Thu, Mar 30, 2023 at 06:33:45PM +0800, Zhang Rui wrote:
> After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic
> tjmax"), tjmax value is retrieved from MSR every time the temperature is
> read.
> This means that, with debug message enabled, the tjmax debug message is
> printed out for every single temperature read for any CPU. This spams
> the syslog.
>
> Ideally, as tjmax is package scope unique, the debug message should show
> once when tjmax is changed for one package. But this requires inventing
> some new per-package data in the coretemp driver, and this is overkill.
>
> To keep the code simple, delete the tjmax debug message.
>
> Signed-off-by: Zhang Rui <[email protected]>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/coretemp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index 30d77f451937..fe3d4d0dcbed 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
> * If the TjMax is not plausible, an assumption
> * will be used
> */
> - if (val) {
> - dev_dbg(dev, "TjMax is %d degrees C\n", val);
> + if (val)
> return val * 1000;
> - }
> }
>
> if (force_tjmax) {

2023-04-07 16:02:10

by Guenter Roeck

Subject: Re: [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment

On Thu, Mar 30, 2023 at 06:33:46PM +0800, Zhang Rui wrote:
> The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET
> has been changed for several times.
>
> Now, the raw value from MSR is used without refinement. Thus remove the
> obsolete comment.
>
> Signed-off-by: Zhang Rui <[email protected]>

Applied.

Thanks,
Guenter

> ---
> drivers/hwmon/coretemp.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index fe3d4d0dcbed..eba94f68585a 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev)
> dev_warn(dev, "Unable to read TjMax from CPU %u\n", tdata->cpu);
> } else {
> val = (eax >> 16) & 0xff;
> - /*
> - * If the TjMax is not plausible, an assumption
> - * will be used
> - */
> if (val)
> return val * 1000;
> }