2023-03-31 12:11:53

by Tom Rix

Subject: [PATCH] reiserfs: remove unused iter variable

clang with W=1 reports
fs/reiserfs/stree.c:1265:6: error: variable
'iter' set but not used [-Werror,-Wunused-but-set-variable]
int iter = 0;
^
This variable is not used so remove it.

Signed-off-by: Tom Rix <[email protected]>
---
fs/reiserfs/stree.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
index 84c12a1947b2..ce5003986789 100644
--- a/fs/reiserfs/stree.c
+++ b/fs/reiserfs/stree.c
@@ -1262,7 +1262,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,

#ifdef CONFIG_REISERFS_CHECK
char mode;
- int iter = 0;
#endif

BUG_ON(!th->t_trans_id);
@@ -1274,7 +1273,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
removed = 0;

#ifdef CONFIG_REISERFS_CHECK
- iter++;
mode =
#endif
prepare_for_delete_or_cut(th, inode, path,
--
2.27.0

2023-03-31 12:23:36

by Jan Kara

Subject: Re: [PATCH] reiserfs: remove unused iter variable

On Fri 31-03-23 08:03:25, Tom Rix wrote:
> clang with W=1 reports
> fs/reiserfs/stree.c:1265:6: error: variable
> 'iter' set but not used [-Werror,-Wunused-but-set-variable]
> int iter = 0;
> ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <[email protected]>

Thanks. I've merged the patch to my tree.

Honza

> ---
> fs/reiserfs/stree.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/reiserfs/stree.c b/fs/reiserfs/stree.c
> index 84c12a1947b2..ce5003986789 100644
> --- a/fs/reiserfs/stree.c
> +++ b/fs/reiserfs/stree.c
> @@ -1262,7 +1262,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
>
> #ifdef CONFIG_REISERFS_CHECK
> char mode;
> - int iter = 0;
> #endif
>
> BUG_ON(!th->t_trans_id);
> @@ -1274,7 +1273,6 @@ int reiserfs_delete_item(struct reiserfs_transaction_handle *th,
> removed = 0;
>
> #ifdef CONFIG_REISERFS_CHECK
> - iter++;
> mode =
> #endif
> prepare_for_delete_or_cut(th, inode, path,
> --
> 2.27.0
>
--
Jan Kara <[email protected]>
SUSE Labs, CR