2023-03-20 18:29:26

by 李扬韬

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: mark ecryptfs as orphan state

ecryptfs has been inactive for a long time, and in fact the filesystem
has no active maintainers. I sent a patch last August, no response
till now. Let's mark it as Orphan status.

Maybe in 2025 we can remove this unmaintained file system?

Cc: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Yangtao Li <[email protected]>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 541e7dc05f48..4a6236d5a6ce 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7270,7 +7270,7 @@ F: drivers/media/dvb-frontends/ec100*
ECRYPT FILE SYSTEM
M: Tyler Hicks <[email protected]>
L: [email protected]
-S: Odd Fixes
+S: Orphan
W: http://ecryptfs.org
W: https://launchpad.net/ecryptfs
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git
--
2.35.1



2023-03-21 06:36:27

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: mark ecryptfs as orphan state

On Tue, Mar 21, 2023 at 02:21:03AM +0800, Yangtao Li wrote:
> ecryptfs has been inactive for a long time, and in fact the filesystem
> has no active maintainers. I sent a patch last August, no response
> till now. Let's mark it as Orphan status.
>
> Maybe in 2025 we can remove this unmaintained file system?
>
> Cc: Greg Kroah-Hartman <[email protected]>

Why send this to me?

> Signed-off-by: Yangtao Li <[email protected]>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 541e7dc05f48..4a6236d5a6ce 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7270,7 +7270,7 @@ F: drivers/media/dvb-frontends/ec100*
> ECRYPT FILE SYSTEM
> M: Tyler Hicks <[email protected]>
> L: [email protected]
> -S: Odd Fixes
> +S: Orphan

Why not also cc: the two email addresses here? And if this is really
orphaned, then remove them as well, right?

> W: http://ecryptfs.org
> W: https://launchpad.net/ecryptfs
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/tyhicks/ecryptfs.git

These all too need to go if this really is orphaned code. But first,
try sending it to the right people (like the linux-fs mailing list as
well?)

thanks,

greg k-h

2023-03-24 23:03:36

by Tyler Hicks

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: mark ecryptfs as orphan state

On 2023-03-23 01:19:10, Yangtao Li wrote:
> +cc [email protected], [email protected], [email protected]

Hey Yangtao - I think it is a good idea to deprecate eCryptfs and
prepare for its removal in a couple years.

It never received the dedication needed to sort out the stacked
filesystem design issues and its crypto design is aging without
updates/improvements for some time. The majority of the user base, which
came about when Ubuntu added home dir encryption as an option in the
installer, has greatly decreased since Ubuntu removed it from the
installer and dropped official support several years back. Finally,
fscrypt should provide a more than complete alternative for the majority
of use cases.

Deprecating and removing is the right thing to do.

I can devote some time to limping it by until removal but would also
appreciate a hand if anyone has time/interest.

Tyler

>
> Thx,
> Yangtao

2023-04-03 12:48:48

by Christian Brauner

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: mark ecryptfs as orphan state

On Fri, Mar 24, 2023 at 05:42:43PM -0500, Tyler Hicks wrote:
> On 2023-03-23 01:19:10, Yangtao Li wrote:
> > +cc [email protected], [email protected], [email protected]
>
> Hey Yangtao - I think it is a good idea to deprecate eCryptfs and
> prepare for its removal in a couple years.
>
> It never received the dedication needed to sort out the stacked
> filesystem design issues and its crypto design is aging without
> updates/improvements for some time. The majority of the user base, which
> came about when Ubuntu added home dir encryption as an option in the
> installer, has greatly decreased since Ubuntu removed it from the
> installer and dropped official support several years back. Finally,
> fscrypt should provide a more than complete alternative for the majority
> of use cases.
>
> Deprecating and removing is the right thing to do.
>
> I can devote some time to limping it by until removal but would also
> appreciate a hand if anyone has time/interest.

Hey Tyler,

Do you want to send a patch to deprecate it with your SOB?

Christian

2023-04-03 13:50:02

by 李扬韬

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: mark ecryptfs as orphan state

> I can devote some time to limping it by until removal but would also
> appreciate a hand if anyone has time/interest.

I have time and interest, if possible, I would like to be a reviewer
before ecryptfs is removed.

Thx,
Yangtao

2023-04-04 03:09:00

by Tyler Hicks

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: mark ecryptfs as orphan state

On 2023-04-03 21:44:32, Yangtao Li wrote:
> > I can devote some time to limping it by until removal but would also
> > appreciate a hand if anyone has time/interest.
>
> I have time and interest, if possible, I would like to be a reviewer
> before ecryptfs is removed.

Hi - I don't think an additional reviewer is going to be sufficient to
get eCryptfs into a good state long term. There are fairly large design
problems that need more attention. I'll send a patch to deprecate and
mark for removal in 2025.

I'll happily add you as a reviewer and appreciate your interest in
helping.

Tyler