2023-04-04 01:08:55

by Tom Rix

Subject: [PATCH] KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static

smatch reports
arch/x86/kvm/x86.c:199:20: warning: symbol
'mitigate_smt_rsb' was not declared. Should it be static?

This variable is only used in one file so it should be static.

Signed-off-by: Tom Rix <[email protected]>
---
arch/x86/kvm/x86.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 8bb8f226f51f..4ce3411d35f3 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -196,7 +196,7 @@ bool __read_mostly eager_page_split = true;
module_param(eager_page_split, bool, 0644);

/* Enable/disable SMT_RSB bug mitigation */
-bool __read_mostly mitigate_smt_rsb;
+static bool __read_mostly mitigate_smt_rsb;
module_param(mitigate_smt_rsb, bool, 0444);

/*
--
2.27.0

2023-04-06 00:02:02

by Sean Christopherson

Subject: Re: [PATCH] KVM: x86: set varaiable mitigate_smt_rsb storage-class-specifier to static

"varaiable" in the shortlog is mispelled, I just dropped it and wrapped the
variable name itself in quotes.

On Mon, 03 Apr 2023 21:01:41 -0400, Tom Rix wrote:
> smatch reports
> arch/x86/kvm/x86.c:199:20: warning: symbol
> 'mitigate_smt_rsb' was not declared. Should it be static?
>
> This variable is only used in one file so it should be static.
>
>
> [...]

Applied to kvm-x86 misc, thanks!

[1/1] KVM: x86: set "mitigate_smt_rsb" storage-class-specifier to static
https://github.com/kvm-x86/linux/commit/944a8dad8b4e

--
https://github.com/kvm-x86/linux/tree/next
https://github.com/kvm-x86/linux/tree/fixes