2023-04-04 17:58:09

by Shreeya Patel

Subject: [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B

Add DT node to enable RTC support for Rock 5B board.

Signed-off-by: Shreeya Patel <[email protected]>
Reviewed-by: Christopher Obbard <[email protected]>
---
.../boot/dts/rockchip/rk3588-rock-5b.dts | 25 +++++++++++++++++++
1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 95805cb0adfa..fcb5af09e49b 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
};
};

+&i2c6 {
+ status = "okay";
+
+ hym8563: hym8563@51 {
+ compatible = "haoyu,hym8563";
+ reg = <0x51>;
+ #clock-cells = <0>;
+ clock-frequency = <32768>;
+ clock-output-names = "hym8563";
+ pinctrl-names = "default";
+ pinctrl-0 = <&hym8563_int>;
+ interrupt-parent = <&gpio0>;
+ interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>;
+ wakeup-source;
+ };
+};
+
+&pinctrl {
+ hym8563 {
+ hym8563_int: hym8563-int {
+ rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
+};
+
&sdhci {
bus-width = <8>;
no-sdio;
--
2.30.2

2023-04-04 19:06:25

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] arm64: dts: rockchip: Enable RTC support for Rock 5B

On 04/04/2023 19:41, Shreeya Patel wrote:
> Add DT node to enable RTC support for Rock 5B board.
>
> Signed-off-by: Shreeya Patel <[email protected]>
> Reviewed-by: Christopher Obbard <[email protected]>
> ---
> .../boot/dts/rockchip/rk3588-rock-5b.dts | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> index 95805cb0adfa..fcb5af09e49b 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
> @@ -27,6 +27,31 @@ vcc5v0_sys: vcc5v0-sys-regulator {
> };
> };
>
> +&i2c6 {
> + status = "okay";
> +
> + hym8563: hym8563@51 {

Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Best regards,
Krzysztof