2023-04-04 22:00:05

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the cxl tree

---

Hi all,

In commit

570739ce619a ("cxl/hdm: Avoid NULL deref when component registers are missing")

Fixes tag

Fixes: 757f6448b100 ("cxl/hdm: Fix double allocation of @cxlhdm")

has these problem(s):

- Target SHA1 does not exist

Maybe you meant

Fixes: 518dd2bfb981 ("cxl/hdm: Fix double allocation of @cxlhdm")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2023-04-04 23:03:29

by Dan Williams

[permalink] [raw]

Subject: RE: linux-next: Fixes tag needs some work in the cxl tree

---

Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 570739ce619a ("cxl/hdm: Avoid NULL deref when component registers are missing")
>
> Fixes tag
>
> Fixes: 757f6448b100 ("cxl/hdm: Fix double allocation of @cxlhdm")
>
> has these problem(s):
>
> - Target SHA1 does not exist
>
> Maybe you meant
>
> Fixes: 518dd2bfb981 ("cxl/hdm: Fix double allocation of @cxlhdm")

Thanks for the heads up. What happened is that "cxl/hdm: Fix double
allocation of @cxlhdm" was an old fix that had been sitting in my queue
for while and I discovered the bug in that much later. Treated the
commit as upstream when it wasn't.

I went ahead and squashed the follow on fix to clean up the upstream
history.