2023-04-06 01:11:33

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] clk: mvebu: Use of_address_to_resource()

Replace of_get_property() and of_translate_address() calls with a single
call to of_address_to_resource().

Signed-off-by: Rob Herring <[email protected]>
---
One more to add to the prior series[1]. Though there is no dependency
and this isn't for cpu nodes.

[1] https://lore.kernel.org/all/[email protected]/

drivers/clk/mvebu/armada_ap_cp_helper.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/clk/mvebu/armada_ap_cp_helper.c b/drivers/clk/mvebu/armada_ap_cp_helper.c
index 6a930f697ee5..e7005de66327 100644
--- a/drivers/clk/mvebu/armada_ap_cp_helper.c
+++ b/drivers/clk/mvebu/armada_ap_cp_helper.c
@@ -16,15 +16,13 @@
char *ap_cp_unique_name(struct device *dev, struct device_node *np,
const char *name)
{
- const __be32 *reg;
- u64 addr;
+ struct resource res;

/* Do not create a name if there is no clock */
if (!name)
return NULL;

- reg = of_get_property(np, "reg", NULL);
- addr = of_translate_address(np, reg);
+ of_address_to_resource(np, 0, &res);
return devm_kasprintf(dev, GFP_KERNEL, "%llx-%s",
- (unsigned long long)addr, name);
+ (unsigned long long)res.start, name);
}
--
2.39.2


2023-06-15 01:43:03

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: mvebu: Use of_address_to_resource()

Quoting Rob Herring (2023-04-05 18:07:38)
> Replace of_get_property() and of_translate_address() calls with a single
> call to of_address_to_resource().
>
> Signed-off-by: Rob Herring <[email protected]>
> ---

Applied to clk-next