2023-04-06 15:08:15

by Nikita Travkin

Subject: [PATCH v4 1/4] arm64: dts: qcom: sc7180: Don't enable lpass clocks by default

lpass clocks are usually blocked from HLOS by the firmware and
instead are managed by the ADSP. Mark them as reserved and explicitly
enable in the CrOS boards that have special, cooperative firmware.

Signed-off-by: Nikita Travkin <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++
2 files changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
index 423630c4d02c..26def6e12723 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
@@ -785,6 +785,14 @@ alc5682: codec@1a {
};
};

+&lpasscc {
+ status = "okay";
+};
+
+&lpass_hm {
+ status = "okay";
+};
+
&lpass_cpu {
status = "okay";

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 3c799b564b64..6f40301faa1c 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 {
power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
#clock-cells = <1>;
#power-domain-cells = <1>;
+
+ status = "reserved"; /* Controlled by ADSP */
};

lpass_cpu: lpass@62d87000 {
@@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 {

#clock-cells = <1>;
#power-domain-cells = <1>;
+
+ status = "reserved"; /* Controlled by ADSP */
};
};

--
2.39.2

2023-04-06 19:32:19

by Konrad Dybcio

Subject: Re: [PATCH v4 1/4] arm64: dts: qcom: sc7180: Don't enable lpass clocks by default

On 6.04.2023 17:06, Nikita Travkin wrote:
> lpass clocks are usually blocked from HLOS by the firmware and
> instead are managed by the ADSP. Mark them as reserved and explicitly
> enable in the CrOS boards that have special, cooperative firmware.
>
> Signed-off-by: Nikita Travkin <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 423630c4d02c..26def6e12723 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -785,6 +785,14 @@ alc5682: codec@1a {
> };
> };
>
> +&lpasscc {
> + status = "okay";
> +};
> +
> +&lpass_hm {
> + status = "okay";
> +};
> +
> &lpass_cpu {
> status = "okay";
>
_hm should come after _cpu alphabetically

w/ that

Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 3c799b564b64..6f40301faa1c 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 {
> power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
> #clock-cells = <1>;
> #power-domain-cells = <1>;
> +
> + status = "reserved"; /* Controlled by ADSP */
> };
>
> lpass_cpu: lpass@62d87000 {
> @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 {
>
> #clock-cells = <1>;
> #power-domain-cells = <1>;
> +
> + status = "reserved"; /* Controlled by ADSP */
> };
> };
>

2023-04-07 04:39:14

by Nikita Travkin

Subject: Re: [PATCH v4 1/4] arm64: dts: qcom: sc7180: Don't enable lpass clocks by default

Konrad Dybcio писал(а) 07.04.2023 00:31:
> On 6.04.2023 17:06, Nikita Travkin wrote:
>> lpass clocks are usually blocked from HLOS by the firmware and
>> instead are managed by the ADSP. Mark them as reserved and explicitly
>> enable in the CrOS boards that have special, cooperative firmware.
>>
>> Signed-off-by: Nikita Travkin <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 8 ++++++++
>> arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++++
>> 2 files changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> index 423630c4d02c..26def6e12723 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
>> @@ -785,6 +785,14 @@ alc5682: codec@1a {
>> };
>> };
>>
>> +&lpasscc {
>> + status = "okay";
>> +};
>> +
>> +&lpass_hm {
>> + status = "okay";
>> +};
>> +
>> &lpass_cpu {
>> status = "okay";
>>
> _hm should come after _cpu alphabetically
>

Oops, will fix, thanks!

> w/ that
>
> Reviewed-by: Konrad Dybcio <[email protected]>
>
> Konrad
>> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> index 3c799b564b64..6f40301faa1c 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
>> @@ -3621,6 +3621,8 @@ lpasscc: clock-controller@62d00000 {
>> power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
>> #clock-cells = <1>;
>> #power-domain-cells = <1>;
>> +
>> + status = "reserved"; /* Controlled by ADSP */
>> };
>>
>> lpass_cpu: lpass@62d87000 {
>> @@ -3669,6 +3671,8 @@ lpass_hm: clock-controller@63000000 {
>>
>> #clock-cells = <1>;
>> #power-domain-cells = <1>;
>> +
>> + status = "reserved"; /* Controlled by ADSP */
>> };
>> };
>>