2023-04-06 12:49:34

by kernel test robot

[permalink] [raw]
Subject: drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting

Hi Huacai,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 99ddf2254febae9eab7fb0bcc02c5322243f5c49
commit: 57fc7323a8e7c2e7c1d5795ab63cb3ffea3cfdfb LoongArch: Add PCI controller support
date: 8 months ago
config: loongarch-randconfig-m041-20230406 (https://download.01.org/0day-ci/archive/20230406/[email protected]/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <[email protected]>
| Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/

smatch warnings:
drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting
drivers/ata/ata_piix.c:1382 piix_init_sata_map() error: buffer overflow 'map' 4 <= 4

vim +443 drivers/ata/pata_serverworks.c

669a5db411d85a Jeff Garzik 2006-08-29 385
669a5db411d85a Jeff Garzik 2006-08-29 386 static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
669a5db411d85a Jeff Garzik 2006-08-29 387 {
1626aeb881236c Tejun Heo 2007-05-04 388 static const struct ata_port_info info[4] = {
669a5db411d85a Jeff Garzik 2006-08-29 389 { /* OSB4 */
1d2808fd3d2d5d Jeff Garzik 2007-05-28 390 .flags = ATA_FLAG_SLAVE_POSS,
14bdef982caeda Erik Inge Bols? 2009-03-14 391 .pio_mask = ATA_PIO4,
14bdef982caeda Erik Inge Bols? 2009-03-14 392 .mwdma_mask = ATA_MWDMA2,
14bdef982caeda Erik Inge Bols? 2009-03-14 393 .udma_mask = ATA_UDMA2,
669a5db411d85a Jeff Garzik 2006-08-29 394 .port_ops = &serverworks_osb4_port_ops
669a5db411d85a Jeff Garzik 2006-08-29 395 }, { /* OSB4 no UDMA */
1d2808fd3d2d5d Jeff Garzik 2007-05-28 396 .flags = ATA_FLAG_SLAVE_POSS,
14bdef982caeda Erik Inge Bols? 2009-03-14 397 .pio_mask = ATA_PIO4,
14bdef982caeda Erik Inge Bols? 2009-03-14 398 .mwdma_mask = ATA_MWDMA2,
14bdef982caeda Erik Inge Bols? 2009-03-14 399 /* No UDMA */
669a5db411d85a Jeff Garzik 2006-08-29 400 .port_ops = &serverworks_osb4_port_ops
669a5db411d85a Jeff Garzik 2006-08-29 401 }, { /* CSB5 */
1d2808fd3d2d5d Jeff Garzik 2007-05-28 402 .flags = ATA_FLAG_SLAVE_POSS,
14bdef982caeda Erik Inge Bols? 2009-03-14 403 .pio_mask = ATA_PIO4,
14bdef982caeda Erik Inge Bols? 2009-03-14 404 .mwdma_mask = ATA_MWDMA2,
bf6263a853c9c1 Jeff Garzik 2007-07-09 405 .udma_mask = ATA_UDMA4,
669a5db411d85a Jeff Garzik 2006-08-29 406 .port_ops = &serverworks_csb_port_ops
669a5db411d85a Jeff Garzik 2006-08-29 407 }, { /* CSB5 - later revisions*/
1d2808fd3d2d5d Jeff Garzik 2007-05-28 408 .flags = ATA_FLAG_SLAVE_POSS,
14bdef982caeda Erik Inge Bols? 2009-03-14 409 .pio_mask = ATA_PIO4,
14bdef982caeda Erik Inge Bols? 2009-03-14 410 .mwdma_mask = ATA_MWDMA2,
bf6263a853c9c1 Jeff Garzik 2007-07-09 411 .udma_mask = ATA_UDMA5,
669a5db411d85a Jeff Garzik 2006-08-29 412 .port_ops = &serverworks_csb_port_ops
669a5db411d85a Jeff Garzik 2006-08-29 413 }
669a5db411d85a Jeff Garzik 2006-08-29 414 };
1626aeb881236c Tejun Heo 2007-05-04 415 const struct ata_port_info *ppi[] = { &info[id->driver_data], NULL };
37017ac6849e77 Scott Carter 2014-09-24 416 struct scsi_host_template *sht = &serverworks_csb_sht;
f08048e94564d0 Tejun Heo 2008-03-25 417 int rc;
f08048e94564d0 Tejun Heo 2008-03-25 418
f08048e94564d0 Tejun Heo 2008-03-25 419 rc = pcim_enable_device(pdev);
f08048e94564d0 Tejun Heo 2008-03-25 420 if (rc)
f08048e94564d0 Tejun Heo 2008-03-25 421 return rc;
669a5db411d85a Jeff Garzik 2006-08-29 422
d912be2f3b3353 Bartlomiej Zolnierkiewicz 2011-10-11 423 rc = serverworks_fixup(pdev);
669a5db411d85a Jeff Garzik 2006-08-29 424
669a5db411d85a Jeff Garzik 2006-08-29 425 /* OSB4 : South Bridge and IDE */
669a5db411d85a Jeff Garzik 2006-08-29 426 if (pdev->device == PCI_DEVICE_ID_SERVERWORKS_OSB4IDE) {
669a5db411d85a Jeff Garzik 2006-08-29 427 /* Select non UDMA capable OSB4 if we can't do fixups */
d912be2f3b3353 Bartlomiej Zolnierkiewicz 2011-10-11 428 if (rc < 0)
1626aeb881236c Tejun Heo 2007-05-04 429 ppi[0] = &info[1];
37017ac6849e77 Scott Carter 2014-09-24 430 sht = &serverworks_osb4_sht;
669a5db411d85a Jeff Garzik 2006-08-29 431 }
669a5db411d85a Jeff Garzik 2006-08-29 432 /* setup CSB5/CSB6 : South Bridge and IDE option RAID */
669a5db411d85a Jeff Garzik 2006-08-29 433 else if ((pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB5IDE) ||
669a5db411d85a Jeff Garzik 2006-08-29 434 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
669a5db411d85a Jeff Garzik 2006-08-29 435 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
669a5db411d85a Jeff Garzik 2006-08-29 436
669a5db411d85a Jeff Garzik 2006-08-29 437 /* If the returned btr is the newer revision then
669a5db411d85a Jeff Garzik 2006-08-29 438 select the right info block */
d912be2f3b3353 Bartlomiej Zolnierkiewicz 2011-10-11 439 if (rc == 3)
1626aeb881236c Tejun Heo 2007-05-04 440 ppi[0] = &info[3];
669a5db411d85a Jeff Garzik 2006-08-29 441
669a5db411d85a Jeff Garzik 2006-08-29 442 /* Is this the 3rd channel CSB6 IDE ? */
669a5db411d85a Jeff Garzik 2006-08-29 @443 if (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)
1626aeb881236c Tejun Heo 2007-05-04 444 ppi[1] = &ata_dummy_port_info;
669a5db411d85a Jeff Garzik 2006-08-29 445 }
669a5db411d85a Jeff Garzik 2006-08-29 446
37017ac6849e77 Scott Carter 2014-09-24 447 return ata_pci_bmdma_init_one(pdev, ppi, sht, NULL, 0);
669a5db411d85a Jeff Garzik 2006-08-29 448 }
669a5db411d85a Jeff Garzik 2006-08-29 449

:::::: The code at line 443 was first introduced by commit
:::::: 669a5db411d85a14f86cd92bc16bf7ab5b8aa235 [libata] Add a bunch of PATA drivers.

:::::: TO: Jeff Garzik <[email protected]>
:::::: CC: Jeff Garzik <[email protected]>

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests


2023-04-07 09:49:52

by Huacai Chen

[permalink] [raw]
Subject: Re: drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting




> -----原始邮件-----
> 发件人: "kernel test robot" <[email protected]>
> 发送时间:2023-04-06 20:41:54 (星期四)
> 收件人: "Huacai Chen" <[email protected]>
> 抄送: [email protected], [email protected], "WANG Xuerui" <[email protected]>, "Jianmin Lv" <[email protected]>
> 主题: drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting
>
> Hi Huacai,
>
> First bad commit (maybe != root cause):
Emm, this seems not the root cause, just because that commit enable the build of these files.

Huacai

>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 99ddf2254febae9eab7fb0bcc02c5322243f5c49
> commit: 57fc7323a8e7c2e7c1d5795ab63cb3ffea3cfdfb LoongArch: Add PCI controller support
> date: 8 months ago
> config: loongarch-randconfig-m041-20230406 (https://download.01.org/0day-ci/archive/20230406/[email protected]/config)
> compiler: loongarch64-linux-gcc (GCC) 12.1.0
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <[email protected]>
> | Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
>
> smatch warnings:
> drivers/ata/pata_serverworks.c:443 serverworks_init_one() warn: inconsistent indenting
> drivers/ata/ata_piix.c:1382 piix_init_sata_map() error: buffer overflow 'map' 4 <= 4
>
> vim +443 drivers/ata/pata_serverworks.c
>
> 669a5db411d85a Jeff Garzik 2006-08-29 385
> 669a5db411d85a Jeff Garzik 2006-08-29 386 static int serverworks_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
> 669a5db411d85a Jeff Garzik 2006-08-29 387 {
> 1626aeb881236c Tejun Heo 2007-05-04 388 static const struct ata_port_info info[4] = {
> 669a5db411d85a Jeff Garzik 2006-08-29 389 { /* OSB4 */
> 1d2808fd3d2d5d Jeff Garzik 2007-05-28 390 .flags = ATA_FLAG_SLAVE_POSS,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 391 .pio_mask = ATA_PIO4,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 392 .mwdma_mask = ATA_MWDMA2,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 393 .udma_mask = ATA_UDMA2,
> 669a5db411d85a Jeff Garzik 2006-08-29 394 .port_ops = &serverworks_osb4_port_ops
> 669a5db411d85a Jeff Garzik 2006-08-29 395 }, { /* OSB4 no UDMA */
> 1d2808fd3d2d5d Jeff Garzik 2007-05-28 396 .flags = ATA_FLAG_SLAVE_POSS,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 397 .pio_mask = ATA_PIO4,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 398 .mwdma_mask = ATA_MWDMA2,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 399 /* No UDMA */
> 669a5db411d85a Jeff Garzik 2006-08-29 400 .port_ops = &serverworks_osb4_port_ops
> 669a5db411d85a Jeff Garzik 2006-08-29 401 }, { /* CSB5 */
> 1d2808fd3d2d5d Jeff Garzik 2007-05-28 402 .flags = ATA_FLAG_SLAVE_POSS,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 403 .pio_mask = ATA_PIO4,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 404 .mwdma_mask = ATA_MWDMA2,
> bf6263a853c9c1 Jeff Garzik 2007-07-09 405 .udma_mask = ATA_UDMA4,
> 669a5db411d85a Jeff Garzik 2006-08-29 406 .port_ops = &serverworks_csb_port_ops
> 669a5db411d85a Jeff Garzik 2006-08-29 407 }, { /* CSB5 - later revisions*/
> 1d2808fd3d2d5d Jeff Garzik 2007-05-28 408 .flags = ATA_FLAG_SLAVE_POSS,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 409 .pio_mask = ATA_PIO4,
> 14bdef982caeda Erik Inge Bolsø 2009-03-14 410 .mwdma_mask = ATA_MWDMA2,
> bf6263a853c9c1 Jeff Garzik 2007-07-09 411 .udma_mask = ATA_UDMA5,
> 669a5db411d85a Jeff Garzik 2006-08-29 412 .port_ops = &serverworks_csb_port_ops
> 669a5db411d85a Jeff Garzik 2006-08-29 413 }
> 669a5db411d85a Jeff Garzik 2006-08-29 414 };
> 1626aeb881236c Tejun Heo 2007-05-04 415 const struct ata_port_info *ppi[] = { &info[id->driver_data], NULL };
> 37017ac6849e77 Scott Carter 2014-09-24 416 struct scsi_host_template *sht = &serverworks_csb_sht;
> f08048e94564d0 Tejun Heo 2008-03-25 417 int rc;
> f08048e94564d0 Tejun Heo 2008-03-25 418
> f08048e94564d0 Tejun Heo 2008-03-25 419 rc = pcim_enable_device(pdev);
> f08048e94564d0 Tejun Heo 2008-03-25 420 if (rc)
> f08048e94564d0 Tejun Heo 2008-03-25 421 return rc;
> 669a5db411d85a Jeff Garzik 2006-08-29 422
> d912be2f3b3353 Bartlomiej Zolnierkiewicz 2011-10-11 423 rc = serverworks_fixup(pdev);
> 669a5db411d85a Jeff Garzik 2006-08-29 424
> 669a5db411d85a Jeff Garzik 2006-08-29 425 /* OSB4 : South Bridge and IDE */
> 669a5db411d85a Jeff Garzik 2006-08-29 426 if (pdev->device == PCI_DEVICE_ID_SERVERWORKS_OSB4IDE) {
> 669a5db411d85a Jeff Garzik 2006-08-29 427 /* Select non UDMA capable OSB4 if we can't do fixups */
> d912be2f3b3353 Bartlomiej Zolnierkiewicz 2011-10-11 428 if (rc < 0)
> 1626aeb881236c Tejun Heo 2007-05-04 429 ppi[0] = &info[1];
> 37017ac6849e77 Scott Carter 2014-09-24 430 sht = &serverworks_osb4_sht;
> 669a5db411d85a Jeff Garzik 2006-08-29 431 }
> 669a5db411d85a Jeff Garzik 2006-08-29 432 /* setup CSB5/CSB6 : South Bridge and IDE option RAID */
> 669a5db411d85a Jeff Garzik 2006-08-29 433 else if ((pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB5IDE) ||
> 669a5db411d85a Jeff Garzik 2006-08-29 434 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE) ||
> 669a5db411d85a Jeff Garzik 2006-08-29 435 (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)) {
> 669a5db411d85a Jeff Garzik 2006-08-29 436
> 669a5db411d85a Jeff Garzik 2006-08-29 437 /* If the returned btr is the newer revision then
> 669a5db411d85a Jeff Garzik 2006-08-29 438 select the right info block */
> d912be2f3b3353 Bartlomiej Zolnierkiewicz 2011-10-11 439 if (rc == 3)
> 1626aeb881236c Tejun Heo 2007-05-04 440 ppi[0] = &info[3];
> 669a5db411d85a Jeff Garzik 2006-08-29 441
> 669a5db411d85a Jeff Garzik 2006-08-29 442 /* Is this the 3rd channel CSB6 IDE ? */
> 669a5db411d85a Jeff Garzik 2006-08-29 @443 if (pdev->device == PCI_DEVICE_ID_SERVERWORKS_CSB6IDE2)
> 1626aeb881236c Tejun Heo 2007-05-04 444 ppi[1] = &ata_dummy_port_info;
> 669a5db411d85a Jeff Garzik 2006-08-29 445 }
> 669a5db411d85a Jeff Garzik 2006-08-29 446
> 37017ac6849e77 Scott Carter 2014-09-24 447 return ata_pci_bmdma_init_one(pdev, ppi, sht, NULL, 0);
> 669a5db411d85a Jeff Garzik 2006-08-29 448 }
> 669a5db411d85a Jeff Garzik 2006-08-29 449
>
> :::::: The code at line 443 was first introduced by commit
> :::::: 669a5db411d85a14f86cd92bc16bf7ab5b8aa235 [libata] Add a bunch of PATA drivers.
>
> :::::: TO: Jeff Garzik <[email protected]>
> :::::: CC: Jeff Garzik <[email protected]>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests


本邮件及其附件含有龙芯中科的商业秘密信息，仅限于发送给上面地址中列出的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制或散发）本邮件及其附件中的信息。如果您错收本邮件，请您立即电话或邮件通知发件人并删除本邮件。
This email and its attachments contain confidential information from Loongson Technology , which is intended only for the person or entity whose address is listed above. Any use of the information contained herein in any way (including, but not limited to, total or partial disclosure, reproduction or dissemination) by persons other than the intended recipient(s) is prohibited. If you receive this email in error, please notify the sender by phone or email immediately and delete it.