2023-04-07 13:29:16

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 0/6] Couple of bindings / dt fixes

Couple of trivial fixes to make dtbs_check happy (happier).

Signed-off-by: Konrad Dybcio <[email protected]>
---
Konrad Dybcio (6):
dt-bindings: media: qcom,sdm845-venus-v2: Allow interconnect properties
dt-bindings: remoteproc: qcom: adsp: Allow firmware-name
dt-bindings: usb: dwc3: Allow dma-ranges
arm64: dts: qcom: sc7280: Fix up the gic node
arm64: dts: qcom: pm8916: Fix pm8941-misc node name
arm64: dts: qcom: sdm845-oneplus: Fix speaker GPIO node

.../devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 8 ++++++++
.../devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 ++
arch/arm64/boot/dts/qcom/pm8916.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sc7280.dtsi | 14 +++++++-------
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 12 +++++-------
6 files changed, 27 insertions(+), 15 deletions(-)
---
base-commit: e134c93f788fb93fd6a3ec3af9af850a2048c7e6
change-id: 20230407-topic-msm_dtb-08228a62a590

Best regards,
--
Konrad Dybcio <[email protected]>


2023-04-07 13:29:25

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 1/6] dt-bindings: media: qcom,sdm845-venus-v2: Allow interconnect properties

Allow the interconnect properties, which have been in use for ages.

Signed-off-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
index d5f80976f4cf..6228fd2b3246 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
@@ -48,6 +48,14 @@ properties:
iommus:
maxItems: 2

+ interconnects:
+ maxItems: 2
+
+ interconnect-names:
+ items:
+ - const: video-mem
+ - const: cpu-cfg
+
operating-points-v2: true
opp-table:
type: object

--
2.40.0

2023-04-07 13:29:28

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 2/6] dt-bindings: remoteproc: qcom: adsp: Allow firmware-name

firmware-name has been with us for a long long time. Allow it to fix
warnings like this:

qcom/sdm845-oneplus-enchilada.dtb: remoteproc-cdsp: Unevaluated properties
are not allowed ('firmware-name' was unexpected)

Signed-off-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
index 643ee787a81f..d99618a9ca2e 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
@@ -44,6 +44,10 @@ properties:
maxItems: 1
description: Reference to the reserved-memory for the Hexagon core

+ firmware-name:
+ $ref: /schemas/types.yaml#/definitions/string
+ description: Relative path to the DSP firmware binary
+
required:
- compatible


--
2.40.0

2023-04-07 13:29:40

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 4/6] arm64: dts: qcom: sc7280: Fix up the gic node

Fix the following schema warning:

gic-its@17a40000: False schema does not allow {'compatible':
['arm,gic-v3-its'], 'msi-controller': True, '#msi-cells': [[1]],
'reg': [[0, 396623872, 0, 131072]], 'status': ['disabled']}

And reorder the properties to be more in order with all other nodes.

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 0cdb16316021..3292b046a8d3 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -5182,20 +5182,20 @@ apps_smmu: iommu@15000000 {

intc: interrupt-controller@17a00000 {
compatible = "arm,gic-v3";
- #address-cells = <2>;
- #size-cells = <2>;
- ranges;
- #interrupt-cells = <3>;
- interrupt-controller;
reg = <0 0x17a00000 0 0x10000>, /* GICD */
<0 0x17a60000 0 0x100000>; /* GICR * 8 */
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
+ #interrupt-cells = <3>;
+ interrupt-controller;
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;

- gic-its@17a40000 {
+ msi-controller@17a40000 {
compatible = "arm,gic-v3-its";
+ reg = <0 0x17a40000 0 0x20000>;
msi-controller;
#msi-cells = <1>;
- reg = <0 0x17a40000 0 0x20000>;
status = "disabled";
};
};

--
2.40.0

2023-04-07 13:29:45

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 3/6] dt-bindings: usb: dwc3: Allow dma-ranges

Allow the common dma-ranges property to silence warning like this:

qcom/sc7280-herobrine-evoker.dtb: usb@a6f8800: 'dma-ranges' does not
match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'

Signed-off-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index d84281926f10..3c3548f55797 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -55,6 +55,8 @@ properties:

ranges: true

+ dma-ranges: true
+
power-domains:
description: specifies a phandle to PM domain provider node
maxItems: 1

--
2.40.0

2023-04-07 13:29:45

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 6/6] arm64: dts: qcom: sdm845-oneplus: Fix speaker GPIO node

Drop the unnecessary mux{} level to make dtbs check happy.

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index 0c268c560d37..8c2b9382337c 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -814,13 +814,11 @@ panel_esd_pin: panel-esd-state {
};

speaker_default: speaker-default-state {
- mux {
- pins = "gpio69";
- function = "gpio";
- drive-strength = <16>;
- bias-pull-up;
- output-high;
- };
+ pins = "gpio69";
+ function = "gpio";
+ drive-strength = <16>;
+ bias-pull-up;
+ output-high;
};
};


--
2.40.0

2023-04-07 13:30:15

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 5/6] arm64: dts: qcom: pm8916: Fix pm8941-misc node name

Fix the node name to make dtbs_check happy:

qcom/apq8016-sbc.dtb: pmic@0: 'extcon@1300' does not match any of the
regexes: '(.*)?(wled|leds)@[0-9a-f]+$', '^adc-tm@[0-9a-f]+$',
'^adc@[0-9a-f]+$', '^audio-codec@[0-9a-f]+$', '^charger@[0-9a-f]+$',
'^mpps@[0-9a-f]+$', '^nvram@[0-9a-f]+$', '^rtc@[0-9a-f]+$',
'^temp-alarm@[0-9a-f]+$', '^usb-detect@[0-9a-f]+$',
'^usb-vbus-regulator@[0-9a-f]+$', '^vibrator@[0-9a-f]+$',
'gpio@[0-9a-f]+$', 'pinctrl-[0-9]+', 'pon@[0-9a-f]+$'

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/pm8916.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi
index e2a6b66d8847..f4fb1a92ab55 100644
--- a/arch/arm64/boot/dts/qcom/pm8916.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi
@@ -41,7 +41,7 @@ watchdog {
};
};

- pm8916_usbin: extcon@1300 {
+ pm8916_usbin: usb-detect@1300 {
compatible = "qcom,pm8941-misc";
reg = <0x1300>;
interrupts = <0x0 0x13 1 IRQ_TYPE_EDGE_BOTH>;

--
2.40.0

2023-04-07 13:57:32

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 2/6] dt-bindings: remoteproc: qcom: adsp: Allow firmware-name

On 07/04/2023 15:28, Konrad Dybcio wrote:
> firmware-name has been with us for a long long time. Allow it to fix
> warnings like this:
>
> qcom/sdm845-oneplus-enchilada.dtb: remoteproc-cdsp: Unevaluated properties
> are not allowed ('firmware-name' was unexpected)
>

https://lore.kernel.org/all/[email protected]/

Just rebase on my pending work if you want to avoid duplicates...

Best regards,
Krzysztof

2023-04-07 13:58:14

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 3/6] dt-bindings: usb: dwc3: Allow dma-ranges

On 07/04/2023 15:28, Konrad Dybcio wrote:
> Allow the common dma-ranges property to silence warning like this:
>
> qcom/sc7280-herobrine-evoker.dtb: usb@a6f8800: 'dma-ranges' does not
> match any of the regexes: '^usb@[0-9a-f]+$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Konrad Dybcio <[email protected]>

It would be nice to see here explanation why dma-ranges should be added.
If DTS has it incorrectly, it might not be valid reason to add to the
binding.

Best regards,
Krzysztof

2023-04-07 13:58:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 6/6] arm64: dts: qcom: sdm845-oneplus: Fix speaker GPIO node

On 07/04/2023 15:28, Konrad Dybcio wrote:
> Drop the unnecessary mux{} level to make dtbs check happy.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-04-07 18:39:59

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/6] Couple of bindings / dt fixes

On Fri, 07 Apr 2023 15:28:30 +0200, Konrad Dybcio wrote:
> Couple of trivial fixes to make dtbs_check happy (happier).
>
>

Applied, thanks!

[4/6] arm64: dts: qcom: sc7280: Fix up the gic node
commit: 04b5840664822cefff61deb727f497b59c341e0e
[5/6] arm64: dts: qcom: pm8916: Fix pm8941-misc node name
commit: 7891372d6c5b3d73c304e26fa1e3b17c022281a1
[6/6] arm64: dts: qcom: sdm845-oneplus: Fix speaker GPIO node
commit: 149959d0b18113881cb0a47ad8f8d36b60ff6f9f

Best regards,
--
Bjorn Andersson <[email protected]>

2023-04-12 15:00:13

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/6] dt-bindings: media: qcom,sdm845-venus-v2: Allow interconnect properties


On Fri, 07 Apr 2023 15:28:31 +0200, Konrad Dybcio wrote:
> Allow the interconnect properties, which have been in use for ages.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>

Acked-by: Rob Herring <[email protected]>