2023-04-07 18:02:26

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: apq8016: remove superfluous "input-enable"

Pin configuration property "input-enable" was used with the intention to
disable the output, but this is done by default by Linux drivers. Since
patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
input-enable") the property is not accepted anymore.

Cc: Douglas Anderson <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index 27ceaa94c8bd..59860a2223b8 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -729,7 +729,6 @@ usb_id_default: usb-id-default-state {
function = "gpio";

drive-strength = <8>;
- input-enable;
bias-pull-up;
};

@@ -770,7 +769,6 @@ msm_key_volp_n_default: msm-key-volp-n-default-state {
function = "gpio";

drive-strength = <8>;
- input-enable;
bias-pull-up;
};
};
--
2.34.1


2023-04-07 19:12:21

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: apq8016: remove superfluous "input-enable"

On Fri, 7 Apr 2023 20:00:45 +0200, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> patch ("dt-bindings: pinctrl: qcom: tlmm should use output-disable, not
> input-enable") the property is not accepted anymore.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: apq8016: remove superfluous "input-enable"
commit: 8624e6063cb15cc7ceeee6d54fc1761ab3d0baf7

Best regards,
--
Bjorn Andersson <[email protected]>