2023-04-07 18:32:30

by Patrick Delaunay

Subject: [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file

Minor cosmetic change, aligned with file in U-Boot:
- remove extra space

Signed-off-by: Patrick Delaunay <[email protected]>
---

include/dt-bindings/mfd/stm32f4-rcc.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h
index 309e8c79f27b..36448a5619a1 100644
--- a/include/dt-bindings/mfd/stm32f4-rcc.h
+++ b/include/dt-bindings/mfd/stm32f4-rcc.h
@@ -34,7 +34,6 @@
#define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8))
#define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit)

-
/* AHB2 */
#define STM32F4_RCC_AHB2_DCMI 0
#define STM32F4_RCC_AHB2_CRYP 4
--
2.25.1

2023-04-12 15:05:47

by Rob Herring

Subject: Re: [PATCH] dt-bindings: mfd: stm32: Fix STM32F4 DT include file

On Fri, Apr 07, 2023 at 08:12:43PM +0200, Patrick Delaunay wrote:
> Minor cosmetic change, aligned with file in U-Boot:
> - remove extra space

extra blank line really.

Please make the subject reflect what the change is. This doesn't really
'Fix' anything and it's so generic it could be any change. Just 'Remove
double blank line' would be much better and defines the exact change.

>
> Signed-off-by: Patrick Delaunay <[email protected]>
> ---
>
> include/dt-bindings/mfd/stm32f4-rcc.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/dt-bindings/mfd/stm32f4-rcc.h b/include/dt-bindings/mfd/stm32f4-rcc.h
> index 309e8c79f27b..36448a5619a1 100644
> --- a/include/dt-bindings/mfd/stm32f4-rcc.h
> +++ b/include/dt-bindings/mfd/stm32f4-rcc.h
> @@ -34,7 +34,6 @@
> #define STM32F4_AHB1_RESET(bit) (STM32F4_RCC_AHB1_##bit + (0x10 * 8))
> #define STM32F4_AHB1_CLOCK(bit) (STM32F4_RCC_AHB1_##bit)
>
> -
> /* AHB2 */
> #define STM32F4_RCC_AHB2_DCMI 0
> #define STM32F4_RCC_AHB2_CRYP 4
> --
> 2.25.1
>