2023-04-10 18:48:13

by Brad Larson

[permalink] [raw]
Subject: [PATCH v13 03/15] dt-bindings: spi: cdns: Add compatible for AMD Pensando Elba SoC

Document the cadence qspi controller compatible for AMD Pensando
Elba SoC boards. The Elba qspi fifo size is 1024.

Signed-off-by: Brad Larson <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---

v11 changes:
- Removed redundant if/then for amd,pensando-elba-qspi

v10 changes:
- Fix cdns,fifo-depth, only amd,pensando-elba-qspi is 1024 bytes

v9 changes:
- Add 1024 to cdns,fifo-depth property to resolve dtbs_check error

---
.../bindings/spi/cdns,qspi-nor.yaml | 19 +++++++++++++++++--
1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
index 5c01db128be0..6e67de9da293 100644
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
@@ -20,11 +20,28 @@ allOf:
required:
- power-domains

+ - if:
+ properties:
+ compatible:
+ contains:
+ const: amd,pensando-elba-qspi
+ then:
+ properties:
+ cdns,fifo-depth:
+ enum: [ 128, 256, 1024 ]
+ default: 1024
+ else:
+ properties:
+ cdns,fifo-depth:
+ enum: [ 128, 256 ]
+ default: 128
+
properties:
compatible:
oneOf:
- items:
- enum:
+ - amd,pensando-elba-qspi
- ti,k2g-qspi
- ti,am654-ospi
- intel,lgm-qspi
@@ -48,8 +65,6 @@ properties:
description:
Size of the data FIFO in words.
$ref: /schemas/types.yaml#/definitions/uint32
- enum: [ 128, 256 ]
- default: 128

cdns,fifo-width:
$ref: /schemas/types.yaml#/definitions/uint32
--
2.17.1


2023-04-17 17:16:54

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v13 03/15] dt-bindings: spi: cdns: Add compatible for AMD Pensando Elba SoC

On Mon, Apr 10, 2023 at 11:45:14AM -0700, Brad Larson wrote:
> Document the cadence qspi controller compatible for AMD Pensando
> Elba SoC boards. The Elba qspi fifo size is 1024.

This does not apply against current code, please check and resend.


Attachments:
(No filename) (254.00 B)
signature.asc (499.00 B)
Download all attachments

2023-04-18 22:10:28

by Brad Larson

[permalink] [raw]
Subject: [PATCH v14 03/15] dt-bindings: spi: cdns: Add compatible for AMD Pensando Elba SoC

Document the cadence qspi controller compatible for AMD Pensando
Elba SoC boards. The Elba qspi fifo size is 1024.

Signed-off-by: Brad Larson <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---

v14 changes:
- Patch series is against rc1, this patch failed to apply to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
Rebase this patch to rc7.

v11 changes:
- Removed redundant if/then for amd,pensando-elba-qspi

v10 changes:
- Fix cdns,fifo-depth, only amd,pensando-elba-qspi is 1024 bytes

v9 changes:
- Add 1024 to cdns,fifo-depth property to resolve dtbs_check error

---
.../devicetree/bindings/spi/cdns,qspi-nor.yaml | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
index b310069762dd..4f15f9a0cc34 100644
--- a/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
+++ b/Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml
@@ -46,12 +46,28 @@ allOf:
maxItems: 2
items:
enum: [ qspi, qspi-ocp ]
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: amd,pensando-elba-qspi
+ then:
+ properties:
+ cdns,fifo-depth:
+ enum: [ 128, 256, 1024 ]
+ default: 1024
+ else:
+ properties:
+ cdns,fifo-depth:
+ enum: [ 128, 256 ]
+ default: 128

properties:
compatible:
oneOf:
- items:
- enum:
+ - amd,pensando-elba-qspi
- ti,k2g-qspi
- ti,am654-ospi
- intel,lgm-qspi
@@ -76,8 +92,6 @@ properties:
description:
Size of the data FIFO in words.
$ref: /schemas/types.yaml#/definitions/uint32
- enum: [ 128, 256 ]
- default: 128

cdns,fifo-width:
$ref: /schemas/types.yaml#/definitions/uint32

base-commit: 67d5d9f013d6c3829383c08162939cabff14fccc
--
2.17.1