2023-04-10 19:10:55

by Yazen Ghannam

Subject: [PATCH] EDAC/amd64: Remove module version string

The AMD64 EDAC module version information is not exposed through ABI
like MODULE_VERSION(). Instead it is printed during module init.

Version numbers may be confusing in cases where module updates are
partly backported resulting in a difference between upstream and
backported module versions.

Remove the AMD64 EDAC module version information to avoid user
confusion.

Signed-off-by: Yazen Ghannam <[email protected]>
---
drivers/edac/amd64_edac.c | 4 +---
drivers/edac/amd64_edac.h | 1 -
2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 5c4292e65b96..37b1a6127d0b 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -4074,8 +4074,6 @@ static int __init amd64_edac_init(void)
amd64_err("%s on 32-bit is unsupported. USE AT YOUR OWN RISK!\n", EDAC_MOD_STR);
#endif

- printk(KERN_INFO "AMD64 EDAC driver v%s\n", EDAC_AMD64_VERSION);
-
return 0;

err_pci:
@@ -4121,7 +4119,7 @@ module_exit(amd64_edac_exit);

MODULE_LICENSE("GPL");
MODULE_AUTHOR("SoftwareBitMaker: Doug Thompson, Dave Peterson, Thayne Harbaugh; AMD");
-MODULE_DESCRIPTION("MC support for AMD64 memory controllers - " EDAC_AMD64_VERSION);
+MODULE_DESCRIPTION("MC support for AMD64 memory controllers");

module_param(edac_op_state, int, 0444);
MODULE_PARM_DESC(edac_op_state, "EDAC Error Reporting state: 0=Poll,1=NMI");
diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
index e84fe0d4120a..0bde0db76f7a 100644
--- a/drivers/edac/amd64_edac.h
+++ b/drivers/edac/amd64_edac.h
@@ -85,7 +85,6 @@
* sections 3.5.4 and 3.5.5 for more information.
*/

-#define EDAC_AMD64_VERSION "3.5.0"
#define EDAC_MOD_STR "amd64_edac"

/* Extended Model from CPUID, for CPU Revision numbers */
--
2.34.1

2023-05-10 14:04:47

by Borislav Petkov

Subject: Re: [PATCH] EDAC/amd64: Remove module version string

On Mon, Apr 10, 2023 at 02:09:59PM -0500, Yazen Ghannam wrote:
> The AMD64 EDAC module version information is not exposed through ABI
> like MODULE_VERSION(). Instead it is printed during module init.
>
> Version numbers may be confusing in cases where module updates are
> partly backported resulting in a difference between upstream and
> backported module versions.
>
> Remove the AMD64 EDAC module version information to avoid user
> confusion.
>
> Signed-off-by: Yazen Ghannam <[email protected]>
> ---
> drivers/edac/amd64_edac.c | 4 +---
> drivers/edac/amd64_edac.h | 1 -
> 2 files changed, 1 insertion(+), 4 deletions(-)

Applied, thanks.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette