2023-04-11 06:49:38

by Changhuang Liang

[permalink] [raw]
Subject: [PATCH v1 2/7] soc: starfive: Replace SOC_STARFIVE with ARCH_SATRFIVE

Using ARCH_FOO symbol is preferred than SOC_FOO.

Signed-off-by: Changhuang Liang <[email protected]>
---
drivers/soc/starfive/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/starfive/Kconfig b/drivers/soc/starfive/Kconfig
index bdb96dc4c989..1e9b0c414fec 100644
--- a/drivers/soc/starfive/Kconfig
+++ b/drivers/soc/starfive/Kconfig
@@ -3,8 +3,8 @@
config JH71XX_PMU
bool "Support PMU for StarFive JH71XX Soc"
depends on PM
- depends on SOC_STARFIVE || COMPILE_TEST
- default SOC_STARFIVE
+ depends on ARCH_STARFIVE || COMPILE_TEST
+ default ARCH_STARFIVE
select PM_GENERIC_DOMAINS
help
Say 'y' here to enable support power domain support.
--
2.25.1


2023-04-11 20:22:58

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH v1 2/7] soc: starfive: Replace SOC_STARFIVE with ARCH_SATRFIVE

On Mon, Apr 10, 2023 at 11:47:38PM -0700, Changhuang Liang wrote:
> Using ARCH_FOO symbol is preferred than SOC_FOO.
>

Reviewed-by: Conor Dooley <[email protected]>

> Signed-off-by: Changhuang Liang <[email protected]>
> ---
> drivers/soc/starfive/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/starfive/Kconfig b/drivers/soc/starfive/Kconfig
> index bdb96dc4c989..1e9b0c414fec 100644
> --- a/drivers/soc/starfive/Kconfig
> +++ b/drivers/soc/starfive/Kconfig
> @@ -3,8 +3,8 @@
> config JH71XX_PMU
> bool "Support PMU for StarFive JH71XX Soc"
> depends on PM
> - depends on SOC_STARFIVE || COMPILE_TEST
> - default SOC_STARFIVE
> + depends on ARCH_STARFIVE || COMPILE_TEST
> + default ARCH_STARFIVE
> select PM_GENERIC_DOMAINS
> help
> Say 'y' here to enable support power domain support.
> --
> 2.25.1
>

Attachments:
(No filename) (928.00 B)
 signature.asc (235.00 B)
 Download all attachments

2023-04-12 02:29:15

by Walker Chen

[permalink] [raw]
Subject: Re: [PATCH v1 2/7] soc: starfive: Replace SOC_STARFIVE with ARCH_SATRFIVE



On 2023/4/11 14:47, Changhuang Liang wrote:
> Using ARCH_FOO symbol is preferred than SOC_FOO.
>
> Signed-off-by: Changhuang Liang <[email protected]>
> ---
> drivers/soc/starfive/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/starfive/Kconfig b/drivers/soc/starfive/Kconfig
> index bdb96dc4c989..1e9b0c414fec 100644
> --- a/drivers/soc/starfive/Kconfig
> +++ b/drivers/soc/starfive/Kconfig
> @@ -3,8 +3,8 @@
> config JH71XX_PMU
> bool "Support PMU for StarFive JH71XX Soc"
> depends on PM
> - depends on SOC_STARFIVE || COMPILE_TEST
> - default SOC_STARFIVE
> + depends on ARCH_STARFIVE || COMPILE_TEST
> + default ARCH_STARFIVE
> select PM_GENERIC_DOMAINS
> help
> Say 'y' here to enable support power domain support.

The subject 'ARCH_SATRFIVE' spelling error.

Best regards,
Walker

2023-04-12 02:59:26

by Changhuang Liang

[permalink] [raw]
Subject: Re: [PATCH v1 2/7] soc: starfive: Replace SOC_STARFIVE with ARCH_SATRFIVE



On 2023/4/12 10:11, Walker Chen wrote:
>
>
> On 2023/4/11 14:47, Changhuang Liang wrote:
>> Using ARCH_FOO symbol is preferred than SOC_FOO.
>>
>> Signed-off-by: Changhuang Liang <[email protected]>
>> ---
>> drivers/soc/starfive/Kconfig | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/soc/starfive/Kconfig b/drivers/soc/starfive/Kconfig
>> index bdb96dc4c989..1e9b0c414fec 100644
>> --- a/drivers/soc/starfive/Kconfig
>> +++ b/drivers/soc/starfive/Kconfig
>> @@ -3,8 +3,8 @@
>> config JH71XX_PMU
>> bool "Support PMU for StarFive JH71XX Soc"
>> depends on PM
>> - depends on SOC_STARFIVE || COMPILE_TEST
>> - default SOC_STARFIVE
>> + depends on ARCH_STARFIVE || COMPILE_TEST
>> + default ARCH_STARFIVE
>> select PM_GENERIC_DOMAINS
>> help
>> Say 'y' here to enable support power domain support.
>
> The subject 'ARCH_SATRFIVE' spelling error.
>

OK, will fix it.

> Best regards,
> Walker