2023-04-12 09:32:50

by Bo Liu

[permalink] [raw]
Subject: [PATCH] mmc: vub300: remove unreachable code

The function sched_partition_show cannot execute return, delete the
invalid code.

Signed-off-by: Bo Liu <[email protected]>
---
drivers/mmc/host/vub300.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
index 72f65f32abbc..e4c4bfac3763 100644
--- a/drivers/mmc/host/vub300.c
+++ b/drivers/mmc/host/vub300.c
@@ -1341,8 +1341,6 @@ static void __download_offload_pseudocode(struct vub300_mmc_host *vub300,
return;
}

- return;
-
copy_error_message:
strncpy(vub300->vub_name, "SDIO pseudocode download failed",
sizeof(vub300->vub_name));
--
2.27.0


2023-04-17 14:57:31

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH] mmc: vub300: remove unreachable code

On Wed, 12 Apr 2023 at 10:48, Bo Liu <[email protected]> wrote:
>
> The function sched_partition_show cannot execute return, delete the
> invalid code.
>
> Signed-off-by: Bo Liu <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> drivers/mmc/host/vub300.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mmc/host/vub300.c b/drivers/mmc/host/vub300.c
> index 72f65f32abbc..e4c4bfac3763 100644
> --- a/drivers/mmc/host/vub300.c
> +++ b/drivers/mmc/host/vub300.c
> @@ -1341,8 +1341,6 @@ static void __download_offload_pseudocode(struct vub300_mmc_host *vub300,
> return;
> }
>
> - return;
> -
> copy_error_message:
> strncpy(vub300->vub_name, "SDIO pseudocode download failed",
> sizeof(vub300->vub_name));
> --
> 2.27.0
>