2023-04-12 11:02:58

by Amelie Delaunay

Subject: [RESEND PATCH 0/2] STMFX chip init couple of fixes

This series fixes the behavior of stm32_chip_init function in case
of errors.

Amelie Delaunay (2):
mfd: stmfx: Fix error path in stmfx_chip_init
mfd: stmfx: Nullify stmfx->vdd in case of error

drivers/mfd/stmfx.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)

--
2.25.1

2023-04-12 11:03:16

by Amelie Delaunay

Subject: [RESEND PATCH 2/2] mfd: stmfx: Nullify stmfx->vdd in case of error

Nullify stmfx->vdd in case devm_regulator_get_optional() returns an error.
And simplify code by returning an error only if return code is not -ENODEV,
which means there is no vdd regulator and it is not an issue.

Fixes: d75846ed08e6 ("mfd: stmfx: Fix dev_err_probe() call in stmfx_chip_init()")
Signed-off-by: Amelie Delaunay <[email protected]>
---
drivers/mfd/stmfx.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/stmfx.c b/drivers/mfd/stmfx.c
index bfe89df27611..76188212c66e 100644
--- a/drivers/mfd/stmfx.c
+++ b/drivers/mfd/stmfx.c
@@ -330,9 +330,8 @@ static int stmfx_chip_init(struct i2c_client *client)
stmfx->vdd = devm_regulator_get_optional(&client->dev, "vdd");
ret = PTR_ERR_OR_ZERO(stmfx->vdd);
if (ret) {
- if (ret == -ENODEV)
- stmfx->vdd = NULL;
- else
+ stmfx->vdd = NULL;
+ if (ret != -ENODEV)
return dev_err_probe(&client->dev, ret, "Failed to get VDD regulator\n");
}

--
2.25.1

2023-06-09 09:58:51

by Amelie Delaunay

Subject: Re: [RESEND PATCH 0/2] STMFX chip init couple of fixes

Kind reminder on this series, pending for almost 3 months.

Thanks,
Amelie


On 4/12/23 12:55, Amelie Delaunay wrote:
> This series fixes the behavior of stm32_chip_init function in case
> of errors.
>
> Amelie Delaunay (2):
> mfd: stmfx: Fix error path in stmfx_chip_init
> mfd: stmfx: Nullify stmfx->vdd in case of error
>
> drivers/mfd/stmfx.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>