2023-04-12 20:25:20

by Rohit Ner

[permalink] [raw]
Subject: [PATCH v2 0/1] SPI loopback testing framework updates

---
V1 Changes : Add module param for iteration length
---
V1->V2 Changes : Fix patch format
---


Rohit Ner (1):
spi: spi-loopback-test: Add module param for iteration length

drivers/spi/spi-loopback-test.c | 8 ++++++++
1 file changed, 8 insertions(+)

--
2.40.0.577.gac1e443424-goog


2023-04-12 20:25:22

by Rohit Ner

[permalink] [raw]
Subject: [PATCH v2 1/1] spi: spi-loopback-test: Add module param for iteration length

SPI test framework is designed to run each test case for
a list of lengths.
Introduce a module parameter to limit the iterations
to a single value among the list of lengths.

Signed-off-by: Rohit Ner <[email protected]>
---
drivers/spi/spi-loopback-test.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/spi/spi-loopback-test.c b/drivers/spi/spi-loopback-test.c
index 313106eb8d40..675a73cf1579 100644
--- a/drivers/spi/spi-loopback-test.c
+++ b/drivers/spi/spi-loopback-test.c
@@ -53,6 +53,12 @@ module_param(no_cs, int, 0);
MODULE_PARM_DESC(no_cs,
"if set Chip Select (CS) will not be used");

+/* run tests only for a specific length */
+static int run_only_iter_len = -1;
+module_param(run_only_iter_len, int, 0);
+MODULE_PARM_DESC(run_only_iter_len,
+ "only run tests for a length of this number in iterate_len list");
+
/* run only a specific test */
static int run_only_test = -1;
module_param(run_only_test, int, 0);
@@ -1033,6 +1039,8 @@ int spi_test_run_test(struct spi_device *spi, const struct spi_test *test,

for (idx_len = 0; idx_len < SPI_TEST_MAX_ITERATE &&
(len = test->iterate_len[idx_len]) != -1; idx_len++) {
+ if ((run_only_iter_len > -1) && len != run_only_iter_len)
+ continue;
FOR_EACH_ALIGNMENT(tx_align) {
FOR_EACH_ALIGNMENT(rx_align) {
/* and run the iteration */
--
2.40.0.577.gac1e443424-goog

2023-04-12 20:26:17

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2 0/1] SPI loopback testing framework updates

On Wed, Apr 12, 2023 at 01:20:08PM -0700, Rohit Ner wrote:
> ---
> V1 Changes : Add module param for iteration length
> ---
> V1->V2 Changes : Fix patch format
> ---

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff. This reduces mail volume and ensures that
any important information is recorded in the changelog rather than being
lost.


Attachments:
(No filename) (478.00 B)
signature.asc (499.00 B)
Download all attachments

2023-04-13 18:06:38

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2 0/1] SPI loopback testing framework updates

On Wed, 12 Apr 2023 13:20:08 -0700, Rohit Ner wrote:
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] spi: spi-loopback-test: Add module param for iteration length
commit: 6d87552c0b86b9677d762002082df5f5b7e3c33f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark