2023-04-13 01:19:33

by Deming Wang

Subject: [PATCH] mm: huge_memory: Replace obsolete memalign() with posix_memalign()

memalign() is obsolete according to its manpage.

Replace memalign() with posix_memalign()

As a pointer is passed into posix_memalign(), initialize *one_page
to NULL to silence a warning about the function's return value being
used as uninitialized (which is not valid anyway because the error
is properly checked before one_page is returned).

Signed-off-by: Deming Wang <[email protected]>
---
tools/testing/selftests/mm/split_huge_page_test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
index cbb5e6893cbf..94c7dffc4d7d 100644
--- a/tools/testing/selftests/mm/split_huge_page_test.c
+++ b/tools/testing/selftests/mm/split_huge_page_test.c
@@ -96,10 +96,10 @@ void split_pmd_thp(void)
char *one_page;
size_t len = 4 * pmd_pagesize;
size_t i;
+ int ret;

- one_page = memalign(pmd_pagesize, len);
-
- if (!one_page) {
+ ret = posix_memalign((void **)&one_page, pmd_pagesize, len);
+ if (ret < 0) {
printf("Fail to allocate memory\n");
exit(EXIT_FAILURE);
}
--
2.27.0

2023-04-13 12:10:02

by David Hildenbrand

Subject: Re: [PATCH] mm: huge_memory: Replace obsolete memalign() with posix_memalign()

On 13.04.23 03:17, Deming Wang wrote:
> memalign() is obsolete according to its manpage.
>
> Replace memalign() with posix_memalign()
>
> As a pointer is passed into posix_memalign(), initialize *one_page
> to NULL to silence a warning about the function's return value being
> used as uninitialized (which is not valid anyway because the error
> is properly checked before one_page is returned).

^ I'm getting tired of pointing out the same thing.

Please collect similar patches and send them as a series; and stop
copy-pasting the same thing into all of the similar patches you send.

Last but not least, tag you patches accordingly: "selftests/mm:
split_huge_page_test: ..."

>
> Signed-off-by: Deming Wang <[email protected]>
> ---
> tools/testing/selftests/mm/split_huge_page_test.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/split_huge_page_test.c b/tools/testing/selftests/mm/split_huge_page_test.c
> index cbb5e6893cbf..94c7dffc4d7d 100644
> --- a/tools/testing/selftests/mm/split_huge_page_test.c
> +++ b/tools/testing/selftests/mm/split_huge_page_test.c
> @@ -96,10 +96,10 @@ void split_pmd_thp(void)
> char *one_page;
> size_t len = 4 * pmd_pagesize;
> size_t i;
> + int ret;
>
> - one_page = memalign(pmd_pagesize, len);
> -
> - if (!one_page) {
> + ret = posix_memalign((void **)&one_page, pmd_pagesize, len);
> + if (ret < 0) {
> printf("Fail to allocate memory\n");
> exit(EXIT_FAILURE);
> }

--
Thanks,

David / dhildenb