2023-04-13 22:31:31

by Judith Mendez

[permalink] [raw]
Subject: [RFC PATCH 3/5] dt-binding: can: m_can: Remove required interrupt attributes

Remove required attributes for interrupt and interrupt names
since some MCANs may not have hardware interrupt routed to A53
Linux.

Signed-off-by: Judith Mendez <[email protected]>
---
Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 2 --
1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
index 67879aab623b..43f1aa9addc0 100644
--- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
+++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
@@ -122,8 +122,6 @@ required:
- compatible
- reg
- reg-names
- - interrupts
- - interrupt-names
- clocks
- clock-names
- bosch,mram-cfg
--
2.17.1


2023-04-14 08:04:18

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [RFC PATCH 3/5] dt-binding: can: m_can: Remove required interrupt attributes

On 14/04/2023 00:30, Judith Mendez wrote:
> Remove required attributes for interrupt and interrupt names
> since some MCANs may not have hardware interrupt routed to A53

Like which? Can you give specific model names?

> Linux.
>

Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).

It's dt-bindings:


> Signed-off-by: Judith Mendez <[email protected]>
> ---
> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> index 67879aab623b..43f1aa9addc0 100644
> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml
> @@ -122,8 +122,6 @@ required:
> - compatible
> - reg
> - reg-names
> - - interrupts
> - - interrupt-names
> - clocks
> - clock-names
> - bosch,mram-cfg

Best regards,
Krzysztof