2023-04-14 08:29:29

by 孙滢

Subject: [PATCH v1] trace: add the necessary dependencies of configuration options

From: Ying Sun <[email protected]>

HAVE_NOP_MCOUNT is used only if the condition
"ifdef CONFIG_FTRACE_MCOUNT_USE_CC" is met in the Makefile,
adding a dependency constraint on this configuration option
to prevent it from being set ‘y' but not taking effect.

Suggested-by: Yanjie Ren <[email protected]>
Signed-off-by: Ying Sun <[email protected]>
---
kernel/trace/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 8cf97fa4a4b3..c640f405cc91 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -77,6 +77,7 @@ config HAVE_FENTRY

config HAVE_NOP_MCOUNT
bool
+ depends on FTRACE_MCOUNT_USE_CC
help
Arch supports the gcc options -pg with -mrecord-mcount and -nop-mcount

--
2.17.1

2023-04-25 19:15:31

by Steven Rostedt

Subject: Re: [PATCH v1] trace: add the necessary dependencies of configuration options

On Fri, 14 Apr 2023 16:27:56 +0800
[email protected] wrote:

> From: Ying Sun <[email protected]>
>
> HAVE_NOP_MCOUNT is used only if the condition
> "ifdef CONFIG_FTRACE_MCOUNT_USE_CC" is met in the Makefile,
> adding a dependency constraint on this configuration option
> to prevent it from being set ‘y' but not taking effect.
>
> Suggested-by: Yanjie Ren <[email protected]>
> Signed-off-by: Ying Sun <[email protected]>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index 8cf97fa4a4b3..c640f405cc91 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -77,6 +77,7 @@ config HAVE_FENTRY
>
> config HAVE_NOP_MCOUNT
> bool
> + depends on FTRACE_MCOUNT_USE_CC

As I replied to the other email. The HAVE_* configs are only for
architectures to say if they support something or not. There's no need to
add dependencies here.

-- Steve



> help
> Arch supports the gcc options -pg with -mrecord-mcount and -nop-mcount
>