2023-04-17 07:56:20

by Hal Feng

Subject: [PATCH v1 2/2] clk: starfive: Delete the redundant dev_set_drvdata() in JH7110 clock drivers

The dev_set_drvdata() is no longer needed after we used a wrapper
struct to get the data in auxiliary driver.

Cc: Xingyu Wu <[email protected]>
Fixes: d1aae0663023 ("clk: starfive: Avoid casting iomem pointers")
Signed-off-by: Hal Feng <[email protected]>
---
drivers/clk/starfive/clk-starfive-jh7110-aon.c | 2 --
drivers/clk/starfive/clk-starfive-jh7110-sys.c | 2 --
2 files changed, 4 deletions(-)

diff --git a/drivers/clk/starfive/clk-starfive-jh7110-aon.c b/drivers/clk/starfive/clk-starfive-jh7110-aon.c
index a2799fe8a234..62954eb7b50a 100644
--- a/drivers/clk/starfive/clk-starfive-jh7110-aon.c
+++ b/drivers/clk/starfive/clk-starfive-jh7110-aon.c
@@ -83,8 +83,6 @@ static int jh7110_aoncrg_probe(struct platform_device *pdev)
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);

- dev_set_drvdata(priv->dev, (void *)(&priv->base));
-
for (idx = 0; idx < JH7110_AONCLK_END; idx++) {
u32 max = jh7110_aonclk_data[idx].max;
struct clk_parent_data parents[4] = {};
diff --git a/drivers/clk/starfive/clk-starfive-jh7110-sys.c b/drivers/clk/starfive/clk-starfive-jh7110-sys.c
index 851b93d0f371..e6031345ef05 100644
--- a/drivers/clk/starfive/clk-starfive-jh7110-sys.c
+++ b/drivers/clk/starfive/clk-starfive-jh7110-sys.c
@@ -402,8 +402,6 @@ static int __init jh7110_syscrg_probe(struct platform_device *pdev)
if (IS_ERR(priv->base))
return PTR_ERR(priv->base);

- dev_set_drvdata(priv->dev, (void *)(&priv->base));
-
/*
* These PLL clocks are not actually fixed factor clocks and can be
* controlled by the syscon registers of JH7110. They will be dropped
--
2.38.1

2023-04-18 01:17:46

by Stephen Boyd

Subject: Re: [PATCH v1 2/2] clk: starfive: Delete the redundant dev_set_drvdata() in JH7110 clock drivers

Quoting Hal Feng (2023-04-17 00:41:15)
> The dev_set_drvdata() is no longer needed after we used a wrapper
> struct to get the data in auxiliary driver.
>
> Cc: Xingyu Wu <[email protected]>
> Fixes: d1aae0663023 ("clk: starfive: Avoid casting iomem pointers")
> Signed-off-by: Hal Feng <[email protected]>
> ---

Applied to clk-next