2023-04-18 17:47:28

by Daeho Jeong

Subject: [PATCH] f2fs: allocate node blocks for atomic write block replacement

From: Daeho Jeong <[email protected]>

When a node block is missing for atomic write block replacement, we need
to allocate it in advance of the replacement.

Signed-off-by: Daeho Jeong <[email protected]>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index c35476b3c075..0e1e29800934 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -217,7 +217,7 @@ static int __replace_atomic_write_block(struct inode *inode, pgoff_t index,

retry:
set_new_dnode(&dn, inode, NULL, NULL, 0);
- err = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE_RA);
+ err = f2fs_get_dnode_of_data(&dn, index, ALLOC_NODE);
if (err) {
if (err == -ENOMEM) {
f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
--
2.40.0.634.g4ca3ef3211-goog

2023-04-21 02:34:16

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: allocate node blocks for atomic write block replacement

On 2023/4/19 1:42, Daeho Jeong wrote:
> From: Daeho Jeong <[email protected]>
>
> When a node block is missing for atomic write block replacement, we need
> to allocate it in advance of the replacement.

Miss a fixes line?

Otherwise it looks good to me.

Thanks,

>
> Signed-off-by: Daeho Jeong <[email protected]>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index c35476b3c075..0e1e29800934 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -217,7 +217,7 @@ static int __replace_atomic_write_block(struct inode *inode, pgoff_t index,
>
> retry:
> set_new_dnode(&dn, inode, NULL, NULL, 0);
> - err = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE_RA);
> + err = f2fs_get_dnode_of_data(&dn, index, ALLOC_NODE);
> if (err) {
> if (err == -ENOMEM) {
> f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);