2023-04-18 12:34:02

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.10 000/124] 5.10.178-rc1 review

This is the start of the stable review cycle for the 5.10.178 release.
There are 124 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.10.178-rc1

Kuniyuki Iwashima <[email protected]>
sysctl: Fix data-races in proc_dou8vec_minmax().

Valentin Schneider <[email protected]>
panic, kexec: make __crash_kexec() NMI safe

Valentin Schneider <[email protected]>
kexec: turn all kexec_mutex acquisitions into trylocks

Arnd Bergmann <[email protected]>
kexec: move locking into do_kexec_load

Nathan Chancellor <[email protected]>
riscv: Handle zicsr/zifencei issues between clang and binutils

Masahiro Yamada <[email protected]>
kbuild: check CONFIG_AS_IS_LLVM instead of LLVM_IAS

Nathan Chancellor <[email protected]>
kbuild: Switch to 'f' variants of integrated assembler flag

Masahiro Yamada <[email protected]>
kbuild: check the minimum assembler version in Kconfig

Steve Clevenger <[email protected]>
coresight-etm4: Fix for() loop drvdata->nr_addr_cmp range bug

George Cherian <[email protected]>
watchdog: sbsa_wdog: Make sure the timeout programming is within the limits

Waiman Long <[email protected]>
cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods

Waiman Long <[email protected]>
cgroup/cpuset: Make cpuset_fork() handle CLONE_INTO_CGROUP properly

Waiman Long <[email protected]>
cgroup/cpuset: Skip spread flags update on v2

Waiman Long <[email protected]>
cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem

Gregor Herburger <[email protected]>
i2c: ocores: generate stop condition after timeout in polling mode

Matija Glavinic Pecotic <[email protected]>
x86/rtc: Remove __init for runtime functions

Vincent Guittot <[email protected]>
sched/fair: Fix imbalance overflow

zgpeng <[email protected]>
sched/fair: Move calculate of avg_load to a better location

Aneesh Kumar K.V <[email protected]>
powerpc/papr_scm: Update the NUMA distance table for the target node

Aneesh Kumar K.V <[email protected]>
powerpc/pseries: Add support for FORM2 associativity

Aneesh Kumar K.V <[email protected]>
powerpc/pseries: Add a helper for form1 cpu distance

Aneesh Kumar K.V <[email protected]>
powerpc/pseries: Consolidate different NUMA distance update code paths

Aneesh Kumar K.V <[email protected]>
powerpc/pseries: Rename TYPE1_AFFINITY to FORM1_AFFINITY

Aneesh Kumar K.V <[email protected]>
powerpc/pseries: rename min_common_depth to primary_domain_index

ZhaoLong Wang <[email protected]>
ubi: Fix deadlock caused by recursively holding work_sem

Lee Jones <[email protected]>
mtd: ubi: wl: Fix a couple of kernel-doc issues

Zhihao Cheng <[email protected]>
ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size

Waiman Long <[email protected]>
cgroup/cpuset: Wake up cpuset_attach_wq tasks in cpuset_cancel_attach()

Basavaraj Natikar <[email protected]>
x86/PCI: Add quirk for AMD XHCI controller that loses MSI-X state in D3hot

Jiri Kosina <[email protected]>
scsi: ses: Handle enclosure with just a primary component gracefully

Ivan Bornyakov <[email protected]>
net: sfp: initialize sfp->i2c_block_size at sfp allocation

Mathis Salmen <[email protected]>
riscv: add icache flush for nommu sigreturn trampoline

Robbie Harwood <[email protected]>
asymmetric_keys: log on fatal failures in PE/pkcs7

Robbie Harwood <[email protected]>
verify_pefile: relax wrapper length check

Hans de Goede <[email protected]>
drm: panel-orientation-quirks: Add quirk for Lenovo Yoga Book X90F

Hans de Goede <[email protected]>
efi: sysfb_efi: Add quirk for Lenovo Yoga Book X91F/L

Alexander Stein <[email protected]>
i2c: imx-lpi2c: clean rx/tx buffers upon new message

Krzysztof Kozlowski <[email protected]>
wifi: mwifiex: mark OF related data as maybe unused

Grant Grundler <[email protected]>
power: supply: cros_usbpd: reclassify "default case!" as debug

Andrii Nakryiko <[email protected]>
libbpf: Fix single-line struct definition output in btf_dump

Roman Gushchin <[email protected]>
net: macb: fix a memory corruption in extended buffer descriptor mode

Eric Dumazet <[email protected]>
udp6: fix potential access to stale information

Saravanan Vajravel <[email protected]>
RDMA/core: Fix GID entry ref leak when create_ah fails

Xin Long <[email protected]>
sctp: fix a potential overflow in sctp_ifwdtsn_skip

Ziyang Xuan <[email protected]>
net: qrtr: Fix an uninit variable access bug in qrtr_tx_resume()

Denis Plotnikov <[email protected]>
qlcnic: check pci_reset_function result

Christophe JAILLET <[email protected]>
drm/armada: Fix a potential double free in an error handling path

YueHaibing <[email protected]>
tcp: restrict net.ipv4.tcp_app_win

Eric Dumazet <[email protected]>
tcp: convert elligible sysctls to u8

Eric Dumazet <[email protected]>
ipv4: shrink netns_ipv4 with sysctl conversions

Eric Dumazet <[email protected]>
sysctl: add proc_dou8vec_minmax()

Harshit Mogalapalli <[email protected]>
niu: Fix missing unwind goto in niu_alloc_channels()

Zheng Wang <[email protected]>
9p/xen : Fix use after free bug in xen_9pfs_front_remove due to race condition

Mark Zhang <[email protected]>
RDMA/cma: Allow UD qp_type to join multicast only

Maher Sanalla <[email protected]>
IB/mlx5: Add support for 400G_8X lane speed

Meir Lichtinger <[email protected]>
IB/mlx5: Add support for NDR link speed

Chunyan Zhang <[email protected]>
clk: sprd: set max_register according to mapping range

Christophe Kerello <[email protected]>
mtd: rawnand: stm32_fmc2: use timings.mode instead of checking tRC_min

Christophe Kerello <[email protected]>
mtd: rawnand: stm32_fmc2: remove unsupported EDO mode

Arseniy Krasnov <[email protected]>
mtd: rawnand: meson: fix bitmask for length in command word

Bang Li <[email protected]>
mtdblock: tolerate corrected bit-flips

Daniel Vetter <[email protected]>
fbmem: Reject FB_ACTIVATE_KD_TEXT from userspace

Christoph Hellwig <[email protected]>
btrfs: fix fast csum implementation detection

David Sterba <[email protected]>
btrfs: print checksum type and implementation at mount time

Min Li <[email protected]>
Bluetooth: Fix race condition in hidp_session_thread

Luiz Augusto von Dentz <[email protected]>
Bluetooth: L2CAP: Fix use-after-free in l2cap_disconnect_{req,rsp}

Oswald Buddenhagen <[email protected]>
ALSA: hda/sigmatel: fix S/PDIF out on Intel D*45* motherboards

Xu Biang <[email protected]>
ALSA: firewire-tascam: add missing unwind goto in snd_tscm_stream_start_duplex()

Oswald Buddenhagen <[email protected]>
ALSA: i2c/cs8427: fix iec958 mixer control deactivation

Oswald Buddenhagen <[email protected]>
ALSA: hda/sigmatel: add pin overrides for Intel DP45SG motherboard

Oswald Buddenhagen <[email protected]>
ALSA: emu10k1: fix capture interrupt handler unlinking

Kornel Dulęba <[email protected]>
Revert "pinctrl: amd: Disable and mask interrupts on resume"

Eduard Zingerman <[email protected]>
bpftool: Print newline before '}' for struct with padding only fields

Heming Zhao <[email protected]>
ocfs2: fix freeing uninitialized resource on ocfs2_dlm_shutdown

Gaosheng Cui <[email protected]>
Revert "media: ti: cal: fix possible memory leak in cal_ctx_create()"

Robert Foss <[email protected]>
drm/bridge: lt9611: Fix PLL being unable to lock

Tommi Rantala <[email protected]>
selftests: intel_pstate: ftime() is deprecated

Rongwei Wang <[email protected]>
mm/swap: fix swap_info_struct race between swapoff and get_swap_pages()

Zheng Yejian <[email protected]>
ring-buffer: Fix race while reader and writer are on the same page

Karol Herbst <[email protected]>
drm/nouveau/disp: Support more modes by checking with lower bpc

Boris Brezillon <[email protected]>
drm/panfrost: Fix the panfrost_mmu_map_fault_addr() error path

Jason Montleon <[email protected]>
ASoC: hdac_hdmi: use set_stream() instead of set_tdm_slots()

Steven Rostedt (Google) <[email protected]>
tracing: Free error logs of tracing instances

Michal Sojka <[email protected]>
can: isotp: isotp_ops: fix poll() to not report false EPOLLOUT events

Oleksij Rempel <[email protected]>
can: j1939: j1939_tp_tx_dat_new(): fix out-of-bounds memory access

Zheng Yejian <[email protected]>
ftrace: Fix issue that 'direct->addr' not restored in modify_ftrace_direct()

John Keeping <[email protected]>
ftrace: Mark get_lock_parent_ip() __always_inline

Kan Liang <[email protected]>
perf/core: Fix the same task check in perf_event_set_output

Zhong Jinghua <[email protected]>
scsi: iscsi_tcp: Check that sock is valid before iscsi_set_param()

Nuno Sá <[email protected]>
iio: adc: ad7791: fix IRQ flags

Jeremy Soller <[email protected]>
ALSA: hda/realtek: Add quirk for Clevo X370SNW

Geert Uytterhoeven <[email protected]>
dt-bindings: serial: renesas,scif: Fix 4th IRQ for 4-IRQ SCIFs

Ryusuke Konishi <[email protected]>
nilfs2: fix sysfs interface lifetime

Ryusuke Konishi <[email protected]>
nilfs2: fix potential UAF of struct nilfs_sc_info in nilfs_segctor_thread()

Sherry Sun <[email protected]>
tty: serial: fsl_lpuart: avoid checking for transfer complete when UARTCTRL_SBK is asserted in lpuart32_tx_empty

Biju Das <[email protected]>
tty: serial: sh-sci: Fix Rx on RZ/G2L SCI

Biju Das <[email protected]>
tty: serial: sh-sci: Fix transmit end interrupt handler

Kai-Heng Feng <[email protected]>
iio: light: cm32181: Unregister second I2C client if present

William Breathitt Gray <[email protected]>
iio: dac: cio-dac: Fix max DAC write value check for 12-bit

Lars-Peter Clausen <[email protected]>
iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip

Bjørn Mork <[email protected]>
USB: serial: option: add Quectel RM500U-CN modem

Enrico Sau <[email protected]>
USB: serial: option: add Telit FE990 compositions

RD Babiera <[email protected]>
usb: typec: altmodes/displayport: Fix configure initial pin assignment

Kees Jan Koster <[email protected]>
USB: serial: cp210x: add Silicon Labs IFS-USB-DATACABLE IDs

D Scott Phillips <[email protected]>
xhci: also avoid the XHCI_ZERO_64B_REGS quirk with a passthrough iommu

Wayne Chang <[email protected]>
usb: xhci: tegra: fix sleep in atomic call

Dai Ngo <[email protected]>
NFSD: callback request does not use correct credential for AUTH_SYS

Jeff Layton <[email protected]>
sunrpc: only free unix grouplist after RCU settles

Corinna Vinschen <[email protected]>
net: stmmac: fix up RX flow hash indirection table when setting channels

Siddharth Vadapalli <[email protected]>
net: ethernet: ti: am65-cpsw: Fix mdio cleanup in probe

Dhruva Gole <[email protected]>
gpio: davinci: Add irq chip flag to skip set wake

Ziyang Xuan <[email protected]>
ipv6: Fix an uninit variable access bug in __ip6_make_skb()

Sricharan Ramabadhran <[email protected]>
net: qrtr: Do not do DEL_SERVER broadcast after DEL_CLIENT

Xin Long <[email protected]>
sctp: check send stream number after wait_for_sndbuf

Jakub Kicinski <[email protected]>
net: don't let netpoll invoke NAPI if in xmit context

Eric Dumazet <[email protected]>
icmp: guard against too small mtu

Ziyang Xuan <[email protected]>
net: qrtr: Fix a refcount bug in qrtr_recvmsg()

Luca Weiss <[email protected]>
net: qrtr: combine nameservice into main module

Felix Fietkau <[email protected]>
wifi: mac80211: fix invalid drv_sta_pre_rcu_remove calls for non-uploaded sta

Nico Boehr <[email protected]>
KVM: s390: pv: fix external interruption loop not always detected

Uwe Kleine-König <[email protected]>
pwm: sprd: Explicitly set .polarity in .get_state()

Uwe Kleine-König <[email protected]>
pwm: cros-ec: Explicitly set .polarity in .get_state()

Mohammed Gamal <[email protected]>
Drivers: vmbus: Check for channel allocation before looking up relids

Randy Dunlap <[email protected]>
gpio: GPIO_REGMAP: select REGMAP instead of depending on it


-------------

Diffstat:

.../devicetree/bindings/serial/renesas,scif.yaml | 4 +-
Documentation/networking/ip-sysctl.rst | 2 +
Documentation/powerpc/associativity.rst | 104 +++++
Documentation/sound/hd-audio/models.rst | 2 +-
Makefile | 12 +-
arch/powerpc/include/asm/firmware.h | 7 +-
arch/powerpc/include/asm/prom.h | 3 +-
arch/powerpc/include/asm/topology.h | 6 +-
arch/powerpc/kernel/prom_init.c | 3 +-
arch/powerpc/mm/numa.c | 433 ++++++++++++++++-----
arch/powerpc/platforms/pseries/firmware.c | 3 +-
arch/powerpc/platforms/pseries/hotplug-cpu.c | 2 +
arch/powerpc/platforms/pseries/hotplug-memory.c | 2 +
arch/powerpc/platforms/pseries/lpar.c | 4 +-
arch/powerpc/platforms/pseries/papr_scm.c | 7 +
arch/riscv/Kconfig | 22 ++
arch/riscv/Makefile | 12 +-
arch/riscv/kernel/signal.c | 9 +-
arch/s390/kvm/intercept.c | 32 +-
arch/x86/kernel/sysfb_efi.c | 8 +
arch/x86/kernel/x86_init.c | 4 +-
arch/x86/pci/fixup.c | 21 +
crypto/asymmetric_keys/pkcs7_verify.c | 10 +-
crypto/asymmetric_keys/verify_pefile.c | 32 +-
drivers/clk/sprd/common.c | 9 +-
drivers/gpio/Kconfig | 2 +-
drivers/gpio/gpio-davinci.c | 2 +-
drivers/gpu/drm/armada/armada_drv.c | 1 -
drivers/gpu/drm/bridge/lontium-lt9611.c | 1 +
drivers/gpu/drm/drm_panel_orientation_quirks.c | 13 +-
drivers/gpu/drm/nouveau/dispnv50/disp.c | 32 ++
drivers/gpu/drm/nouveau/nouveau_dp.c | 8 +-
drivers/gpu/drm/panfrost/panfrost_mmu.c | 1 +
drivers/hv/connection.c | 4 +
drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +-
drivers/i2c/busses/i2c-imx-lpi2c.c | 2 +
drivers/i2c/busses/i2c-ocores.c | 35 +-
drivers/iio/adc/ad7791.c | 2 +-
drivers/iio/adc/ti-ads7950.c | 1 +
drivers/iio/dac/cio-dac.c | 4 +-
drivers/iio/light/cm32181.c | 12 +
drivers/infiniband/core/cma.c | 60 +--
drivers/infiniband/core/verbs.c | 2 +
drivers/infiniband/hw/mlx5/main.c | 16 +
drivers/media/platform/ti-vpe/cal.c | 4 +-
drivers/mtd/mtdblock.c | 12 +-
drivers/mtd/nand/raw/meson_nand.c | 6 +-
drivers/mtd/nand/raw/stm32_fmc2_nand.c | 3 +
drivers/mtd/ubi/build.c | 21 +-
drivers/mtd/ubi/wl.c | 5 +-
drivers/net/ethernet/cadence/macb_main.c | 4 +
drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c | 8 +-
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +-
drivers/net/ethernet/sun/niu.c | 2 +-
drivers/net/ethernet/ti/am65-cpsw-nuss.c | 6 +-
drivers/net/phy/sfp.c | 13 +-
drivers/net/wireless/marvell/mwifiex/pcie.c | 2 +-
drivers/net/wireless/marvell/mwifiex/sdio.c | 2 +-
drivers/pinctrl/pinctrl-amd.c | 36 +-
drivers/power/supply/cros_usbpd-charger.c | 2 +-
drivers/pwm/pwm-cros-ec.c | 1 +
drivers/pwm/pwm-sprd.c | 1 +
drivers/scsi/iscsi_tcp.c | 3 +-
drivers/scsi/ses.c | 20 +-
drivers/tty/serial/fsl_lpuart.c | 8 +-
drivers/tty/serial/sh-sci.c | 10 +-
drivers/usb/host/xhci-tegra.c | 6 +-
drivers/usb/host/xhci.c | 6 +-
drivers/usb/serial/cp210x.c | 1 +
drivers/usb/serial/option.c | 10 +
drivers/usb/typec/altmodes/displayport.c | 6 +-
drivers/video/fbdev/core/fbmem.c | 2 +
drivers/watchdog/sbsa_gwdt.c | 1 +
fs/btrfs/disk-io.c | 17 +
fs/btrfs/super.c | 2 -
fs/nfsd/nfs4callback.c | 4 +-
fs/nilfs2/segment.c | 3 +-
fs/nilfs2/super.c | 2 +
fs/nilfs2/the_nilfs.c | 12 +-
fs/ocfs2/dlmglue.c | 8 +-
fs/ocfs2/super.c | 3 +-
fs/proc/proc_sysctl.c | 6 +
include/linux/ftrace.h | 2 +-
include/linux/kexec.h | 2 +-
include/linux/sysctl.h | 2 +
include/net/netns/ipv4.h | 100 ++---
init/Kconfig | 12 +
kernel/cgroup/cpuset.c | 214 +++++++---
kernel/events/core.c | 2 +-
kernel/kexec.c | 41 +-
kernel/kexec_core.c | 28 +-
kernel/kexec_file.c | 4 +-
kernel/kexec_internal.h | 15 +-
kernel/ksysfs.c | 7 +-
kernel/sched/fair.c | 15 +-
kernel/sysctl.c | 65 ++++
kernel/trace/ftrace.c | 15 +-
kernel/trace/ring_buffer.c | 13 +-
kernel/trace/trace.c | 1 +
mm/swapfile.c | 3 +-
net/9p/trans_xen.c | 4 +
net/bluetooth/hidp/core.c | 2 +-
net/bluetooth/l2cap_core.c | 24 +-
net/can/isotp.c | 17 +-
net/can/j1939/transport.c | 5 +-
net/core/netpoll.c | 19 +-
net/ipv4/icmp.c | 5 +
net/ipv4/sysctl_net_ipv4.c | 203 +++++-----
net/ipv6/ip6_output.c | 7 +-
net/ipv6/udp.c | 8 +-
net/mac80211/sta_info.c | 3 +-
net/qrtr/Makefile | 3 +-
net/qrtr/{qrtr.c => af_qrtr.c} | 15 +
net/qrtr/ns.c | 15 +-
net/sctp/socket.c | 4 +
net/sctp/stream_interleave.c | 3 +-
net/sunrpc/svcauth_unix.c | 17 +-
scripts/Kconfig.include | 6 +
scripts/as-version.sh | 69 ++++
scripts/dummy-tools/gcc | 6 +
sound/firewire/tascam/tascam-stream.c | 2 +-
sound/i2c/cs8427.c | 7 +-
sound/pci/emu10k1/emupcm.c | 4 +-
sound/pci/hda/patch_realtek.c | 1 +
sound/pci/hda/patch_sigmatel.c | 10 +
sound/soc/codecs/hdac_hdmi.c | 17 +-
tools/lib/bpf/btf_dump.c | 11 +-
tools/testing/selftests/intel_pstate/aperf.c | 22 +-
128 files changed, 1652 insertions(+), 615 deletions(-)



2023-04-18 15:19:48

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.10.178 release.
> There are 124 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Following build errors noticed on 5.15 and 5.10.,


> Waiman Long <[email protected]>
> cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem

kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
(first use in this function); did you mean 'cgroup_put'?
2941 | lockdep_assert_held(&cgroup_mutex);
| ^~~~~~~~~~~~

Reported-by: Linux Kernel Functional Testing <[email protected]>

Suspected commit,
cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.


--
Linaro LKFT
https://lkft.linaro.org

2023-04-18 15:36:25

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

On Tue, Apr 18, 2023 at 08:38:47PM +0530, Naresh Kamboju wrote:
> On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > This is the start of the stable review cycle for the 5.10.178 release.
> > There are 124 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Following build errors noticed on 5.15 and 5.10.,
>
>
> > Waiman Long <[email protected]>
> > cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
>

That's a documentation patch, it can not:

> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> (first use in this function); did you mean 'cgroup_put'?
> 2941 | lockdep_assert_held(&cgroup_mutex);

Cause this.

What arch is failing here? This builds for x86.

thanks,

greg k-h

2023-04-18 15:49:26

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

On Tue, 18 Apr 2023 at 21:04, Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Tue, Apr 18, 2023 at 08:38:47PM +0530, Naresh Kamboju wrote:
> > On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> > <[email protected]> wrote:
> > >
> > > This is the start of the stable review cycle for the 5.10.178 release.
> > > There are 124 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Following build errors noticed on 5.15 and 5.10.,
> >
> >
> > > Waiman Long <[email protected]>
> > > cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
> >
>
> That's a documentation patch, it can not:

Sorry for my mistake in trimming the email at the wrong place.

I have pasted down of the email as this suspected patch,

cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.


> > kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> > kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> > (first use in this function); did you mean 'cgroup_put'?
> > 2941 | lockdep_assert_held(&cgroup_mutex);
>
> Cause this.
>
> What arch is failing here? This builds for x86.

Not for me.

List of regression builds.

Regressions found on x86_64:
- build/gcc-12-defconfig

Regressions found on i386:
- build/gcc-12-defconfig
- build/gcc-11-lkftconfig

Regressions found on arm64:
- build/gcc-11-lkftconfig

Regressions found on arm:
- build/gcc-12-vexpress_defconfig
- build/gcc-8-vexpress_defconfig

Regressions found on mips:
- build/gcc-8-defconfig
- build/gcc-12-defconfig


For 5.10 defconfigs failed,
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.176-298-g19b9d9b9f62e/testrun/16291316/suite/build/test/gcc-12-defconfig/history/


For 5.15 defconfigs failed,
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.15.y/build/v5.15.105-280-g0b6a5617247c/testrun/16291199/suite/build/test/gcc-12-defconfig/history/


- Naresh

2023-04-18 16:07:31

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

On 4/18/23 09:45, Naresh Kamboju wrote:
> On Tue, 18 Apr 2023 at 21:04, Greg Kroah-Hartman
> <[email protected]> wrote:
>>
>> On Tue, Apr 18, 2023 at 08:38:47PM +0530, Naresh Kamboju wrote:
>>> On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
>>> <[email protected]> wrote:
>>>>
>>>> This is the start of the stable review cycle for the 5.10.178 release.
>>>> There are 124 patches in this series, all will be posted as a response
>>>> to this one. If anyone has any issues with these being applied, please
>>>> let me know.
>>>>
>>>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>>>> Anything received after that time might be too late.
>>>>
>>>> The whole patch series can be found in one patch at:
>>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
>>>> or in the git tree and branch at:
>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>>>> and the diffstat can be found below.
>>>>
>>>> thanks,
>>>>
>>>> greg k-h
>>>
>>> Following build errors noticed on 5.15 and 5.10.,
>>>
>>>
>>>> Waiman Long <[email protected]>
>>>> cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
>>>
>>
>> That's a documentation patch, it can not:
>
> Sorry for my mistake in trimming the email at the wrong place.
>
> I have pasted down of the email as this suspected patch,
>
> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
>
>
>>> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
>>> kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
>>> (first use in this function); did you mean 'cgroup_put'?
>>> 2941 | lockdep_assert_held(&cgroup_mutex);
>>
>> Cause this.
>>
>> What arch is failing here? This builds for x86.
>
> Not for me.
>
>

It is failing for me on x86_64 with CONFIG_CGROUPS=y
and CONFIG_CGROUP_CPUACCT=y

kernel/cgroup/cpuset.c: In function ‘cpuset_can_fork’:
kernel/cgroup/cpuset.c:2941:30: error: ‘cgroup_mutex’ undeclared (first use in this function); did you mean ‘cgroup_put’?
2941 | lockdep_assert_held(&cgroup_mutex);
| ^~~~~~~~~~~~
./include/linux/lockdep.h:393:61: note: in definition of macro ‘lockdep_assert_held’
393 | #define lockdep_assert_held(l) do { (void)(l); } while (0)
| ^
kernel/cgroup/cpuset.c:2941:30: note: each undeclared identifier is reported only once for each function it appears in
2941 | lockdep_assert_held(&cgroup_mutex);
| ^~~~~~~~~~~~
./include/linux/lockdep.h:393:61: note: in definition of macro ‘lockdep_assert_held’
393 | #define lockdep_assert_held(l) do { (void)(l); } while (0)

thanks,
-- Shuah

2023-04-18 16:42:44

by Harshit Mogalapalli

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

Hi all,

On 18/04/23 9:30 pm, Shuah Khan wrote:
> On 4/18/23 09:45, Naresh Kamboju wrote:
>> On Tue, 18 Apr 2023 at 21:04, Greg Kroah-Hartman
>> <[email protected]> wrote:
>>>
>>> On Tue, Apr 18, 2023 at 08:38:47PM +0530, Naresh Kamboju wrote:
>>>> On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
>>>> <[email protected]> wrote:
>>>>>
>>>>> This is the start of the stable review cycle for the 5.10.178 release.
>>>>> There are 124 patches in this series, all will be posted as a response
>>>>> to this one.  If anyone has any issues with these being applied,
>>>>> please
>>>>> let me know.
>>>>>
>>>>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>>>>> Anything received after that time might be too late.
>>>>>
>>>>> The whole patch series can be found in one patch at:
>>>>>
>>>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
>>>>> or in the git tree and branch at:
>>>>>
>>>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>>>>> and the diffstat can be found below.
>>>>>
>>>>> thanks,
>>>>>
>>>>> greg k-h
>>>>
>>>> Following build errors noticed on 5.15 and 5.10.,
>>>>
>>>>
>>>>> Waiman Long <[email protected]>
>>>>>      cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
>>>>
>>>
>>> That's a documentation patch, it can not:
>>
>> Sorry for my mistake in trimming the email at the wrong place.
>>
>> I have pasted down of the email as this suspected patch,
>>
>> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
>> commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
>>
>>
>>>> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
>>>> kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
>>>> (first use in this function); did you mean 'cgroup_put'?
>>>>   2941 |         lockdep_assert_held(&cgroup_mutex);
>>>
>>> Cause this.
>>>
>>> What arch is failing here?  This builds for x86.
>>
>> Not for me.
>>
>>
>
> It is failing for me on x86_64 with CONFIG_CGROUPS=y
> and CONFIG_CGROUP_CPUACCT=y
>

Added some observations on 5.15.y thread:

https://lore.kernel.org/all/[email protected]/

Thanks,
Harshit

> kernel/cgroup/cpuset.c: In function ‘cpuset_can_fork’:
> kernel/cgroup/cpuset.c:2941:30: error: ‘cgroup_mutex’ undeclared (first
> use in this function); did you mean ‘cgroup_put’?
>  2941 |         lockdep_assert_held(&cgroup_mutex);
>       |                              ^~~~~~~~~~~~
> ./include/linux/lockdep.h:393:61: note: in definition of macro
> ‘lockdep_assert_held’
>   393 | #define lockdep_assert_held(l)                  do { (void)(l);
> } while (0)
>       |                                                             ^
> kernel/cgroup/cpuset.c:2941:30: note: each undeclared identifier is
> reported only once for each function it appears in
>  2941 |         lockdep_assert_held(&cgroup_mutex);
>       |                              ^~~~~~~~~~~~
> ./include/linux/lockdep.h:393:61: note: in definition of macro
> ‘lockdep_assert_held’
>   393 | #define lockdep_assert_held(l)                  do { (void)(l);
> } while (0)
>
> thanks,
> -- Shuah
>

2023-04-18 17:28:07

by Waiman Long

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review


On 4/18/23 11:08, Naresh Kamboju wrote:
> On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> <[email protected]> wrote:
>> This is the start of the stable review cycle for the 5.10.178 release.
>> There are 124 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
> Following build errors noticed on 5.15 and 5.10.,
>
>
>> Waiman Long <[email protected]>
>> cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> (first use in this function); did you mean 'cgroup_put'?
> 2941 | lockdep_assert_held(&cgroup_mutex);
> | ^~~~~~~~~~~~
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> Suspected commit,
> cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.

Oh, cgroup_mutex needs the recent commit 354ed59744295 ("mm: multi-gen
LRU: kill switch") to make it available in include/linux/cgroup.h. I did
my testing with a debug Kconfig and so didn't catch that. This line can
be safely removed.

Regards,
Longman

2023-04-18 18:58:56

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

On 4/18/23 08:34, Greg Kroah-Hartman wrote:
> On Tue, Apr 18, 2023 at 08:38:47PM +0530, Naresh Kamboju wrote:
>> On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
>> <[email protected]> wrote:
>>>
>>> This is the start of the stable review cycle for the 5.10.178 release.
>>> There are 124 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>>
>>> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
>>> Anything received after that time might be too late.
>>>
>>> The whole patch series can be found in one patch at:
>>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
>>> or in the git tree and branch at:
>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>>> and the diffstat can be found below.
>>>
>>> thanks,
>>>
>>> greg k-h
>>
>> Following build errors noticed on 5.15 and 5.10.,
>>
>>
>>> Waiman Long <[email protected]>
>>> cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
>>
>
> That's a documentation patch, it can not:
>
>> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
>> kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
>> (first use in this function); did you mean 'cgroup_put'?
>> 2941 | lockdep_assert_held(&cgroup_mutex);
>
> Cause this.
>
> What arch is failing here? This builds for x86.
>
No, it doesn't.

Build reference: v5.10.177-125-g19b9d9b9f62e
Compiler version: x86_64-linux-gcc (GCC) 11.3.0
Assembler version: GNU assembler (GNU Binutils) 2.39

Building x86_64:defconfig ... failed
--------------
Error log:
In file included from include/linux/rcupdate.h:29,
from include/linux/rculist.h:11,
from include/linux/pid.h:5,
from include/linux/sched.h:14,
from include/linux/ratelimit.h:6,
from include/linux/dev_printk.h:16,
from include/linux/device.h:15,
from include/linux/node.h:18,
from include/linux/cpu.h:17,
from kernel/cgroup/cpuset.c:25:
kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared (first use in this function); did you mean 'cgroup_put'?
2941 | lockdep_assert_held(&cgroup_mutex);
| ^~~~~~~~~~~~
include/linux/lockdep.h:393:61: note: in definition of macro 'lockdep_assert_held'
393 | #define lockdep_assert_held(l) do { (void)(l); } while (0)
| ^
kernel/cgroup/cpuset.c:2941:30: note: each undeclared identifier is reported only once for each function it appears in
2941 | lockdep_assert_held(&cgroup_mutex);
| ^~~~~~~~~~~~
include/linux/lockdep.h:393:61: note: in definition of macro 'lockdep_assert_held'
393 | #define lockdep_assert_held(l) do { (void)(l); } while (0)
| ^
make[3]: *** [scripts/Makefile.build:286: kernel/cgroup/cpuset.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [scripts/Makefile.build:503: kernel/cgroup] Error 2
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:1828: kernel] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:192: __sub-make] Error 2

2023-04-18 19:07:34

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review



On 4/18/2023 5:20 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.178 release.
> There are 124 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:

Tested-by: Florian Fainelli <[email protected]>
--
Florian

2023-04-18 19:36:03

by Tom Saeger

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

On Tue, Apr 18, 2023 at 01:24:12PM -0400, Waiman Long wrote:
>
> On 4/18/23 11:08, Naresh Kamboju wrote:
> > On Tue, 18 Apr 2023 at 18:03, Greg Kroah-Hartman
> > <[email protected]> wrote:
> > > This is the start of the stable review cycle for the 5.10.178 release.
> > > There are 124 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> > Following build errors noticed on 5.15 and 5.10.,
> >
> >
> > > Waiman Long <[email protected]>
> > > cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
> > kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> > kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> > (first use in this function); did you mean 'cgroup_put'?
> > 2941 | lockdep_assert_held(&cgroup_mutex);
> > | ^~~~~~~~~~~~
> >
> > Reported-by: Linux Kernel Functional Testing <[email protected]>
> >
> > Suspected commit,
> > cgroup/cpuset: Add cpuset_can_fork() and cpuset_cancel_fork() methods
> > commit eee87853794187f6adbe19533ed79c8b44b36a91 upstream.
>
> Oh, cgroup_mutex needs the recent commit 354ed59744295 ("mm: multi-gen LRU:
> kill switch") to make it available in include/linux/cgroup.h. I did my
> testing with a debug Kconfig and so didn't catch that. This line can be
> safely removed.
>

I can confirm removing just this line fixed 5.15 x86_64 build for me.
Thanks!

--Tom

2023-04-18 21:28:34

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

Hi!

> > This is the start of the stable review cycle for the 5.10.178 release.
> > There are 124 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.178-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Following build errors noticed on 5.15 and 5.10.,
>
>
> > Waiman Long <[email protected]>
> > cgroup/cpuset: Change references of cpuset_mutex to cpuset_rwsem
>
> kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
> kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared
> (first use in this function); did you mean 'cgroup_put'?
> 2941 | lockdep_assert_held(&cgroup_mutex);
> | ^~~~~~~~~~~~

For the record, we can see the same failure in CIP testing.

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/pipelines/840769270

And it is the only build error I can see in a quick search.

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (1.59 kB)
signature.asc (201.00 B)
Download all attachments

2023-04-19 03:42:04

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 000/124] 5.10.178-rc1 review

On Tue, Apr 18, 2023 at 02:20:19PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.178 release.
> There are 124 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Thu, 20 Apr 2023 12:02:44 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 162 pass: 148 fail: 14
Failed builds:
alpha:allmodconfig
arm:omap2plus_defconfig
arm:vexpress_defconfig
arm64:defconfig
i386:defconfig
ia64:defconfig
mips:defconfig
parisc:allmodconfig
parisc64:generic-64bit_defconfig
powerpc:defconfig
powerpc:ppc64e_defconfig
powerpc:cell_defconfig
s390:defconfig
x86_64:defconfig
Qemu test results:
total: 485 pass: 477 fail: 8
Failed tests:
mipsel64:64r6el_defconfig:notests:nonet:smp:ide:hd
mipsel64:64r6el_defconfig:notests:nonet:smp:ide:hd
mipsel64:64r6el_defconfig:notests:nonet:smp:ide:cd
s390:defconfig:nolocktests:smp2:net,default:initrd
s390:defconfig:nolocktests:smp2:virtio-blk-ccw:net,virtio-net-pci:rootfs
s390:defconfig:nolocktests:smp2:scsi[virtio-ccw]:net,default:rootfs
s390:defconfig:nolocktests:virtio-pci:net,virtio-net-pci:rootfs
s390:defconfig:nolocktests:scsi[virtio-pci]:net,default:rootfs

Caused by:

kernel/cgroup/cpuset.c: In function 'cpuset_can_fork':
kernel/cgroup/cpuset.c:2941:30: error: 'cgroup_mutex' undeclared

Guenter