The bootargs atm contains (generally) two information: console and
earlycon - console is already covered by stdout-path and earlycon is
really meant to be used when debug is needed and not something of a
default to spin out to all users.
This has come up multiple times, so cleaning it all up.
See [1] for context. AM64 is covered in [2]. There are quite a few other
instances of the same in mailing list[3].
Changes since V1:
* No functional changes
* Commit message update to be verbose as to the rationale.
* Picked up Roger's and Krzysztof's acks.
V1: https://lore.kernel.org/all/[email protected]/
[1] https://lore.kernel.org/linux-arm-kernel/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/
[3] https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
Nishanth Menon (5):
arm64: dts: ti: k3-am62x-sk-common: Drop bootargs
arm64: dts: ti: k3-am65*: Drop bootargs
arm64: dts: ti: k3-j721e-*: Drop bootargs
arm64: dts: ti: k3-j7200-common-proc-board: Drop bootargs
arm64: dts: ti: k3-j721s2-common-proc-board: Drop bootargs
arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 1 -
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 1 -
arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 1 -
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 1 -
arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 1 -
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts | 1 -
7 files changed, 7 deletions(-)
--
2.40.0
Drop bootargs from the dts. The console arguments are already covered in
stdout-path property and earlycon is a debug property that should be
enabled only when debug is desired and not as default.
Link: https://lore.kernel.org/linux-arm-kernel/[email protected]/
Suggested-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Roger Quadros <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof
V1: https://lore.kernel.org/r/[email protected]
arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index b4b9edfe2d12..1299c715f34c 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -16,7 +16,6 @@ / {
chosen {
stdout-path = "serial2:115200n8";
- bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,2880000";
};
aliases {
--
2.40.0
Drop bootargs from the dts. The console arguments are already covered in
stdout-path property and earlycon is a debug property that should be
enabled only when debug is desired and not as default.
Link: https://lore.kernel.org/linux-arm-kernel/[email protected]/
Suggested-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Roger Quadros <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof
V1: https://lore.kernel.org/r/[email protected]
arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 0d39d6b8cc0c..5506341aae21 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -17,7 +17,6 @@ / {
chosen {
stdout-path = "serial2:115200n8";
- bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
};
evm_12v0: fixedregulator-evm12v0 {
--
2.40.0
Drop bootargs from the dts. The console arguments are already covered in
stdout-path property and earlycon is a debug property that should be
enabled only when debug is desired and not as default.
Link: https://lore.kernel.org/linux-arm-kernel/[email protected]/
Suggested-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Roger Quadros <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof
V1: https://lore.kernel.org/r/[email protected]
arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
index 976f8303c84f..a61e8648f189 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-common.dtsi
@@ -25,7 +25,6 @@ aliases {
chosen {
stdout-path = "serial2:115200n8";
- bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
};
memory@80000000 {
--
2.40.0
Drop bootargs from the dts. The console arguments are already covered in
stdout-path property and earlycon is a debug property that should be
enabled only when debug is desired and not as default.
Link: https://lore.kernel.org/linux-arm-kernel/[email protected]/
Suggested-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Roger Quadros <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof
V1: https://lore.kernel.org/r/[email protected]
arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts | 1 -
arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 7db0603125aa..c11c092c1ce0 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -17,7 +17,6 @@ / {
chosen {
stdout-path = "serial2:115200n8";
- bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
};
gpio_keys: gpio-keys {
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index f650a7fd66b4..ad7b45aeed0a 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -18,7 +18,6 @@ / {
chosen {
stdout-path = "serial2:115200n8";
- bootargs = "console=ttyS2,115200n8 earlycon=ns16550a,mmio32,0x02800000";
};
memory@80000000 {
--
2.40.0
Drop bootargs from the dts. earlycon is a debug property that should be
enabled only when debug is desired and not as default - see referenced
link on discussion on this topic.
Cc: Jan Kiszka <[email protected]>
Link: https://lore.kernel.org/linux-arm-kernel/[email protected]/
Suggested-by: Krzysztof Kozlowski <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Roger Quadros <[email protected]>
Signed-off-by: Nishanth Menon <[email protected]>
---
Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
Changes since v1:
- improved commit message
- picked up acks and reviews from Roger and Krzysztof
V1: https://lore.kernel.org/r/[email protected]
arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 1 -
arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
2 files changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
index 96ac2b476b11..7d256a1638ff 100644
--- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
@@ -21,7 +21,6 @@ aliases {
chosen {
stdout-path = "serial3:115200n8";
- bootargs = "earlycon=ns16550a,mmio32,0x02810000";
};
reserved-memory {
diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index 592ab2b54cb3..0d6fc89eba7a 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -15,7 +15,6 @@ / {
chosen {
stdout-path = "serial2:115200n8";
- bootargs = "earlycon=ns16550a,mmio32,0x02800000";
};
memory@80000000 {
--
2.40.0
On 19.04.23 16:12, Nishanth Menon wrote:
> Drop bootargs from the dts. earlycon is a debug property that should be
> enabled only when debug is desired and not as default - see referenced
> link on discussion on this topic.
>
> Cc: Jan Kiszka <[email protected]>
> Link: https://lore.kernel.org/linux-arm-kernel/[email protected]/
> Suggested-by: Krzysztof Kozlowski <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Roger Quadros <[email protected]>
> Signed-off-by: Nishanth Menon <[email protected]>
> ---
> Similar discussions can be seen in https://lore.kernel.org/linux-devicetree/?q=Krzysztof+bootargs
>
> Changes since v1:
> - improved commit message
> - picked up acks and reviews from Roger and Krzysztof
>
> V1: https://lore.kernel.org/r/[email protected]
>
> arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 1 -
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index 96ac2b476b11..7d256a1638ff 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -21,7 +21,6 @@ aliases {
>
> chosen {
> stdout-path = "serial3:115200n8";
> - bootargs = "earlycon=ns16550a,mmio32,0x02810000";
> };
>
> reserved-memory {
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 592ab2b54cb3..0d6fc89eba7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -15,7 +15,6 @@ / {
>
> chosen {
> stdout-path = "serial2:115200n8";
> - bootargs = "earlycon=ns16550a,mmio32,0x02800000";
> };
>
> memory@80000000 {
For the IOT2050:
Acked-by: Jan Kiszka <[email protected]>
Jan
--
Siemens AG, Technology
Competence Center Embedded Linux
Hi Nishanth Menon,
On Wed, 19 Apr 2023 09:12:17 -0500, Nishanth Menon wrote:
> The bootargs atm contains (generally) two information: console and
> earlycon - console is already covered by stdout-path and earlycon is
> really meant to be used when debug is needed and not something of a
> default to spin out to all users.
>
> This has come up multiple times, so cleaning it all up.
> See [1] for context. AM64 is covered in [2]. There are quite a few other
> instances of the same in mailing list[3].
>
> [...]
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/5] arm64: dts: ti: k3-am62x-sk-common: Drop bootargs
commit: d525ef9c7f077bfa8202b4b47ca9242ab936a1dc
[2/5] arm64: dts: ti: k3-am65*: Drop bootargs
commit: da4159a776593f802ee211ad4823f3aed31e5375
[3/5] arm64: dts: ti: k3-j721e-*: Drop bootargs
commit: af2cda7df7769d3353170b6a72d73bc4ea703480
[4/5] arm64: dts: ti: k3-j7200-common-proc-board: Drop bootargs
commit: f920c49f1e46a99c410e2aaf486ffb7ce3d12270
[5/5] arm64: dts: ti: k3-j721s2-common-proc-board: Drop bootargs
commit: cf82a026f54f54c241903add9b9bdbeb2a449db0
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh