LinuxLists.cc - [PATCH v3] firewire: init_ohci1394_dma: use correct function names in comments

2023-04-10 01:41:55

Subject: [PATCH v3] firewire: init_ohci1394_dma: use correct function names in comments

Prevent kernel-doc complaints by using the correct function names in
kernel-doc comments:

drivers/firewire/init_ohci1394_dma.c:258: warning: expecting prototype for debug_init_ohci1394_dma(). Prototype was for init_ohci1394_dma_on_all_controllers() instead
drivers/firewire/init_ohci1394_dma.c:289: warning: expecting prototype for setup_init_ohci1394_early(). Prototype was for setup_ohci1394_dma() instead

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Stefan Richter <[email protected]>
Cc: [email protected]
Cc: Andrew Morton <[email protected]>
Cc: Takashi Sakamoto <[email protected]>
---
v2: rebase/resend, add note to Andrew
v3: add Takashi-san

drivers/firewire/init_ohci1394_dma.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff -- a/drivers/firewire/init_ohci1394_dma.c b/drivers/firewire/init_ohci1394_dma.c
--- a/drivers/firewire/init_ohci1394_dma.c
+++ b/drivers/firewire/init_ohci1394_dma.c
@@ -251,7 +251,7 @@ static inline void __init init_ohci1394_
}

/**
- * debug_init_ohci1394_dma - scan for OHCI1394 controllers and init DMA on them
+ * init_ohci1394_dma_on_all_controllers - scan for OHCI1394 controllers and init DMA on them
* Scans the whole PCI space for OHCI1394 controllers and inits DMA on them
*/
void __init init_ohci1394_dma_on_all_controllers(void)
@@ -283,7 +283,7 @@ void __init init_ohci1394_dma_on_all_con
}

/**
- * setup_init_ohci1394_early - enables early OHCI1394 DMA initialization
+ * setup_ohci1394_dma - enables early OHCI1394 DMA initialization
*/
static int __init setup_ohci1394_dma(char *opt)
{

2023-04-11 00:06:33

by Takashi Sakamoto

[permalink] [raw]

Subject: Re: [PATCH v3] firewire: init_ohci1394_dma: use correct function names in comments

On Sun, Apr 09, 2023 at 06:13:06PM -0700, Randy Dunlap wrote:
> Prevent kernel-doc complaints by using the correct function names in
> kernel-doc comments:
>
> drivers/firewire/init_ohci1394_dma.c:258: warning: expecting prototype for debug_init_ohci1394_dma(). Prototype was for init_ohci1394_dma_on_all_controllers() instead
> drivers/firewire/init_ohci1394_dma.c:289: warning: expecting prototype for setup_init_ohci1394_early(). Prototype was for setup_ohci1394_dma() instead
>
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Stefan Richter <[email protected]>
> Cc: [email protected]
> Cc: Andrew Morton <[email protected]>
> Cc: Takashi Sakamoto <[email protected]>
> ---
> v2: rebase/resend, add note to Andrew
> v3: add Takashi-san
>
> drivers/firewire/init_ohci1394_dma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Thank you to remind it to me.

Acked-by: Takashi Sakamoto <[email protected]>

By the way, I got enough access permission to linux1394.git repository
and I'm preparing it for maintenance work (not done yet).

* https://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394.git/

After finishing the preparation (e.g. joining to linux-next integration),
I'll apply your patch and tell it to you, within the week.

> diff -- a/drivers/firewire/init_ohci1394_dma.c b/drivers/firewire/init_ohci1394_dma.c
> --- a/drivers/firewire/init_ohci1394_dma.c
> +++ b/drivers/firewire/init_ohci1394_dma.c
> @@ -251,7 +251,7 @@ static inline void __init init_ohci1394_
> }
>
> /**
> - * debug_init_ohci1394_dma - scan for OHCI1394 controllers and init DMA on them
> + * init_ohci1394_dma_on_all_controllers - scan for OHCI1394 controllers and init DMA on them
> * Scans the whole PCI space for OHCI1394 controllers and inits DMA on them
> */
> void __init init_ohci1394_dma_on_all_controllers(void)
> @@ -283,7 +283,7 @@ void __init init_ohci1394_dma_on_all_con
> }
>
> /**
> - * setup_init_ohci1394_early - enables early OHCI1394 DMA initialization
> + * setup_ohci1394_dma - enables early OHCI1394 DMA initialization
> */
> static int __init setup_ohci1394_dma(char *opt)
> {

Kind regards

Takashi Sakamoto

2023-04-20 16:05:51

by Takashi Sakamoto

[permalink] [raw]