2023-04-07 17:14:00

by Jean Delvare

Subject: [PATCH RESEND] PCI: xilinx: Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

Signed-off-by: Jean Delvare <[email protected]>
Cc: Lorenzo Pieralisi <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: "Krzysztof Wilczyński" <[email protected]>
Cc: Bjorn Helgaas <[email protected]>
---
Resending as the context changed so my original submission no longer
applies cleanly.

drivers/pci/controller/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-6.0.orig/drivers/pci/controller/Kconfig
+++ linux-6.0/drivers/pci/controller/Kconfig
@@ -98,7 +98,7 @@ config PCI_HOST_GENERIC

config PCIE_XILINX
bool "Xilinx AXI PCIe host bridge support"
- depends on OF || COMPILE_TEST
+ depends on OF
depends on PCI_MSI
help
Say 'Y' here if you want kernel to support the Xilinx AXI PCIe


--
Jean Delvare
SUSE L3 Support

2023-04-20 19:20:31

by Bjorn Helgaas

Subject: Re: [PATCH RESEND] PCI: xilinx: Drop obsolete dependency on COMPILE_TEST

On Fri, Apr 07, 2023 at 07:08:43PM +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Lorenzo Pieralisi <[email protected]>
> Cc: Rob Herring <[email protected]>
> Cc: "Krzysztof Wilczyński" <[email protected]>
> Cc: Bjorn Helgaas <[email protected]>

Thanks, Jean, applied to pci/controller/kconfig for v6.4.

> ---
> Resending as the context changed so my original submission no longer
> applies cleanly.
>
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-6.0.orig/drivers/pci/controller/Kconfig
> +++ linux-6.0/drivers/pci/controller/Kconfig
> @@ -98,7 +98,7 @@ config PCI_HOST_GENERIC
>
> config PCIE_XILINX
> bool "Xilinx AXI PCIe host bridge support"
> - depends on OF || COMPILE_TEST
> + depends on OF
> depends on PCI_MSI
> help
> Say 'Y' here if you want kernel to support the Xilinx AXI PCIe
>
>
> --
> Jean Delvare
> SUSE L3 Support