2023-04-24 10:21:31

by Wu Yunchuan

[permalink] [raw]
Subject: [PATCH] net: phy: dp83867: Remove unnecessary (void*) conversions

Pointer variables of void * type do not require type cast.

Signed-off-by: wuych <[email protected]>
---
drivers/net/phy/dp83867.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c
index 89cd821f1f46..03b2ef1bf3dc 100644
--- a/drivers/net/phy/dp83867.c
+++ b/drivers/net/phy/dp83867.c
@@ -468,8 +468,7 @@ static int dp83867_set_tunable(struct phy_device *phydev,

static int dp83867_config_port_mirroring(struct phy_device *phydev)
{
- struct dp83867_private *dp83867 =
- (struct dp83867_private *)phydev->priv;
+ struct dp83867_private *dp83867 = phydev->priv;

if (dp83867->port_mirroring == DP83867_PORT_MIRROING_EN)
phy_set_bits_mmd(phydev, DP83867_DEVADDR, DP83867_CFG4,
--
2.30.2


2023-04-24 11:17:54

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH] net: phy: dp83867: Remove unnecessary (void*) conversions

On Mon, Apr 24, 2023 at 06:15:50PM +0800, wuych wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych <[email protected]>
> ---
> drivers/net/phy/dp83867.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>

2023-04-24 12:08:17

by Andrew Lunn

[permalink] [raw]
Subject: Re: [PATCH] net: phy: dp83867: Remove unnecessary (void*) conversions

On Mon, Apr 24, 2023 at 06:15:50PM +0800, wuych wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2023-04-25 01:25:51

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH] net: phy: dp83867: Remove unnecessary (void*) conversions

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 24 Apr 2023 18:15:50 +0800 you wrote:
> Pointer variables of void * type do not require type cast.
>
> Signed-off-by: wuych <[email protected]>
> ---
> drivers/net/phy/dp83867.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
- net: phy: dp83867: Remove unnecessary (void*) conversions
https://git.kernel.org/netdev/net-next/c/86c2b51f203e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html