2023-04-26 18:30:31

by Stanislav Jakubek

Subject: [PATCH] dt-bindings: timer: brcm,kona-timer: convert to YAML

Convert Broadcom Kona family timer bindings to DT schema.

Signed-off-by: Stanislav Jakubek <[email protected]>
---
.../bindings/timer/brcm,kona-timer.txt | 25 ---------
.../bindings/timer/brcm,kona-timer.yaml | 55 +++++++++++++++++++
2 files changed, 55 insertions(+), 25 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/timer/brcm,kona-timer.txt
create mode 100644 Documentation/devicetree/bindings/timer/brcm,kona-timer.yaml

diff --git a/Documentation/devicetree/bindings/timer/brcm,kona-timer.txt b/Documentation/devicetree/bindings/timer/brcm,kona-timer.txt
deleted file mode 100644
index 39adf54b4388..000000000000
--- a/Documentation/devicetree/bindings/timer/brcm,kona-timer.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-Broadcom Kona Family timer
------------------------------------------------------
-This timer is used in the following Broadcom SoCs:
- BCM11130, BCM11140, BCM11351, BCM28145, BCM28155
-
-Required properties:
-- compatible : "brcm,kona-timer"
-- DEPRECATED: compatible : "bcm,kona-timer"
-- reg : Register range for the timer
-- interrupts : interrupt for the timer
-- clocks: phandle + clock specifier pair of the external clock
-- clock-frequency: frequency that the clock operates
-
-Only one of clocks or clock-frequency should be specified.
-
-Refer to clocks/clock-bindings.txt for generic clock consumer properties.
-
-Example:
- timer@35006000 {
- compatible = "brcm,kona-timer";
- reg = <0x35006000 0x1000>;
- interrupts = <0x0 7 0x4>;
- clocks = <&hub_timer_clk>;
- };
-
diff --git a/Documentation/devicetree/bindings/timer/brcm,kona-timer.yaml b/Documentation/devicetree/bindings/timer/brcm,kona-timer.yaml
new file mode 100644
index 000000000000..579a8e190c10
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/brcm,kona-timer.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/brcm,kona-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom Kona family timer
+
+maintainers:
+ - Florian Fainelli <[email protected]>
+
+properties:
+ compatible:
+ oneOf:
+ - const: brcm,kona-timer
+ - const: bcm,kona-timer
+ deprecated: true
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ clock-frequency: true
+
+oneOf:
+ - required:
+ - clocks
+ - required:
+ - clock-frequency
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include "dt-bindings/clock/bcm281xx.h"
+
+ timer@35006000 {
+ compatible = "brcm,kona-timer";
+ reg = <0x35006000 0x1000>;
+ interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&aon_ccu BCM281XX_AON_CCU_HUB_TIMER>;
+ };
+...
--
2.25.1

2023-04-27 17:16:19

by Florian Fainelli

Subject: Re: [PATCH] dt-bindings: timer: brcm,kona-timer: convert to YAML

On 4/27/23 09:58, Rob Herring wrote:
>
> On Wed, 26 Apr 2023 20:28:54 +0200, Stanislav Jakubek wrote:
>> Convert Broadcom Kona family timer bindings to DT schema.
>>
>> Signed-off-by: Stanislav Jakubek <[email protected]>
>> ---
>> .../bindings/timer/brcm,kona-timer.txt | 25 ---------
>> .../bindings/timer/brcm,kona-timer.yaml | 55 +++++++++++++++++++
>> 2 files changed, 55 insertions(+), 25 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/timer/brcm,kona-timer.txt
>> create mode 100644 Documentation/devicetree/bindings/timer/brcm,kona-timer.yaml
>>
>
> Reviewed-by: Rob Herring <[email protected]>
>
Rob, do you want me to take this patch, or will you take it via the DT tree?
--
Florian

2023-04-27 17:16:22

by Rob Herring (Arm)

Subject: Re: [PATCH] dt-bindings: timer: brcm,kona-timer: convert to YAML

On Wed, 26 Apr 2023 20:28:54 +0200, Stanislav Jakubek wrote:
> Convert Broadcom Kona family timer bindings to DT schema.
>
> Signed-off-by: Stanislav Jakubek <[email protected]>
> ---
> .../bindings/timer/brcm,kona-timer.txt | 25 ---------
> .../bindings/timer/brcm,kona-timer.yaml | 55 +++++++++++++++++++
> 2 files changed, 55 insertions(+), 25 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/timer/brcm,kona-timer.txt
> create mode 100644 Documentation/devicetree/bindings/timer/brcm,kona-timer.yaml
>

Reviewed-by: Rob Herring <[email protected]>