2023-04-24 07:01:56

by Christophe JAILLET

Subject: [PATCH] mfd: rc5t583-irq: Remove the unneeded include <linux/i2c.h>

This driver does not use i2c, so there is no point in including
<linux/i2c.h>

Remove it and add the needed <linux/device.h> instead, which is much more
lightweight.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/mfd/rc5t583-irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rc5t583-irq.c b/drivers/mfd/rc5t583-irq.c
index 621ea61fa7c6..97f52b671520 100644
--- a/drivers/mfd/rc5t583-irq.c
+++ b/drivers/mfd/rc5t583-irq.c
@@ -8,9 +8,9 @@
* based on code
* Copyright (C) 2011 RICOH COMPANY,LTD
*/
+#include <linux/device.h>
#include <linux/interrupt.h>
#include <linux/irq.h>
-#include <linux/i2c.h>
#include <linux/mfd/rc5t583.h>

enum int_type {
--
2.34.1

2023-04-27 16:43:10

by Lee Jones

Subject: Re: [PATCH] mfd: rc5t583-irq: Remove the unneeded include <linux/i2c.h>

On Mon, 24 Apr 2023, Christophe JAILLET wrote:

> This driver does not use i2c, so there is no point in including
> <linux/i2c.h>
>
> Remove it and add the needed <linux/device.h> instead, which is much more
> lightweight.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---
> drivers/mfd/rc5t583-irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]