2023-04-27 19:02:58

by Martin Kaiser

Subject: [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return

Remove a return statement at the end of a void function.

This fixes a checkpatch warning.

WARNING: void function return statements are not generally useful
6206: FILE: ./drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:6206:
+ return;
+}

Signed-off-by: Martin Kaiser <[email protected]>
---
drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index fd8c8c6d53d6..7e7bb11231e3 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -6281,7 +6281,6 @@ static void rtl8xxxu_rx_complete(struct urb *urb)
cleanup:
usb_free_urb(urb);
dev_kfree_skb(skb);
- return;
}

static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv,
--
2.30.2

2023-04-28 00:23:55

by Ping-Ke Shih

Subject: RE: [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return

> -----Original Message-----
> From: Martin Kaiser <[email protected]>
> Sent: Friday, April 28, 2023 3:00 AM
> To: Jes Sorensen <[email protected]>; Kalle Valo <[email protected]>; David S. Miller
> <[email protected]>; Eric Dumazet <[email protected]>; Jakub Kicinski <[email protected]>; Paolo Abeni
> <[email protected]>
> Cc: Martin Kaiser <[email protected]>; [email protected]; [email protected];
> [email protected]
> Subject: [PATCH] wifi: rtl8xxxu: (trivial) remove unnecessary return
>
> Remove a return statement at the end of a void function.
>
> This fixes a checkpatch warning.
>
> WARNING: void function return statements are not generally useful
> 6206: FILE: ./drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:6206:
> + return;
> +}
>
> Signed-off-by: Martin Kaiser <[email protected]>

Reviewed-by: Ping-Ke Shih <[email protected]>

> ---
> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index fd8c8c6d53d6..7e7bb11231e3 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -6281,7 +6281,6 @@ static void rtl8xxxu_rx_complete(struct urb *urb)
> cleanup:
> usb_free_urb(urb);
> dev_kfree_skb(skb);
> - return;
> }
>
> static int rtl8xxxu_submit_rx_urb(struct rtl8xxxu_priv *priv,
> --
> 2.30.2