2023-04-28 09:26:15

by Deming Wang

[permalink] [raw]
Subject: [PATCH] Documentation/translations/ja_JP/SubmittingPatches: fix some typos

Fix of typos spotted reading documentation in Japanese.

Signed-off-by: Deming Wang <[email protected]>
---
Documentation/translations/ja_JP/SubmittingPatches | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/translations/ja_JP/SubmittingPatches b/Documentation/translations/ja_JP/SubmittingPatches
index 04deb77b20c6..5334db471744 100644
--- a/Documentation/translations/ja_JP/SubmittingPatches
+++ b/Documentation/translations/ja_JP/SubmittingPatches
@@ -450,7 +450,7 @@ Reviewed-by: タグは、それとは異なり、下記のレビューア宣言
状況においてその宣言した目的や機能が正しく実現することに関して、
いかなる保証もしない(特にどこかで明示しない限り)。

-Reviewd-by タグはそのパッチがカーネルに対して適切な修正であって、深刻な技術的
+Reviewed-by タグはそのパッチがカーネルに対して適切な修正であって、深刻な技術的
問題を残していないという意見の宣言です。興味のあるレビューアは誰でも(レビュー
作業を終えたら)パッチに対して Reviewed-by タグを提示できます。このタグは
レビューアの寄与をクレジットする働き、レビューの進捗の度合いをメンテナに
--
2.27.0


2023-04-28 14:46:56

by Akira Yokosawa

[permalink] [raw]
Subject: Re: [PATCH] Documentation/translations/ja_JP/SubmittingPatches: fix some typos

[-CC: Kosuke]

Hi,

On Fri, 28 Apr 2023 05:10:18 -0400, Deming Wang wrote:
> Fix of typos spotted reading documentation in Japanese.
>
> Signed-off-by: Deming Wang <[email protected]>
> ---
> Documentation/translations/ja_JP/SubmittingPatches | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
[...]

Your patch is rejected by "git am".

In the header part of your email, I see these fields:

> X-Mailer: git-send-email 2.31.1
> MIME-Version: 1.0
> Content-Type: text/plain; charset="y"
> Content-Transfer-Encoding: 8bit

This looks broken.
Please make sure your email header has a proper Content-Type
as shown below:

Content-Type: text/plain; charset=UTF-8

Thanks, Akira



2023-04-28 14:53:36

by Jonathan Corbet

[permalink] [raw]
Subject: Re: [PATCH] Documentation/translations/ja_JP/SubmittingPatches: fix some typos

Akira Yokosawa <[email protected]> writes:

> Your patch is rejected by "git am".
>
> In the header part of your email, I see these fields:
>
>> X-Mailer: git-send-email 2.31.1
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset="y"
>> Content-Transfer-Encoding: 8bit
>
> This looks broken.
> Please make sure your email header has a proper Content-Type
> as shown below:
>
> Content-Type: text/plain; charset=UTF-8

This something that git send-email does on occasion; it's truly
obnoxious, and I have no idea why. I end up fixing up patches by hand
when I see it. If the change itself is OK, I can manage it from here.

Thanks,

jon

2023-04-28 15:22:01

by Akira Yokosawa

[permalink] [raw]
Subject: Re: [PATCH] Documentation/translations/ja_JP/SubmittingPatches: fix some typos

On Fri, 28 Apr 2023 08:50:41 -0600, Jonathan Corbet wrote:
> Akira Yokosawa <[email protected]> writes:
>
>> Your patch is rejected by "git am".
>>
>> In the header part of your email, I see these fields:
>>
>>> X-Mailer: git-send-email 2.31.1
>>> MIME-Version: 1.0
>>> Content-Type: text/plain; charset="y"
>>> Content-Transfer-Encoding: 8bit
>>
>> This looks broken.
>> Please make sure your email header has a proper Content-Type
>> as shown below:
>>
>> Content-Type: text/plain; charset=UTF-8
>
> This something that git send-email does on occasion; it's truly
> obnoxious, and I have no idea why. I end up fixing up patches by hand
> when I see it. If the change itself is OK, I can manage it from here.

The change looks OK.

Reviewed-by: Akira Yokosawa <[email protected]>

Thanks, Akira

>
> Thanks,
>
> jon

2023-04-28 16:52:55

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH] Documentation/translations/ja_JP/SubmittingPatches: fix some typos

On Fri, Apr 28, 2023 at 08:50:41AM -0600, Jonathan Corbet wrote:
> Akira Yokosawa <[email protected]> writes:
>
> > Your patch is rejected by "git am".
> >
> > In the header part of your email, I see these fields:
> >
> >> X-Mailer: git-send-email 2.31.1
> >> MIME-Version: 1.0
> >> Content-Type: text/plain; charset="y"
> >> Content-Transfer-Encoding: 8bit
> >
> > This looks broken.
> > Please make sure your email header has a proper Content-Type
> > as shown below:
> >
> > Content-Type: text/plain; charset=UTF-8
>
> This something that git send-email does on occasion; it's truly
> obnoxious, and I have no idea why.

If you have special characters in your patch/cover, git send-email will
prompt you to declare a encoding. The message is something like:

| The following files are 8bit, but do not declare a Content-Transfer-Encoding.
| 0000-cover-letter.patch
| Which 8bit encoding should I declare [UTF-8]?

It's very easy to assume that pressing y to accept UTF-8 is the right
thing to do, rather than pressing enter for the default.


Attachments:
(No filename) (1.05 kB)
signature.asc (235.00 B)
Download all attachments