2023-04-28 13:10:31

by Shazad Hussain

Subject: [PATCH v2 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P

Add the compatible string for SA8775P SoC from Qualcomm.

Signed-off-by: Shazad Hussain <[email protected]>
---
.../devicetree/bindings/usb/qcom,dwc3.yaml | 21 +++++++++++++++++++
1 file changed, 21 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index d84281926f10..4a36e2b6c8fb 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -23,6 +23,7 @@ properties:
- qcom,msm8998-dwc3
- qcom,qcm2290-dwc3
- qcom,qcs404-dwc3
+ - qcom,sa8775p-dwc3
- qcom,sc7180-dwc3
- qcom,sc7280-dwc3
- qcom,sc8280xp-dwc3
@@ -180,6 +181,7 @@ allOf:
- qcom,msm8953-dwc3
- qcom,msm8996-dwc3
- qcom,msm8998-dwc3
+ - qcom,sa8775p-dwc3
- qcom,sc7180-dwc3
- qcom,sc7280-dwc3
- qcom,sdm670-dwc3
@@ -455,6 +457,25 @@ allOf:
- const: dm_hs_phy_irq
- const: ss_phy_irq

+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sa8775p-dwc3
+ then:
+ properties:
+ interrupts:
+ minItems: 3
+ maxItems: 4
+ interrupt-names:
+ minItems: 3
+ items:
+ - const: pwr_event
+ - const: dp_hs_phy_irq
+ - const: dm_hs_phy_irq
+ - const: ss_phy_irq
+
additionalProperties: false

examples:
--
2.17.1

2023-04-28 13:48:16

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P

On 28/04/2023 15:08, Shazad Hussain wrote:
> Add the compatible string for SA8775P SoC from Qualcomm.
>
> Signed-off-by: Shazad Hussain <[email protected]>
> ---

(...)

> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sa8775p-dwc3
> + then:
> + properties:
> + interrupts:
> + minItems: 3
> + maxItems: 4
> + interrupt-names:
> + minItems: 3
> + items:
> + - const: pwr_event
> + - const: dp_hs_phy_irq
> + - const: dm_hs_phy_irq
> + - const: ss_phy_irq

Why the last interrupt line is optional? Is it really optional?

Best regards,
Krzysztof

2023-04-28 14:10:21

by Shazad Hussain

Subject: Re: [PATCH v2 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P

Hi Krzysztof,

On 4/28/2023 6:57 PM, Krzysztof Kozlowski wrote:
> On 28/04/2023 15:08, Shazad Hussain wrote:
>> Add the compatible string for SA8775P SoC from Qualcomm.
>>
>> Signed-off-by: Shazad Hussain <[email protected]>
>> ---
>
> (...)
>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sa8775p-dwc3
>> + then:
>> + properties:
>> + interrupts:
>> + minItems: 3
>> + maxItems: 4
>> + interrupt-names:
>> + minItems: 3
>> + items:
>> + - const: pwr_event
>> + - const: dp_hs_phy_irq
>> + - const: dm_hs_phy_irq
>> + - const: ss_phy_irq
>
> Why the last interrupt line is optional? Is it really optional?
>

Third usb controller i.e usb_2 supports only high speed, so I believe
ss_phy_irq is not required for that instance.

> Best regards,
> Krzysztof
>

-Shazad

2023-05-01 06:44:09

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P

On 28/04/2023 15:08, Shazad Hussain wrote:
> Add the compatible string for SA8775P SoC from Qualcomm.
>
> Signed-off-by: Shazad Hussain <[email protected]>
> ---


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof