2023-04-28 16:06:33

by Jianhua Lu

[permalink] [raw]
Subject: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example

The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
And update example to make it clear.

Signed-off-by: Jianhua Lu <[email protected]>
---
.../leds/backlight/kinetic,ktz8866.yaml | 29 ++++++++++++-------
1 file changed, 19 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
index e1191453c2f0..6ec40cce3f11 100644
--- a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
@@ -21,6 +21,9 @@ properties:
compatible:
const: kinetic,ktz8866

+ reg:
+ maxItems: 1
+
vddpos-supply:
description: positive boost supply regulator.

@@ -53,6 +56,7 @@ properties:

required:
- compatible
+ - reg
- vddpos-supply
- vddneg-supply
- enable-gpios
@@ -63,14 +67,19 @@ examples:
- |
#include <dt-bindings/gpio/gpio.h>

- backlight {
- compatible = "kinetic,ktz8866";
-
- vddpos-supply = <&bl_vddpos_5p5>;
- vddneg-supply = <&bl_vddneg_5p5>;
- enable-gpios = <&tlmm 139 GPIO_ACTIVE_HIGH>;
- current-num-sinks = <5>;
- kinetic,current-ramp-delay-ms = <128>;
- kinetic,led-enable-ramp-delay-ms = <1>;
- kinetic,enable-lcd-bias;
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ backlight@11 {
+ compatible = "kinetic,ktz8866";
+ reg = <0x11>;
+ vddpos-supply = <&bl_vddpos_5p5>;
+ vddneg-supply = <&bl_vddneg_5p5>;
+ enable-gpios = <&tlmm 139 GPIO_ACTIVE_HIGH>;
+ current-num-sinks = <5>;
+ kinetic,current-ramp-delay-ms = <128>;
+ kinetic,led-enable-ramp-delay-ms = <1>;
+ kinetic,enable-lcd-bias;
+ };
};
--
2.39.2


2023-05-01 07:21:44

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example

On 28/04/2023 18:02, Jianhua Lu wrote:
> The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
> And update example to make it clear.
>
> Signed-off-by: Jianhua Lu <[email protected]>
> ---


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-05-02 11:19:31

by Daniel Thompson

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example

On Sat, Apr 29, 2023 at 12:02:46AM +0800, Jianhua Lu wrote:
> The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
> And update example to make it clear.
>
> Signed-off-by: Jianhua Lu <[email protected]>

Reviewed-by: Daniel Thompson <[email protected]>

2023-05-15 13:33:39

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: leds: backlight: ktz8866: Add reg property and update example

On Sat, 29 Apr 2023, Jianhua Lu wrote:

> The kinetic,ktz8866 is a I2C driver, so add the missing reg property.
> And update example to make it clear.
>
> Signed-off-by: Jianhua Lu <[email protected]>
> ---
> .../leds/backlight/kinetic,ktz8866.yaml | 29 ++++++++++++-------
> 1 file changed, 19 insertions(+), 10 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]