2023-05-01 00:46:22

by Randy Dunlap

Subject: [PATCH] accessibility: use C99 array init

Use C99 array initializer syntax for consistency with other array
initializers around it and to eliminate a sparse warning:

drivers/accessibility/speakup/main.c:1290:26: sparse: warning: obsolete array initializer, use C99 syntax

Fixes: f43241aafedb ("accessibility: speakup: Specify spk_vars among module parameters")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mushahid Hussain <[email protected]>
Cc: William Hubbs <[email protected]>
Cc: Chris Brannon <[email protected]>
Cc: Kirk Reiser <[email protected]>
Cc: Samuel Thibault <[email protected]>
Cc: [email protected]
Cc: Greg Kroah-Hartman <[email protected]>
---
drivers/accessibility/speakup/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff -- a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
--- a/drivers/accessibility/speakup/main.c
+++ b/drivers/accessibility/speakup/main.c
@@ -1287,7 +1287,7 @@ static struct var_t spk_vars[NB_ID] = {
[PUNC_LEVEL_ID] = { PUNC_LEVEL, .u.n = {NULL, 1, 0, 4, 0, 0, NULL} },
[READING_PUNC_ID] = { READING_PUNC, .u.n = {NULL, 1, 0, 4, 0, 0, NULL} },
[CURSOR_TIME_ID] = { CURSOR_TIME, .u.n = {NULL, 120, 50, 600, 0, 0, NULL} },
- [SAY_CONTROL_ID] { SAY_CONTROL, TOGGLE_0},
+ [SAY_CONTROL_ID] = { SAY_CONTROL, TOGGLE_0},
[SAY_WORD_CTL_ID] = {SAY_WORD_CTL, TOGGLE_0},
[NO_INTERRUPT_ID] = { NO_INTERRUPT, TOGGLE_0},
[KEY_ECHO_ID] = { KEY_ECHO, .u.n = {NULL, 1, 0, 2, 0, 0, NULL} },

2023-05-01 02:04:58

by Samuel Thibault

Subject: Re: [PATCH] accessibility: use C99 array init

Randy Dunlap, le dim. 30 avril 2023 17:16:17 -0700, a ecrit:
> Use C99 array initializer syntax for consistency with other array
> initializers around it and to eliminate a sparse warning:
>
> drivers/accessibility/speakup/main.c:1290:26: sparse: warning: obsolete array initializer, use C99 syntax
>
> Fixes: f43241aafedb ("accessibility: speakup: Specify spk_vars among module parameters")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mushahid Hussain <[email protected]>
> Cc: William Hubbs <[email protected]>
> Cc: Chris Brannon <[email protected]>
> Cc: Kirk Reiser <[email protected]>
> Cc: Samuel Thibault <[email protected]>
> Cc: [email protected]
> Cc: Greg Kroah-Hartman <[email protected]>

Reviewed-by: Samuel Thibault <[email protected]>

Thanks!

> ---
> drivers/accessibility/speakup/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -- a/drivers/accessibility/speakup/main.c b/drivers/accessibility/speakup/main.c
> --- a/drivers/accessibility/speakup/main.c
> +++ b/drivers/accessibility/speakup/main.c
> @@ -1287,7 +1287,7 @@ static struct var_t spk_vars[NB_ID] = {
> [PUNC_LEVEL_ID] = { PUNC_LEVEL, .u.n = {NULL, 1, 0, 4, 0, 0, NULL} },
> [READING_PUNC_ID] = { READING_PUNC, .u.n = {NULL, 1, 0, 4, 0, 0, NULL} },
> [CURSOR_TIME_ID] = { CURSOR_TIME, .u.n = {NULL, 120, 50, 600, 0, 0, NULL} },
> - [SAY_CONTROL_ID] { SAY_CONTROL, TOGGLE_0},
> + [SAY_CONTROL_ID] = { SAY_CONTROL, TOGGLE_0},
> [SAY_WORD_CTL_ID] = {SAY_WORD_CTL, TOGGLE_0},
> [NO_INTERRUPT_ID] = { NO_INTERRUPT, TOGGLE_0},
> [KEY_ECHO_ID] = { KEY_ECHO, .u.n = {NULL, 1, 0, 2, 0, 0, NULL} },
>