Changes since v1:
----------------
- v1 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Changed the commit log for [PATCH 2/2] as per Rob's observation.
This patchset targets some cleanups for the EUD dt nodes present
in sc7280.dtsi and also adds a missing space in the compatible string
in the example used in eud dt-binding document.
Bhupesh Sharma (2):
arm64: dts: qcom: sc7280: Fix EUD dt node syntax
dt-bindings: soc: qcom: eud: Fix compatible string in the example
.../bindings/soc/qcom/qcom,eud.yaml | 4 ++-
arch/arm64/boot/dts/qcom/sc7280.dtsi | 36 +++++++++----------
2 files changed, 21 insertions(+), 19 deletions(-)
--
2.38.1
As noted by Konrad while reviewing [1], fix the EUD and DWC3
node syntax in sc7280 dtsi file.
While at it also fix the errors reported by '$ make dtbs_check'
for the EUD node:
arch/arm64/boot/dts/qcom/sc7280-crd-r3.dtb: eud@88e0000: ports:
'oneOf' conditional failed, one must be fixed:
'port' is a required property
'#address-cells' is a required property
'#size-cells' is a required property
From schema: Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
[1]. https://lore.kernel.org/linux-arm-msm/[email protected]
Signed-off-by: Bhupesh Sharma <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 36 ++++++++++++++--------------
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 31728f461422..e441b1d6cad3 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -640,6 +640,18 @@ cpu7_opp_3014mhz: opp-3014400000 {
};
};
+ eud_typec: connector {
+ compatible = "usb-c-connector";
+
+ ports {
+ port@0 {
+ con_eud: endpoint {
+ remote-endpoint = <&eud_con>;
+ };
+ };
+ };
+ };
+
memory@80000000 {
device_type = "memory";
/* We expect the bootloader to fill in the size */
@@ -3421,6 +3433,7 @@ usb_2_dwc3: usb@8c00000 {
phy-names = "usb2-phy";
maximum-speed = "high-speed";
usb-role-switch;
+
port {
usb2_role_switch: endpoint {
remote-endpoint = <&eud_ep>;
@@ -3596,10 +3609,11 @@ system-cache-controller@9200000 {
};
eud: eud@88e0000 {
- compatible = "qcom,sc7280-eud","qcom,eud";
- reg = <0 0x088e0000 0 0x2000>,
- <0 0x088e2000 0 0x1000>;
+ compatible = "qcom,sc7280-eud", "qcom,eud";
+ reg = <0 0x88e0000 0 0x2000>,
+ <0 0x88e2000 0 0x1000>;
interrupts-extended = <&pdc 11 IRQ_TYPE_LEVEL_HIGH>;
+
ports {
#address-cells = <1>;
#size-cells = <0>;
@@ -3610,6 +3624,7 @@ eud_ep: endpoint {
remote-endpoint = <&usb2_role_switch>;
};
};
+
port@1 {
reg = <1>;
eud_con: endpoint {
@@ -3619,21 +3634,6 @@ eud_con: endpoint {
};
};
- eud_typec: connector {
- compatible = "usb-c-connector";
- ports {
- #address-cells = <1>;
- #size-cells = <0>;
-
- port@0 {
- reg = <0>;
- con_eud: endpoint {
- remote-endpoint = <&eud_con>;
- };
- };
- };
- };
-
nsp_noc: interconnect@a0c0000 {
reg = <0 0x0a0c0000 0 0x10000>;
compatible = "qcom,sc7280-nsp-noc";
--
2.38.1
As noted by Konrad while reviewing [1], the example node in the EUD
yaml documentation has a compatible string with no space after a comma.
Fix the same.
[1]. https://lore.kernel.org/linux-arm-msm/[email protected]
Signed-off-by: Bhupesh Sharma <[email protected]>
---
Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
index 14dd29471c80..f2c5ec7e6437 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,eud.yaml
@@ -55,9 +55,10 @@ additionalProperties: false
examples:
- |
eud@88e0000 {
- compatible = "qcom,sc7280-eud","qcom,eud";
+ compatible = "qcom,sc7280-eud", "qcom,eud";
reg = <0x88e0000 0x2000>,
<0x88e2000 0x1000>;
+
ports {
#address-cells = <1>;
#size-cells = <0>;
@@ -67,6 +68,7 @@ examples:
remote-endpoint = <&usb2_role_switch>;
};
};
+
port@1 {
reg = <1>;
eud_con: endpoint {
--
2.38.1
On 02/05/2023 11:39, Bhupesh Sharma wrote:
> As noted by Konrad while reviewing [1], the example node in the EUD
> yaml documentation has a compatible string with no space after a comma.
>
> Fix the same.
>
> [1]. https://lore.kernel.org/linux-arm-msm/[email protected]
>
> Signed-off-by: Bhupesh Sharma <[email protected]>
> ---
Acked-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Tue, 2 May 2023 15:09:57 +0530, Bhupesh Sharma wrote:
> Changes since v1:
> ----------------
> - v1 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
> - Changed the commit log for [PATCH 2/2] as per Rob's observation.
>
> This patchset targets some cleanups for the EUD dt nodes present
> in sc7280.dtsi and also adds a missing space in the compatible string
> in the example used in eud dt-binding document.
>
> [...]
Applied, thanks!
[2/2] dt-bindings: soc: qcom: eud: Fix compatible string in the example
commit: 6ade5ce20c466298c04b10fe66091b9055aa9988
Best regards,
--
Bjorn Andersson <[email protected]>