2023-05-04 09:08:18

by Tobias Klauser

Subject: [PATCH] selftests/clone3: test clone3 with exit signal in flags

Verify that calling clone3 with an exit signal (SIGCHLD) in flags will
fail.

Signed-off-by: Tobias Klauser <[email protected]>
---
tools/testing/selftests/clone3/clone3.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c
index e495f895a2cd..e60cf4da8fb0 100644
--- a/tools/testing/selftests/clone3/clone3.c
+++ b/tools/testing/selftests/clone3/clone3.c
@@ -129,7 +129,7 @@ int main(int argc, char *argv[])
uid_t uid = getuid();

ksft_print_header();
- ksft_set_plan(18);
+ ksft_set_plan(19);
test_clone3_supported();

/* Just a simple clone3() should return 0.*/
@@ -198,5 +198,8 @@ int main(int argc, char *argv[])
/* Do a clone3() in a new time namespace */
test_clone3(CLONE_NEWTIME, 0, 0, CLONE3_ARGS_NO_TEST);

+ /* Do a clone3() with exit signal (SIGCHLD) in flags */
+ test_clone3(SIGCHLD, 0, -EINVAL, CLONE3_ARGS_NO_TEST);
+
ksft_finished();
}
--
2.40.0

2023-05-04 11:25:03

by Christian Brauner

Subject: Re: [PATCH] selftests/clone3: test clone3 with exit signal in flags

On Thu, May 04, 2023 at 10:59:30AM +0200, Tobias Klauser wrote:
> Verify that calling clone3 with an exit signal (SIGCHLD) in flags will
> fail.
>
> Signed-off-by: Tobias Klauser <[email protected]>
> ---

Thanks. Should probably go through the selftest tree,
Reviewed-by: Christian Brauner <[email protected]>