2023-04-03 21:49:34

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Introducing bugbot

Hi, all:

Per our discussion last fall, I've been working on a bridge between bugzilla
and public-inbox, which went live in the past few days. It's still a very
early release, but it can do the following:

1. Create bugs from mailing list discussions, with full history. For example,
it is sufficient for someone [1] to say "bugbot on" in a mailing list
discussion to request bugbot to convert that thread into a new bug. It will
then continue checking that thread for new messages, creating new comments
for any added communication. This works both ways -- any comments added on
bugzilla will be sent as follow-up messages to the original recipients.

New bugs will be created in the Linux/Kernel component of Bugzilla, but
they can then be reassigned to any other component. As long as they remain
open, bugbot will continue tracking threads for new messages until either
the bug is closed, or it has been over 30 days since any activity on the
bug.

[1] At this time, the From address of the person saying "bugbot on" has to
have an account on bugzilla and be part of the "editbugs" group.

Here's me using it to turn a thread into a bug:
https://lore.kernel.org/lkml/CAJfuBxwomDagbdNP-Q6WvzcWsNY0Z2Lu2Yy5aZQ1d9W7Ka1_NQ@mail.gmail.com/

2. Start mailing list threads from pre-triaged bugzilla bugs. This works the
opposite way and creates mailing list threads based on bug reports filed in
bugzilla. The useful things here are:

- bugbot only gets triggered on open bugs in Linux/Kernel that have the
"bugbot" flag set to "+", which allows pre-triaging a bug before bugbot
sends it to the mailing list
- there is a special "cf_subsystem" field added to that component; bugbot
will match it verbatim to the MAINTAINERS file components and will send
mail to the M: and L: addresses for that subsystem
- bugbot will then monitor for any updates to that thread, so any mailing
list replies will be added as comments to the bug (thus sending a
bugzilla mail notification to the initial author)
- if the cf_subsystem is incorrect, it can be changed to a different
subsystem at any time, triggering a different set of recipients on the
next update
- any files added in bugzilla will trigger notification sent to the list
(but won't attach the actual files, so they don't clog everyone's mailbox
or list archives)

Artem, I'm not sure if you're still active with bugzilla.kernel.org, but I
believe the cf_subsystem functionality is pretty much what you wanted so it
was possible to bring bugs to the attention of actual subsystem
maintainers.

Here is a bug that was turned into a mailing list thread via cf_subsystem:
https://bugzilla.kernel.org/show_bug.cgi?id=217293

Like I said, bugbot is very young and probably full of bugs, so it will still
see a lot of change and will likely explode a couple of times. The code behind
it is here, woefully lacking any documentation as yet:
https://git.kernel.org/pub/scm/utils/peebz/peebz.git/

At this time, I invite anyone with an account on bugzilla and "editbugs" group
membership can start using bugbot in either direction and to report any bugs
you find to the tools list.

Next features on my todo list are:

- documentation
- tracking repositories and recording when bugs are mentioned in commits
- whatever other feedback I receive

Best regards,
Konstantin


2023-04-03 21:49:56

by Kernel.org Bugbot

[permalink] [raw]
Subject: Re: Introducing bugbot

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=217297

There is no need to do anything else, just keep talking.
--
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

2023-04-03 21:52:59

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: Introducing bugbot

On Mon, Apr 03, 2023 at 09:47:49PM +0000, Kernel.org Bugbot wrote:
> Hello:
>
> This conversation is now tracked by Kernel.org Bugzilla:
> https://bugzilla.kernel.org/show_bug.cgi?id=217297
>
> There is no need to do anything else, just keep talking.

Thank you for illustrating the "may explode" bits. :)

Unfortunately, triggering on key phrases means it gets triggered when you're
discussing key phrases. I'll make sure that this only happens when the key
phrase is on the line by itself.

-K

2023-04-04 06:01:02

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Introducing bugbot

On 03.04.23 23:45, Konstantin Ryabitsev wrote:
>
> Per our discussion last fall, I've been working on a bridge between bugzilla
> and public-inbox, which went live in the past few days. It's still a very
> early release, but it can do the following:

thx for working on this.

> New bugs will be created in the Linux/Kernel component of Bugzilla, but
> they can then be reassigned to any other component. As long as they remain
> open, bugbot will continue tracking threads for new messages until either
> the bug is closed, or it has been over 30 days since any activity on the
> bug.

30 days from my experience sounds too short for me (but I have no hard
numbers to back this up). I would have gone for 90 days, but I guess
that would create too much load?

> [...]
> 2. Start mailing list threads from pre-triaged bugzilla bugs. This works the
> opposite way and creates mailing list threads based on bug reports filed in
> bugzilla. The useful things here are:
>
> - bugbot only gets triggered on open bugs in Linux/Kernel that have the
> "bugbot" flag set to "+", which allows pre-triaging a bug before bugbot
> sends it to the mailing list
> - there is a special "cf_subsystem" field added to that component; bugbot
> will match it verbatim to the MAINTAINERS file components and will send
> mail to the M: and L: addresses for that subsystem
> - bugbot will then monitor for any updates to that thread, so any mailing
> list replies will be added as comments to the bug (thus sending a
> bugzilla mail notification to the initial author)
> [...]

Would be great if bugbot could CC the regressions list for all bugs that
have the regressions flag set to "yes"

How does one make bugbot forward a bug to everyone in the signed-off-by
chain of a commit that caused a regression, which might or might not
have a bugzilla account? When the reporter performed a bisection these
are the primary contacts that need to be reached out to, but the
maintainers and lists for the subsystem obviously should be CCed.

Ciao, Thorsten

2023-04-04 07:03:51

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: Introducing bugbot

On Tue, Apr 4, 2023 at 8:03 AM Thorsten Leemhuis <[email protected]> wrote:
> On 03.04.23 23:45, Konstantin Ryabitsev wrote:
> > Per our discussion last fall, I've been working on a bridge between bugzilla
> > and public-inbox, which went live in the past few days. It's still a very
> > early release, but it can do the following:
>
> thx for working on this.

Thx indeed, looks nice!

> > New bugs will be created in the Linux/Kernel component of Bugzilla, but
> > they can then be reassigned to any other component. As long as they remain
> > open, bugbot will continue tracking threads for new messages until either
> > the bug is closed, or it has been over 30 days since any activity on the
> > bug.
>
> 30 days from my experience sounds too short for me (but I have no hard
> numbers to back this up). I would have gone for 90 days, but I guess
> that would create too much load?

30 < release cycle (9..10 weeks) < 90, so 90 days sounds better to me.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-04-04 08:18:30

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: Introducing bugbot

On Tue, Apr 04, 2023 at 07:58:40AM +0200, Thorsten Leemhuis wrote:
> How does one make bugbot forward a bug to everyone in the signed-off-by
> chain of a commit that caused a regression, which might or might not
> have a bugzilla account? When the reporter performed a bisection these
> are the primary contacts that need to be reached out to, but the
> maintainers and lists for the subsystem obviously should be CCed.

The logic should be similar as on finding commit signers in
get_maintainer.pl.

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (572.00 B)
signature.asc (235.00 B)
Download all attachments

2023-04-04 12:37:52

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: Introducing bugbot

On Tue, Apr 04, 2023 at 07:58:40AM +0200, Thorsten Leemhuis wrote:
> Would be great if bugbot could CC the regressions list for all bugs that
> have the regressions flag set to "yes"

I'll see if I can add this logic and make it configurable.

> How does one make bugbot forward a bug to everyone in the signed-off-by
> chain of a commit that caused a regression, which might or might not
> have a bugzilla account? When the reporter performed a bisection these
> are the primary contacts that need to be reached out to, but the
> maintainers and lists for the subsystem obviously should be CCed.

I can add a cf_bisected_commit field that can take a commit-id. When gathering
recipients, we can check if we know that commit in one of the tracked
repositories, and get the author field out of it. Would that be sufficient, or
do we need to run get_maintainer on it for a full picture?

Note, that you can also add addresses to Cc: on the thread -- they will be
collected behind the scenes as each message is processed and any bugbot
notifications originating from the bugzilla side will also include them.

-K

2023-04-04 13:11:25

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Introducing bugbot

On 04.04.23 14:36, Konstantin Ryabitsev wrote:
> On Tue, Apr 04, 2023 at 07:58:40AM +0200, Thorsten Leemhuis wrote:
>> Would be great if bugbot could CC the regressions list for all bugs that
>> have the regressions flag set to "yes"
> I'll see if I can add this logic and make it configurable.

great, thx!

>> How does one make bugbot forward a bug to everyone in the signed-off-by
>> chain of a commit that caused a regression, which might or might not
>> have a bugzilla account? When the reporter performed a bisection these
>> are the primary contacts that need to be reached out to, but the
>> maintainers and lists for the subsystem obviously should be CCed.
>
> I can add a cf_bisected_commit field that can take a commit-id. When gathering
> recipients, we can check if we know that commit in one of the tracked
> repositories, and get the author field out of it. Would that be sufficient,

Nearly, as mentioned above: it should be everybody in the signed-off-by
chain (as explained in reporting-issues.rst), as that will catch
co-developers and the people that handled the change on the way.

> or do we need to run get_maintainer on it for a full picture?

The normal magic you described that bugbot applies to match reports to
subsystems is also needed, as otherwise lists and co-maintainer would
not be in the loop.

> Note, that you can also add addresses to Cc: on the thread -- they will be
> collected behind the scenes as each message is processed and any bugbot
> notifications originating from the bugzilla side will also include them.

That's good to know and likely will be handy sometimes, but well, for
regular use of the bugzilla->mailing list use-case it would be slightly
annoying if you'd first have to tell bugzilla to create a ml thread,
which you then need to find to write a reply to add people to the CC.

Ciao, Thorsten

2023-04-04 16:31:00

by Artem S. Tashkinov

[permalink] [raw]
Subject: Re: Introducing bugbot

On 4/3/23 21:45, Konstantin Ryabitsev wrote:
> Hi, all:
>
> Per our discussion last fall, I've been working on a bridge between bugzilla
> and public-inbox, which went live in the past few days. It's still a very
> early release, but it can do the following:
>
> 1. Create bugs from mailing list discussions, with full history. For example,
> it is sufficient for someone [1] to say "bugbot on" in a mailing list
> discussion to request bugbot to convert that thread into a new bug. It will
> then continue checking that thread for new messages, creating new comments
> for any added communication. This works both ways -- any comments added on
> bugzilla will be sent as follow-up messages to the original recipients.
>
> New bugs will be created in the Linux/Kernel component of Bugzilla, but
> they can then be reassigned to any other component. As long as they remain
> open, bugbot will continue tracking threads for new messages until either
> the bug is closed, or it has been over 30 days since any activity on the
> bug.
>
> [1] At this time, the From address of the person saying "bugbot on" has to
> have an account on bugzilla and be part of the "editbugs" group.
>
> Here's me using it to turn a thread into a bug:
> https://lore.kernel.org/lkml/CAJfuBxwomDagbdNP-Q6WvzcWsNY0Z2Lu2Yy5aZQ1d9W7Ka1_NQ@mail.gmail.com/
>
> 2. Start mailing list threads from pre-triaged bugzilla bugs. This works the
> opposite way and creates mailing list threads based on bug reports filed in
> bugzilla. The useful things here are:
>
> - bugbot only gets triggered on open bugs in Linux/Kernel that have the
> "bugbot" flag set to "+", which allows pre-triaging a bug before bugbot
> sends it to the mailing list
> - there is a special "cf_subsystem" field added to that component; bugbot
> will match it verbatim to the MAINTAINERS file components and will send
> mail to the M: and L: addresses for that subsystem
> - bugbot will then monitor for any updates to that thread, so any mailing
> list replies will be added as comments to the bug (thus sending a
> bugzilla mail notification to the initial author)
> - if the cf_subsystem is incorrect, it can be changed to a different
> subsystem at any time, triggering a different set of recipients on the
> next update
> - any files added in bugzilla will trigger notification sent to the list
> (but won't attach the actual files, so they don't clog everyone's mailbox
> or list archives)
>
> Artem, I'm not sure if you're still active with bugzilla.kernel.org, but I
> believe the cf_subsystem functionality is pretty much what you wanted so it
> was possible to bring bugs to the attention of actual subsystem
> maintainers.
>
> Here is a bug that was turned into a mailing list thread via cf_subsystem:
> https://bugzilla.kernel.org/show_bug.cgi?id=217293
>
> Like I said, bugbot is very young and probably full of bugs, so it will still
> see a lot of change and will likely explode a couple of times. The code behind
> it is here, woefully lacking any documentation as yet:
> https://git.kernel.org/pub/scm/utils/peebz/peebz.git/
>
> At this time, I invite anyone with an account on bugzilla and "editbugs" group
> membership can start using bugbot in either direction and to report any bugs
> you find to the tools list.
>
> Next features on my todo list are:
>
> - documentation
> - tracking repositories and recording when bugs are mentioned in commits
> - whatever other feedback I receive
>
> Best regards,
> Konstantin

Hello Konstantin,

I love everything about what you've done except I've got a minor feature
request for the kernel bugzilla and this new workflow specifically.

Let's have a bot which polls open bug reports every 3-6 months with this
question:

"Is this still an issue in the current kernel? Please leave a comment or
this bug report will be closed due to inactivity".

By doing this we could make the bugzilla a whole more relevant and
effective tool instead of having a ton of bug reports no one cares about
or can even confirm.

I would only exclude the bug reports of type "Enhancement".

Best regards,
Artem

2023-04-04 17:55:46

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: Introducing bugbot

On Tue, Apr 04, 2023 at 04:16:08PM +0000, Artem S. Tashkinov wrote:
> I love everything about what you've done except I've got a minor feature
> request for the kernel bugzilla and this new workflow specifically.

Great to hear.

> Let's have a bot which polls open bug reports every 3-6 months with this
> question:
>
> "Is this still an issue in the current kernel? Please leave a comment or
> this bug report will be closed due to inactivity".

I plan to do it slightly differently -- there will be a "housekeeping" command
running daily that will auto-close bugs that haven't seen any activity for a
defined period (90 days, for example), with a message like:

"This bug is now closed due to inactivity. Please reopen if this issue is
still relevant with the latest kernel version."

> By doing this we could make the bugzilla a whole more relevant and effective
> tool instead of having a ton of bug reports no one cares about or can even
> confirm.
>
> I would only exclude the bug reports of type "Enhancement".

I wouldn't, because these aren't bugs and shouldn't be filed in bugzilla. I
would just advise the person who opened the bug where they should send an
email with their ideas and then close with "RESOLVED/MOVED".

-K

2023-04-04 17:56:43

by Mark Brown

[permalink] [raw]
Subject: Re: Introducing bugbot

On Tue, Apr 04, 2023 at 04:16:08PM +0000, Artem S. Tashkinov wrote:

> Let's have a bot which polls open bug reports every 3-6 months with this
> question:

> "Is this still an issue in the current kernel? Please leave a comment or
> this bug report will be closed due to inactivity".

> By doing this we could make the bugzilla a whole more relevant and effective
> tool instead of having a ton of bug reports no one cares about or can even
> confirm.

> I would only exclude the bug reports of type "Enhancement".

An explicit flag to disable would also be useful if this is done at all,
these bots exceptionally frustrating with trivially reproducible issues
that don't require special hardware or anything.


Attachments:
(No filename) (728.00 B)
signature.asc (499.00 B)
Download all attachments

2023-04-04 21:42:02

by David Sterba

[permalink] [raw]
Subject: Re: Introducing bugbot

On Tue, Apr 04, 2023 at 01:35:34PM -0400, Konstantin Ryabitsev wrote:
> On Tue, Apr 04, 2023 at 04:16:08PM +0000, Artem S. Tashkinov wrote:
> > I love everything about what you've done except I've got a minor feature
> > request for the kernel bugzilla and this new workflow specifically.
>
> Great to hear.
>
> > Let's have a bot which polls open bug reports every 3-6 months with this
> > question:
> >
> > "Is this still an issue in the current kernel? Please leave a comment or
> > this bug report will be closed due to inactivity".
>
> I plan to do it slightly differently -- there will be a "housekeeping" command
> running daily that will auto-close bugs that haven't seen any activity for a
> defined period (90 days, for example), with a message like:
>
> "This bug is now closed due to inactivity. Please reopen if this issue is
> still relevant with the latest kernel version."

Will there be a way to opt out of this? I'd rather see any bug closed
after an inspection from a human, I find the auto-close messages a bit
rude and I've read similar sentiment from others. The upstream bugzilla
is a best-effort level of support so it's true that bugs are left open
for months, sometimes years unfortunately, but I've seen many cases where
the report is valid or the "fix" is to improve documentation.

If we had enough people routinely going through the reports then some
sort of reminders would make sense but we don't. I take the bug
reports a task pool if there aren't more pressing things to do, which
may not be the same way how others use bugzilla.k.org so I'd be fine
with opting out of the auto-close or maybe out of any bugbot
interactions.

2023-04-08 12:25:59

by Thorsten Leemhuis

[permalink] [raw]
Subject: Re: Introducing bugbot

CCing Kalle (JFYI)

On 03.04.23 23:45, Konstantin Ryabitsev wrote:
>
> 2. Start mailing list threads from pre-triaged bugzilla bugs. This works the
> opposite way and creates mailing list threads based on bug reports filed in
> bugzilla. The useful things here are:
>
> - bugbot only gets triggered on open bugs in Linux/Kernel that have the
> "bugbot" flag set to "+", which allows pre-triaging a bug before bugbot
> sends it to the mailing list
> [...]

Are there any policies or best practices on how people should/are
allowed to use this? From what I can see it seems one needs to change
the Product/Component of the bug to start a thread. I wonder if a few
maintainers that are active in bugzilla might be annoyed by this, as
that might break their workflow.

Which puts me in an awkward position when I see regressions reports in
bugzilla and would like to create threads for them. Using bugbot would
be better then the manual forwards I do now, like this one:

https://lore.kernel.org/all/[email protected]/


But here I decided to *not* use bugbot, as I know Kalle sometimes is
active in bugzilla -- and thus might hate it, if I re-categorize the bug.

Ciao, Thorsten

2023-04-12 12:30:26

by Kalle Valo

[permalink] [raw]
Subject: Re: Introducing bugbot

Thorsten Leemhuis <[email protected]> writes:

> CCing Kalle (JFYI)
>
> On 03.04.23 23:45, Konstantin Ryabitsev wrote:
>>
>> 2. Start mailing list threads from pre-triaged bugzilla bugs. This works the
>> opposite way and creates mailing list threads based on bug reports filed in
>> bugzilla. The useful things here are:
>>
>> - bugbot only gets triggered on open bugs in Linux/Kernel that have the
>> "bugbot" flag set to "+", which allows pre-triaging a bug before bugbot
>> sends it to the mailing list
>> [...]
>
> Are there any policies or best practices on how people should/are
> allowed to use this? From what I can see it seems one needs to change
> the Product/Component of the bug to start a thread. I wonder if a few
> maintainers that are active in bugzilla might be annoyed by this, as
> that might break their workflow.
>
> Which puts me in an awkward position when I see regressions reports in
> bugzilla and would like to create threads for them. Using bugbot would
> be better then the manual forwards I do now, like this one:
>
> https://lore.kernel.org/all/[email protected]/
>
> But here I decided to *not* use bugbot, as I know Kalle sometimes is
> active in bugzilla -- and thus might hate it, if I re-categorize the bug.

Yeah, for me moving ath11k bugs away from Drivers/network-wireless
component is not really helpful. And for ath11k I try to look at all
reported bugs in bugzilla anyway, though just slowly.

While at it, I have some things on my wishlist to make my use of
bugzilla.kernel.org easier:

* A new state named UNCONFIRMED and have it as the default state for
reported bugs. This would help triaging bugs as some of the reports
are not valid. In other words only valid bugs would have NEW state.
IIRC the Mozilla project did this back in the day.

* Use P3 as the default priority for the new bugs. I try to keep ath11k
bugs in priority order but new reported bugs having P1 always messes
up the list always.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-04-12 14:13:47

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: Introducing bugbot

On Wed, Apr 12, 2023 at 03:23:25PM +0300, Kalle Valo wrote:
> > But here I decided to *not* use bugbot, as I know Kalle sometimes is
> > active in bugzilla -- and thus might hate it, if I re-categorize the bug.
>
> Yeah, for me moving ath11k bugs away from Drivers/network-wireless
> component is not really helpful. And for ath11k I try to look at all
> reported bugs in bugzilla anyway, though just slowly.

Right, I did mean to say that the bot is only limited to Linux/Kernel during
the initial tryout stage. Once I'm more confident that it's not exploding and
mostly doing the right thing, I can enable it for other components.

> While at it, I have some things on my wishlist to make my use of
> bugzilla.kernel.org easier:
>
> * A new state named UNCONFIRMED and have it as the default state for
> reported bugs. This would help triaging bugs as some of the reports
> are not valid. In other words only valid bugs would have NEW state.
> IIRC the Mozilla project did this back in the day.

This is more hairy than it looks, but I'll try to figure out what happened to
the UNCONFIRMED state in our bugzilla.

> * Use P3 as the default priority for the new bugs. I try to keep ath11k
> bugs in priority order but new reported bugs having P1 always messes
> up the list always.

Okay, I set the default to P3, which is nicely in the middle.

-K

2023-04-12 16:51:11

by Kalle Valo

[permalink] [raw]
Subject: Re: Introducing bugbot

Konstantin Ryabitsev <[email protected]> writes:

> On Wed, Apr 12, 2023 at 03:23:25PM +0300, Kalle Valo wrote:
>
>> While at it, I have some things on my wishlist to make my use of
>> bugzilla.kernel.org easier:
>>
>> * A new state named UNCONFIRMED and have it as the default state for
>> reported bugs. This would help triaging bugs as some of the reports
>> are not valid. In other words only valid bugs would have NEW state.
>> IIRC the Mozilla project did this back in the day.
>
> This is more hairy than it looks, but I'll try to figure out what happened to
> the UNCONFIRMED state in our bugzilla.

I can only imagine how difficult bugzilla can to administer. So if it's
too hairy to get UNCONFIRMED working again don't use too much on it.
This is more like a nice to have feature, not a critical thing.

>> * Use P3 as the default priority for the new bugs. I try to keep ath11k
>> bugs in priority order but new reported bugs having P1 always messes
>> up the list always.
>
> Okay, I set the default to P3, which is nicely in the middle.

Nice, thanks!

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2023-05-05 16:14:45

by Jakub Kicinski

[permalink] [raw]
Subject: Re: Introducing bugbot

On Mon, 3 Apr 2023 17:45:31 -0400 Konstantin Ryabitsev wrote:
> Hi, all:
>
> Per our discussion last fall, I've been working on a bridge between bugzilla
> and public-inbox, which went live in the past few days. It's still a very
> early release, but it can do the following:

What about closing the bugs once they had been fixed/triaged/proven
invalid?

2023-05-05 19:22:59

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: Introducing bugbot

On Fri, May 05, 2023 at 08:52:18AM -0700, Jakub Kicinski wrote:
> > Per our discussion last fall, I've been working on a bridge between bugzilla
> > and public-inbox, which went live in the past few days. It's still a very
> > early release, but it can do the following:
>
> What about closing the bugs once they had been fixed/triaged/proven
> invalid?

For now, bugbot can look at a branch in a git repo and close bugs when it sees
a matching "Closes:" trailer.

-K

2023-05-05 19:49:54

by Konstantin Ryabitsev

[permalink] [raw]
Subject: Re: Introducing bugbot

On Fri, May 05, 2023 at 12:32:26PM -0700, Jakub Kicinski wrote:
> Interesting. Obviously that assumes the bug needs a fix, and we're
> talking bugzilla so lots of clueless people lobbing non-issues at us.

This is why anyone can create a bug on bugzilla, but only a subset of people
can enable bugbot on it (by setting the bugbot+ flag).

> But also - Closes: is a legit trailer now? I thought we only allow Link:

It's a semi-legit trailer and is going through -next:
https://docs.kernel.org/next/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

> In any case - I'm guessing I just don't have permissions to close the
> issues via web. Is your preference to iterate on the bot or maintainers
> to request permissions in BZ (how?)?

Yes, it's not a power granted by default, but people just need to ask.
You should have this awesome power now.

-K

2023-05-05 19:51:29

by Jakub Kicinski

[permalink] [raw]
Subject: Re: Introducing bugbot

On Fri, 5 May 2023 15:12:02 -0400 Konstantin Ryabitsev wrote:
> On Fri, May 05, 2023 at 08:52:18AM -0700, Jakub Kicinski wrote:
> > > Per our discussion last fall, I've been working on a bridge between bugzilla
> > > and public-inbox, which went live in the past few days. It's still a very
> > > early release, but it can do the following:
> >
> > What about closing the bugs once they had been fixed/triaged/proven
> > invalid?
>
> For now, bugbot can look at a branch in a git repo and close bugs when it sees
> a matching "Closes:" trailer.

Interesting. Obviously that assumes the bug needs a fix, and we're
talking bugzilla so lots of clueless people lobbing non-issues at us.

But also - Closes: is a legit trailer now? I thought we only allow Link:

In any case - I'm guessing I just don't have permissions to close the
issues via web. Is your preference to iterate on the bot or maintainers
to request permissions in BZ (how?)?

2023-05-05 19:52:41

by Jakub Kicinski

[permalink] [raw]
Subject: Re: Introducing bugbot

On Fri, 5 May 2023 15:39:38 -0400 Konstantin Ryabitsev wrote:
> On Fri, May 05, 2023 at 12:32:26PM -0700, Jakub Kicinski wrote:
> > Interesting. Obviously that assumes the bug needs a fix, and we're
> > talking bugzilla so lots of clueless people lobbing non-issues at us.
>
> This is why anyone can create a bug on bugzilla, but only a subset of people
> can enable bugbot on it (by setting the bugbot+ flag).

Makes sense!

> > But also - Closes: is a legit trailer now? I thought we only allow Link:
>
> It's a semi-legit trailer and is going through -next:
> https://docs.kernel.org/next/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

Ah, must have come in this merge window, cause we don't have that text
in networking trees yet. GTK.

> > In any case - I'm guessing I just don't have permissions to close the
> > issues via web. Is your preference to iterate on the bot or maintainers
> > to request permissions in BZ (how?)?
>
> Yes, it's not a power granted by default, but people just need to ask.
> You should have this awesome power now.

Can confirm, thanks!