From: Palmer Dabbelt <[email protected]>
This trips up a maybe-uninitialized warning, but it's actually just not
used.
Signed-off-by: Palmer Dabbelt <[email protected]>
---
I just stumbled into this one when trying to test Linus' master. I'm
not sure it's a sane fix, but I'm not using the driver. No rush no my
end, I'll just keep the fix around in my local tree for now.
---
drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
index abfc077fb0a8..3fc0913ec73b 100644
--- a/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
+++ b/drivers/phy/mediatek/phy-mtk-hdmi-mt8195.c
@@ -213,7 +213,7 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw,
u64 tmds_clk, pixel_clk, da_hdmitx21_ref_ck, ns_hdmipll_ck, pcw;
u8 txpredivs[4] = { 2, 4, 6, 12 };
u32 fbkdiv_low;
- int i, ret;
+ int i;
pixel_clk = rate;
tmds_clk = pixel_clk;
@@ -295,8 +295,6 @@ static int mtk_hdmi_pll_calc(struct mtk_hdmi_phy *hdmi_phy, struct clk_hw *hw,
mtk_hdmi_pll_set_hw(hw, PLL_PREDIV, fbkdiv_high, fbkdiv_low,
PLL_FBKDIV_HS3, posdiv1, posdiv2, txprediv,
txposdiv, digital_div);
- if (ret)
- return -EINVAL;
return 0;
}
--
2.40.0
On 04-05-23, 17:19, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <[email protected]>
>
> This trips up a maybe-uninitialized warning, but it's actually just not
> used.
Thanks but this is already fixed by 714dd3c29a22 ("phy: mediatek: hdmi:
mt8195: fix uninitialized variable usage in pll_calc") in phy/next and
should be in Linus's tree shortly
--
~Vinod