2023-05-05 02:50:00

by ye.xingchen

Subject: [PATCH] dma-buf: Use fdget()

From: Ye Xingchen <[email protected]>

convert the fget() use to fdget().

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/dma-buf/dma-buf.c | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index aa4ea8530cb3..bf4980b6f80c 100644
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -729,19 +729,17 @@ EXPORT_SYMBOL_NS_GPL(dma_buf_fd, DMA_BUF);
*/
struct dma_buf *dma_buf_get(int fd)
{
- struct file *file;
-
- file = fget(fd);
+ struct fd f = fdget(fd);

- if (!file)
+ if (!f.file)
return ERR_PTR(-EBADF);

- if (!is_dma_buf_file(file)) {
- fput(file);
+ if (!is_dma_buf_file(f.file)) {
+ fdput(f);
return ERR_PTR(-EINVAL);
}

- return file->private_data;
+ return f.file->private_data;
}
EXPORT_SYMBOL_NS_GPL(dma_buf_get, DMA_BUF);

--
2.25.

2023-05-11 05:45:44

by Al Viro

Subject: Re: [PATCH] dma-buf: Use fdget()

On Fri, May 05, 2023 at 10:18:47AM +0800, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> convert the fget() use to fdget().

NAK.