2023-05-06 09:10:57

by Bough Chen

Subject: [PATCH 1/2] gpio: vf610: switch to dynamic allocat GPIO base

From: Haibo Chen <[email protected]>

gpiolib want to get completely rid of static gpiobase allocation,
so switch to dynamic allocat GPIO base, also can avoid warning
message:

[ 1.529974] gpio gpiochip0: Static allocation of GPIO base
is deprecated, use dynamic allocation.

Signed-off-by: Haibo Chen <[email protected]>
---
drivers/gpio/gpio-vf610.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
index d3f3a69d4907..70e16cef7738 100644
--- a/drivers/gpio/gpio-vf610.c
+++ b/drivers/gpio/gpio-vf610.c
@@ -259,7 +259,6 @@ static void vf610_gpio_disable_clk(void *data)
static int vf610_gpio_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
- struct device_node *np = dev->of_node;
struct vf610_gpio_port *port;
struct gpio_chip *gc;
struct gpio_irq_chip *girq;
@@ -319,7 +318,7 @@ static int vf610_gpio_probe(struct platform_device *pdev)
gc->parent = dev;
gc->label = dev_name(dev);
gc->ngpio = VF610_GPIO_PER_PORT;
- gc->base = of_alias_get_id(np, "gpio") * VF610_GPIO_PER_PORT;
+ gc->base = -1;

gc->request = gpiochip_generic_request;
gc->free = gpiochip_generic_free;
--
2.34.1

2023-05-06 13:06:37

by Linus Walleij

Subject: Re: [PATCH 1/2] gpio: vf610: switch to dynamic allocat GPIO base

On Sat, May 6, 2023 at 10:56 AM <[email protected]> wrote:

> From: Haibo Chen <[email protected]>
>
> gpiolib want to get completely rid of static gpiobase allocation,
> so switch to dynamic allocat GPIO base, also can avoid warning
> message:
>
> [ 1.529974] gpio gpiochip0: Static allocation of GPIO base
> is deprecated, use dynamic allocation.
>
> Signed-off-by: Haibo Chen <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij