2023-05-07 20:41:30

by Matti Lehtimäki

[permalink] [raw]
Subject: [PATCH 0/6] Enable MSM8226 TSENS support

Add support for tsens in MSM8226. Add qfprom compatible for MSM8226.
Add device tree nodes for qfprom, tsens and thermal zones for MSM8226.

Matti Lehtimäki (6):
dt-bindings: nvmem: qfprom: Add compatible for MSM8226
dt-bindings: thermal: tsens: Add compatible for MSM8226
thermal/drivers/qcom/tsens-v0_1: Add support for MSM8226
ARM: dts: msm8226: Add qfprom node
ARM: dts: msm8226: Add tsens node and related nvmem cells
ARM: dts: msm8226: Add thermal zones node

.../bindings/nvmem/qcom,qfprom.yaml | 1 +
.../bindings/thermal/qcom-tsens.yaml | 1 +
arch/arm/boot/dts/qcom-msm8226.dtsi | 164 ++++++++++++++++++
drivers/thermal/qcom/tsens-v0_1.c | 27 ++-
drivers/thermal/qcom/tsens.c | 3 +
drivers/thermal/qcom/tsens.h | 2 +-
6 files changed, 196 insertions(+), 2 deletions(-)

--
2.34.1


2023-05-07 20:43:11

by Matti Lehtimäki

[permalink] [raw]
Subject: [PATCH 1/6] dt-bindings: nvmem: qfprom: Add compatible for MSM8226

Document QFPROM compatible for MSM8226.

Signed-off-by: Matti Lehtimäki <[email protected]>
---
Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
index 2173fe82317d..0baf7819ab46 100644
--- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
+++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
@@ -20,6 +20,7 @@ properties:
- qcom,apq8084-qfprom
- qcom,ipq8064-qfprom
- qcom,ipq8074-qfprom
+ - qcom,msm8226-qfprom
- qcom,msm8916-qfprom
- qcom,msm8974-qfprom
- qcom,msm8976-qfprom
--
2.34.1

2023-05-07 20:44:18

by Luca Weiss

[permalink] [raw]
Subject: Re: [PATCH 1/6] dt-bindings: nvmem: qfprom: Add compatible for MSM8226

On Sonntag, 7. Mai 2023 22:12:19 CEST Matti Lehtim?ki wrote:
> Document QFPROM compatible for MSM8226.
>
> Signed-off-by: Matti Lehtim?ki <[email protected]>

Reviewed-by: Luca Weiss <[email protected]>

> ---
> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml index
> 2173fe82317d..0baf7819ab46 100644
> --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> @@ -20,6 +20,7 @@ properties:
> - qcom,apq8084-qfprom
> - qcom,ipq8064-qfprom
> - qcom,ipq8074-qfprom
> + - qcom,msm8226-qfprom
> - qcom,msm8916-qfprom
> - qcom,msm8974-qfprom
> - qcom,msm8976-qfprom




2023-05-07 21:53:52

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 1/6] dt-bindings: nvmem: qfprom: Add compatible for MSM8226


On Sun, 07 May 2023 23:12:19 +0300, Matti Lehtimäki wrote:
> Document QFPROM compatible for MSM8226.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---
> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml

doc reference errors (make refcheckdocs):
Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst
MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

2023-05-08 09:19:10

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/6] dt-bindings: nvmem: qfprom: Add compatible for MSM8226



On 7.05.2023 23:25, Rob Herring wrote:
>
> On Sun, 07 May 2023 23:12:19 +0300, Matti Lehtimäki wrote:
>> Document QFPROM compatible for MSM8226.
>>
>> Signed-off-by: Matti Lehtimäki <[email protected]>
>> ---
>> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
>> 1 file changed, 1 insertion(+)
>>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.example.dtb: pcie-ep@33800000: Unevaluated properties are not allowed ('assigned-clock-parents', 'assigned-clock-rates', 'assigned-clocks' were unexpected)
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: camera@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.example.dtb: camera-sensor@3c: port:endpoint:data-lanes: [[1]] is too short
> From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/ovti,ov2685.yaml
>
> doc reference errors (make refcheckdocs):
> Documentation/usb/gadget_uvc.rst: Documentation/userspace-api/media/v4l/pixfmt-packed.yuv.rst
> MAINTAINERS: Documentation/devicetree/bindings/pwm/pwm-apple.yaml
Rob, your bot seems to have picked up a false positive

Konrad
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/[email protected]
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>

2023-05-10 14:08:56

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/6] dt-bindings: nvmem: qfprom: Add compatible for MSM8226

On 07/05/2023 22:12, Matti Lehtimäki wrote:
> Document QFPROM compatible for MSM8226.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---
> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Bot's errors can be ignored.

Best regards,
Krzysztof


2023-06-13 23:55:28

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 0/6] Enable MSM8226 TSENS support

On Sun, 7 May 2023 23:12:18 +0300, Matti Lehtimäki wrote:
> Add support for tsens in MSM8226. Add qfprom compatible for MSM8226.
> Add device tree nodes for qfprom, tsens and thermal zones for MSM8226.
>
> Matti Lehtimäki (6):
> dt-bindings: nvmem: qfprom: Add compatible for MSM8226
> dt-bindings: thermal: tsens: Add compatible for MSM8226
> thermal/drivers/qcom/tsens-v0_1: Add support for MSM8226
> ARM: dts: msm8226: Add qfprom node
> ARM: dts: msm8226: Add tsens node and related nvmem cells
> ARM: dts: msm8226: Add thermal zones node
>
> [...]

Applied, thanks!

[4/6] ARM: dts: msm8226: Add qfprom node
commit: 16a9fa7ab27b69be3a34b97ff8c7b034fcc73b88
[5/6] ARM: dts: msm8226: Add tsens node and related nvmem cells
commit: 0f8861c9fc7cc9af6d6f65d6657aa9cf2531b29c
[6/6] ARM: dts: msm8226: Add thermal zones node
commit: 8d4236f62f3acbc6a0def79106c13fe7344d8238

Best regards,
--
Bjorn Andersson <[email protected]>

2023-07-13 10:28:38

by Srinivas Kandagatla

[permalink] [raw]
Subject: Re: [PATCH 1/6] dt-bindings: nvmem: qfprom: Add compatible for MSM8226



On 07/05/2023 21:12, Matti Lehtimäki wrote:
> Document QFPROM compatible for MSM8226.
>
> Signed-off-by: Matti Lehtimäki <[email protected]>
> ---

Applied thanks,

--srini
> Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> index 2173fe82317d..0baf7819ab46 100644
> --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml
> @@ -20,6 +20,7 @@ properties:
> - qcom,apq8084-qfprom
> - qcom,ipq8064-qfprom
> - qcom,ipq8074-qfprom
> + - qcom,msm8226-qfprom
> - qcom,msm8916-qfprom
> - qcom,msm8974-qfprom
> - qcom,msm8976-qfprom